Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUnify `FilteredQuerySource` and `SelectStatement` #760
Comments
added a commit
that referenced
this issue
Feb 25, 2017
sgrif
referenced this issue
Feb 25, 2017
Closed
Unify `FilteredQuerySource` and `SelectStatement` #763
sgrif
closed this
in
636ccd3
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sgrif commentedFeb 24, 2017
The reason
FilteredQuerySourceexists is basically to say "select was never called explicitly". This is because we wantupdate(users.filter(id.eq(1)))to work, but notupdate(users.select(id)), since that's nonsense.Right now,
SelectStatementfirst comes into play at theAsQuerylevel. Atablewill implementAsQueryby doingSelectStatement::simple(all_columns, self). Rather than passingall_columnsthere, I'd like to introduce some sort of "default select clause" marker, and then only implementUpdateTargetforSelectStatementwhen the select clause is that marker.