/diesel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxed queries do not work with `print_sql!` and `debug_sql!` #947

Closed
sgrif opened this Issue Jun 11, 2017 · 3 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sgrif @theduke
@sgrif
Member

sgrif commented Jun 11, 2017

This is because at the time of boxing we specify the backend. I'm actually not entirely sure how we can fix this, since we can't just take Box<QueryFragment<DB> + QueryFragment<Debug>>. It may be a non-issue once we get logging sorted, but it's a shame that this doesn't "just work"
@theduke

This comment has been minimized.

Sign in to view
Contributor

theduke commented Jun 24, 2017

Could QueryFragment have a trait bound for Debug?
@sgrif

This comment has been minimized.

Sign in to view
Member

sgrif commented Jun 27, 2017

No, becuase QueryFragment<DB>: QueryFragment<Debug> means that QueryFragment<Debug>: QueryFragment<Debug> which is cyclic
@sgrif

This comment has been minimized.

Sign in to view
Member

sgrif commented Jul 30, 2017

Fixed by #1051

@sgrif sgrif closed this Jul 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment