`get_result` return err `NotFound` when upsert on_conflict do_nothing

[zhangsoledad]

• diesel 0.13.0

• rust 1.18 stable

User<'a> {
   name: &'a str
}

fn save(user: User) -> Result {
    match diesel::insert(&user.on_conflict(users::name, do_nothing()))
                .into(users::table)
                .get_result::<User>(conn) {
        Ok(_) => Ok(()),
        Err(e) => {
            debug!("save user {:?}", e);
            Err(e)
        }
    }
}

save(User{name: "123"}).unwrap(); //ok
save(User{name: "123"}).unwrap(); //wrong get NotFound

is this by design?

[sgrif]

It's a bit of a quirky interaction between those two features, but yeah it's by design. I don't think that specifically passing an upsert with do_nothing to insert should change the return type of get_result, as that's a really non-local change. You should call .optional here if you want a QueryResult<Option<User>> as per the docs