Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDefine and implement a common style for function-like macros #977
Comments
killercup
added
the
discussion desired
label
Jun 29, 2017
killercup
referenced this issue
Jun 29, 2017
Closed
Allow trailing commas in sql_function! arguments list #959
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
killercup commentedJun 29, 2017
Diesel currently has a bunch of macros that are called like functions, e.g.
joinable!,numeric_expr!,operator_allowed!, andsql_function!. In contrast to regular Rust functions, macros can consume arbitrary tokens, so guessing the correct way to call a macros is not always easy.To make this a bit more consistent in Diesel's code base and user projects, we should settle on some general guidelines. The general idea is to be consistent and not surprise users with weird syntax.