Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upOptional lazy loading of C dependencies #999
Comments
sgrif
changed the title from
Optional lazy linking of C dependencies
to
Optional lazy loading of C dependencies
Jul 5, 2017
sgrif
added this to the 1.0 milestone
Jul 5, 2017
This comment has been minimized.
|
I think this is one of the bigger 1.0 blockers. I can figure this out if needed, but if there's someone with more experience in this space we would love a PR for this |
killercup
added
cli
enhancement
labels
Jul 11, 2017
killercup
referenced this issue
Jul 14, 2017
Closed
error installing rust_cli: cannot find -lmysqlclient #755
This comment has been minimized.
|
Just talked to @skade who's now searched for and found the |
This comment has been minimized.
skade
commented
Jul 23, 2017
|
Would it also be possible to also ship diesel cli as a binary? For example, half of my hefty heroku build times are just building the CLI. |
This comment has been minimized.
|
@skade Are you using https://github.com/sgrif/heroku-buildpack-diesel ? If so just add a |
This comment has been minimized.
|
This isn't happening for 1.0 |
sgrif commentedJul 5, 2017
•
edited
A common source of questions in gitter and issues here are people who write
cargo install diesel_cliand don't have all the backends installed. This was less of an issue when we only supported 2 backends. It's becoming a bit more of an issue with 3 (though I still think the situation is better than the alternative of havingcargo install diesel_clinot work, and require backends to always be specified).What I'd like to do is optionally allow our C dependencies to lazily load the dylibs, and not need to be present for linking. That means that you'd only see an error about mysql if you tried to run CLI with a MySQL URL (and we can probably provide a better error message than the linker is providing). I'd like to keep the footprint on this small, as I don't expect anybody to use this functionality besides Diesel CLI.