New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a way to provide a backend specific create table statement for #1676

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@weiznich
Contributor

weiznich commented May 4, 2018

the migration table

Different databases uses different sql dialects. While the current
table statement for the migration table works on all supported
backends it is a show stopper while implementing a new backend for
supporting a oracle database.

Technically this commit is a breaking change. This may affect only
custom backend implementation. We are not aware of any such
implementation. (Because of that I've requested a review from the other @diesel-rs/core members)

cc @pgab

@weiznich weiznich requested a review from diesel-rs/core May 4, 2018

Adding a way to provide a backend specific create table statement for
the migration table

Different databases uses different sql dialects. While the current
table statement for the migration table works on all supported
backends it is a show stopper while implementing a new backend for
supporting a oracle database.

Technically this commit is a breaking change. This may affect only
custom backend implementation. We are not aware of any such
implementation.

@weiznich weiznich force-pushed the weiznich:feature/migration_connection branch from adbc443 to 301dcdc May 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment