1.4.x: Update 'libsqlite3-sys' to 0.22

[SergioBenitez]

Update libsqlite3-sys. Without this update, Rocket's rocket_contrib, which depends on diesel, cannot update other dependencies, resulting in quite a few out of date dependencies.

Unless the CI does something special, this will almost certainly fail the CI. The 1.4.x branch seems to be in a rather broken state. rust-toolchain points to an MSRV that is incorrect, and the source doesn't build due to a deny. In any case, here's the PR.

[weiznich]

Looks good from my side, but this needs a Changelog entry before merging + a rebase/merge of the commit that fixes the mysql CI

Unless the CI does something special, this will almost certainly fail the CI. The 1.4.x branch seems to be in a rather broken state. rust-toolchain points to an MSRV that is incorrect, and the source doesn't build due to a deny. In any case, here's the PR.

To clarify that neither is the branch in a "broken" state nor is the MSRV set incorrectly. (We don't define MSRV as diesel and any version of it's dependencies will built at that rust version, but only: There is a set of dependency versions where diesel and all dependencies build at that version. We check this by using -Z minimal-versions + some manual updates to fix broken dependencies). CI is expected to succeed. It set's RUSTFLAGS=--cap-lints=warn in a similar way than cargo handles denys in dependencies.

[SergioBenitez]

Unless the CI does something special, this will almost certainly fail the CI. The 1.4.x branch seems to be in a rather broken state. rust-toolchain points to an MSRV that is incorrect, and the source doesn't build due to a deny. In any case, here's the PR.

To clarify that neither is the branch in a "broken" state nor is the MSRV set incorrectly. (We don't define MSRV as diesel and any version of it's dependencies will built at that rust version, but only: There is a set of dependency versions where diesel and all dependencies build at that version. We check this by using -Z minimal-versions + some manual updates to fix broken dependencies). CI is expected to succeed. It set's RUSTFLAGS=--cap-lints=warn in a similar way than cargo handles denys in dependencies.

Got it. So the CI does do something special. This deviates significantly from the norm in Rust ecosystem, where, aside from system-level dependencies, crates are generally expected to compile with cargo check. I also see no mention of this at all anywhere in the repository. Specifically, doing as CONTRIBUTING suggests results in the myriad errors I allude to.

Looks good from my side, but this needs a Changelog entry before merging + a rebase/merge of the commit that fixes the mysql CI

Done, though I wasn't quite sure which date to use in the CHANGELOG, so I've just used today's.

[SergioBenitez]

The CI is failing on nightly because derive-error-chain uses dependency versions like 0.11.x which appear to no longer be accepted by Cargo. This seems to be caused by rust-lang/cargo#9508. Polling there.

[weiznich]

Thanks for the update. I've field https://github.com/rust-lang/rust/issues/85986 for the regression, let's see what's the response there. I will wait till monday or so with the actual release to see if we need to take actions on that cargo regression or not.

Got it. So the CI does do something special. This deviates significantly from the norm in Rust ecosystem, where, aside from system-level dependencies, crates are generally expected to compile with cargo check. I also see no mention of this at all anywhere in the repository. Specifically, doing as CONTRIBUTING suggests results in the myriad errors I allude to.

Right it does something special. I do not want to include that into CONTRIBUTING as we normally do not accept PR's to any other branch than master, beside special cases like this one. The next major release will likely fix that issue, by just removing #[deny(warnings)] before release.

[weiznich]

Just want to leave a comment here that I haven't found the time to do a release today. I will try finding some time tomorrow.

[weiznich]

Published as 1.4.7 🎉

[SergioBenitez]

Awesome. Thank you!