Ensure compatibility with 2021 edition by working around cargo featur… #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiznich
force-pushed
the
2021_edition_fixes
branch
from
2ce3acc
to
88a959f
Compare
…e resolver related breaking changes
weiznich
force-pushed
the
2021_edition_fixes
branch
from
88a959f
to
854616d
Compare
|
Am I right in understanding that we don't need this change for master? |
|
The underlying problem happens because diesel is a direct and a build time dependency for diesel_migrations. The new feature resolver doesn't unify any features between those two diesel versions anymore, but it does unify features for diesel_derives. This leads to a situation where diesel_derives is generating code for the build time diesel version which depends on features that are disabled. |
pksunkara
approved these changes
Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e resolver related breaking changes
Addresses #2753 as this will unfortunately become the new default in the 2021 edition (regardless that this seems to be in conflict with any of the guarantees given which changes are allowed at edition boundary)
CC rust-lang/rust#88903