Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Set up the groundwork for multi-table joins #928
This solves the fundamental problem of needing
This does require that there is an
It should be noted that this commit does not enable multi-table joins on
However, with this change, all of the limitations that prevent
This looks good overall except those cryptic error messages. I'm not sure we can improve them though.
This looks good! It's pretty clever, but the right amount of cleverness for the job.
I'm pretty sure I understood what is happening in which cases (and I'm already looking forward to reading #930), but I've left some questions (and suggestions) inline. I also added some comments with general observations, I hope that's okay and doesn't distract too much from the other feedback.