Skip to content
Commits on May 15, 2010
  1. 2.25.5

    Matthias Clasen committed May 14, 2010
  2. Updates

    Matthias Clasen committed May 14, 2010
  3. Fix issues with GSETTINGS_CHECK_RULE

    Rename the --schema-files option to --schema-file, since it only
    accepts one file at a time. Change the GSETTINGS_CHECK_RULE to
    use it that way, too. And also make it work better with !srcdir
    builds.
    
    Bugs #616731 and #616864
    Matthias Clasen committed May 14, 2010
  4. GDBus: Use specific variant type in GetAll()

    Without this fix, we segfault if the exported object returned an error
    on all get_property() calls (in reality, this never happens).
    
    Signed-off-by: David Zeuthen <davidz@redhat.com>
    David Zeuthen committed May 14, 2010
  5. GDBus: Fix a double free

    Fix an unintentional double free introduced in commit
    4ad4c30.
    
    This bug manifested itself when trying to complete this
    
     $ gdbus introspect --system --dest <tab>
    David Zeuthen committed May 14, 2010
Commits on May 14, 2010
  1. Plug mem leaks in gdbus tests & examples

    Use "&s" instead of "s", and free the variant iters after use.
    
    Bug #618663.
    Christian Persch committed May 14, 2010
  2. Plug a mem leak in gdbusauth

    From valgrind running gdbus-peer test:
    
    ==20513== 32 bytes in 1 blocks are definitely lost in loss record 1 of 15
    ==20513==    at 0x4024E4C: realloc (vg_replace_malloc.c:429)
    ==20513==    by 0x4079BB1: g_realloc (gmem.c:174)
    ==20513==    by 0x4099472: g_string_maybe_expand (gstring.c:396)
    ==20513==    by 0x409A42A: g_string_insert_c (gstring.c:1050)
    ==20513==    by 0x42169AC: g_string_append_c_inline (gstring.h:153)
    ==20513==    by 0x421682C: _my_g_input_stream_read_line_safe (gdbusauth.c:336)
    ==20513==    by 0x421843E: _g_dbus_auth_run_server (gdbusauth.c:1265)
    ==20513==    by 0x4222B94: initable_init (gdbusconnection.c:1783)
    ==20513==    by 0x41CF8D5: g_initable_init (ginitable.c:106)
    ==20513==    by 0x41CFA8D: g_initable_new_valist (ginitable.c:219)
    ==20513==    by 0x41CF920: g_initable_new (ginitable.c:139)
    ==20513==    by 0x4223479: g_dbus_connection_new_sync (gdbusconnection.c:2046)
    
    Bug #618650.
    Christian Persch committed May 14, 2010
  3. Plug mem leak in g_dbus_address_get_stream_sync

    ==6279== 21,615 (4,708 direct, 16,907 indirect) bytes in 169 blocks are
    definitely lost in loss record 12 of 13
    ==6279==    at 0x4024D2E: malloc (vg_replace_malloc.c:207)
    ==6279==    by 0x4079A90: g_malloc (gmem.c:135)
    ==6279==    by 0x4079DC8: g_malloc_n (gmem.c:252)
    ==6279==    by 0x4097E66: g_strsplit (gstrfuncs.c:2434)
    ==6279==    by 0x42169A2: g_dbus_address_get_stream_sync
    (gdbusaddress.c:875)
    
    Bug #618622.
    Christian Persch committed May 14, 2010
  4. Plug a mem leak in get_uninitialized_connection

    Free the bus address after creating the singleton.
    
    ==26308== 39,736 (10,517 direct, 29,219 indirect) bytes in 388 blocks
    are definitely lost in loss record 14 of 15
    ==26308==    at 0x4024D2E: malloc (vg_replace_malloc.c:207)
    ==26308==    by 0x4079A90: g_malloc (gmem.c:135)
    ==26308==    by 0x4079DC8: g_malloc_n (gmem.c:252)
    ==26308==    by 0x4095607: g_strdup (gstrfuncs.c:102)
    ==26308==    by 0x4216B9A: g_dbus_address_get_for_bus_sync
    (gdbusaddress.c:961)
    ==26308==    by 0x422A7AE: get_uninitialized_connection
    (gdbusconnection.c:5241)
    
    Bug #618622.
    Christian Persch committed May 14, 2010
  5. Plug mem leaks in parse_value_from_blob

    The result of read_string() was leaked.
    
    Bug #618615.
    Christian Persch committed May 14, 2010
  6. Plug a mem leak

    This code leaked the return value of g_variant_get_child_value();
    use g_variant_get() instead and free the iter when done.
    Christian Persch committed with Matthias Clasen May 14, 2010
  7. GDBus: Remove cached value if a property is invalidated

    Also add a test case to catch this.
    
    Signed-off-by: David Zeuthen <davidz@redhat.com>
    David Zeuthen committed May 14, 2010
  8. GDBus: Fix serialization of empty arrays

    It turns out that we didn't observe padding (neither when reading nor
    writing) for empty arrays which (apparently) is needed according to
    the D-Bus spec and reference implementation. A simple test case to
    provoke this behavior is as follows (notice the lack of 4 bytes worth
    of padding at position 0x0064):
    
     Error calling dbus_message_demarshal() on this blob: org.freedesktop.DBus.Error.InvalidArgs: Message is corrupted (Alignment padding not null)
     0000: 6c 01 00 01  2e 00 00 00  41 00 00 00  37 00 00 00    l.......A...7...
     0010: 08 01 67 00  08 73 61 7b  73 76 7d 61  73 00 00 00    ..g..sa{sv}as...
     0020: 01 01 6f 00  08 00 00 00  2f 66 6f 6f  2f 62 61 72    ..o...../foo/bar
     0030: 00 00 00 00  00 00 00 00  03 01 73 00  06 00 00 00    ..........s.....
     0040: 4d 65 6d 62  65 72 00 00  11 00 00 00  30 31 32 33    Member......0123
     0050: 34 35 36 37  38 39 30 31  32 33 34 35  36 00 00 00    4567890123456...
     0060: 00 00 00 00  0e 00 00 00  09 00 00 00  53 6f 6d 65    ............Some
     0070: 74 68 69 6e  67 00                                    thing.
    
     The blob was generated from the following GVariant value:
     ('01234567890123456', @a{sv} {}, ['Something'])
    
     If the blob was encoded using DBusMessageIter, the payload would have been:
    
     0000: 6c 01 00 01  32 00 00 00  41 00 00 00  36 00 00 00    l...2...A...6...
     0010: 01 01 6f 00  08 00 00 00  2f 66 6f 6f  2f 62 61 72    ..o...../foo/bar
     0020: 00 00 00 00  00 00 00 00  03 01 73 00  06 00 00 00    ..........s.....
     0030: 4d 65 6d 62  65 72 00 00  08 01 67 00  08 73 61 7b    Member....g..sa{
     0040: 73 76 7d 61  73 00 00 00  11 00 00 00  30 31 32 33    sv}as.......0123
     0050: 34 35 36 37  38 39 30 31  32 33 34 35  36 00 00 00    4567890123456...
     0060: 00 00 00 00  00 00 00 00  0e 00 00 00  09 00 00 00    ................
     0070: 53 6f 6d 65  74 68 69 6e  67 00                       Something.
     ** ERROR:gdbus-serialization.c:547:check_serialization: code should not be reached
     Aborted
    
    and this is now in the libdbus-1-using serialization test case.
    
    Signed-off-by: David Zeuthen <davidz@redhat.com>
    David Zeuthen committed May 14, 2010
  9. Updated Spanish translation

    Jorge González committed May 14, 2010
  10. bump version

    Matthias Clasen committed May 14, 2010
  11. 2.25.4

    Matthias Clasen committed May 14, 2010
  12. @desrt
  13. another !srcdir build fix

    Matthias Clasen committed May 14, 2010
  14. More !srcdir build fixes

    Matthias Clasen committed May 14, 2010
  15. @desrt

    include gunixcredentialsmessage from unixsocket

    fixes a build issue
    desrt committed May 14, 2010
  16. Cleanups

    Sort #includes a bit better, and don't include platform-specific
    headers in gio.h.
    Matthias Clasen committed May 14, 2010
  17. Fix !srcdir build

    Thankfully we already had a SRCDIR define.
    Matthias Clasen committed May 14, 2010
  18. Fix a typo

    Matthias Clasen committed May 14, 2010
  19. Updates

    Matthias Clasen committed May 14, 2010
  20. Documentation cleanups

    Matthias Clasen committed May 14, 2010
  21. Merge branch 'gdbus-merge'

    Conflicts:
    	docs/reference/gio/gio-docs.xml
    	docs/reference/gio/gio-sections.txt
    	gio/tests/Makefile.am
    Matthias Clasen committed May 13, 2010
  22. Remove a reference to Pango

    Matthias Clasen committed May 11, 2010
  23. The default timeout is 25s

    Matthias Clasen committed May 13, 2010
  24. Document more floating variant details.

    Matthias Clasen committed May 13, 2010
  25. Add some more details to the long description

    Matthias Clasen committed May 13, 2010
  26. Clean up platform-specific includes

    The problem was pointed out in bug 618029. To solve it, we moved
    the GUnixFDList typedef to giotypes.h.
    Matthias Clasen committed May 13, 2010
Commits on May 13, 2010
  1. @desrt
  2. @desrt
  3. @desrt

    Add configure check for memmem()

    desrt committed May 14, 2010
  4. GDBus: update gdbus(1) man page

    David Zeuthen committed May 13, 2010
Something went wrong with that request. Please try again.