Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Oct 19, 2011
  1. @desrt

    more NEWS

    desrt authored
  2. @desrt

    The usual docs unbreaking...

    desrt authored
  3. @desrt join the cargo-cult of _cv_

    desrt authored
    For some reason, the setting of g_atomic_lock_free wasn't making it down
    to the lower part of the configure script where glibconfig.h was being
    generated when building using mingw32-configure.
    If we prefix glib_cv_ to the start of the variable name (like everyone
    else is doing) then it magically starts working.
    I love you, automake.
  4. @smcv

    gdbus-non-socket test: avoid use of a GMainContext across a fork

    smcv authored
    See for why this would
    be bad.
    Signed-off-by: Simon McVittie <>
    Reviewed-by: David Zeuthen <>
  5. @smcv

    gdbus-exit-on-close test: cover more possibilities

    smcv authored
    We didn't previously test anything except the implicit default of TRUE.
    Now we test implicit TRUE, explicit TRUE, explicit FALSE, and
    disconnecting at the local end (which regressed while fixing Bug #651268).
    Also avoid some questionable use of a main context, which fell foul of
    Bug #658999 and caused this test to be disabled in master.
    Bug-NB: NB#287088
    Signed-off-by: Simon McVittie <>
    Reviewed-by: David Zeuthen <>
  6. @smcv

    GDBusWorker: if a read was cancelled it means we closed the connection

    smcv authored
    This was a regression caused by my previous work on GDBusWorker thread-safety
    (Bug #651268). The symptom is that if you disconnect a GDBusConnection
    locally, the default implementation of GDBusConnection::closed
    terminates your process, even though it shouldn't do that for
    locally-closed connections; this is because GDBusWorker didn't think a
    cancelled read was a local close.
    Bug-NB: NB#287088
    Signed-off-by: Simon McVittie <>
    Reviewed-by: David Zeuthen <>
  7. @smcv

    Revert "Disable two GDBus tests"

    smcv authored
    This reverts commit 05ef173.
    Signed-off-by: Simon McVittie <>
    Reviewed-by: David Zeuthen <>
  8. @desrt

    Fix bug in g_static_rec_mutex_unlock_full()

    desrt authored
    pthreads doesn't implement the _lock_full() and _unlock_full() calls on
    recursive mutexes so we don't have it on GRecMutex either.  Now that
    we're using GRecMutex to implement GStaticRecMutex, we have to fake it
    by keeping an internal counter of the number of locks and calling
    g_rec_mutex_unlock() the appropriate number of times.
    The code to do this looked like:
      depth = mutex->depth;
      while (mutex->depth--)
        g_rec_mutex_unlock (rm);
      return depth;
    which unfortunately did one last decrement after mutex->depth was
    already zero (leaving it equal to -1).
    When locked the next time, the count would then increase from -1 to 0
    and then the next _unlock_full() call would not do any calls to
    g_rec_mutex_unlock(), leading to a deadlock.
Commits on Oct 18, 2011
  1. @desrt

    gatomic: introduce G_ATOMIC_LOCK_FREE

    desrt authored
    We clean up the detection of if we should do 'real' atomic operations or
    mutex-emulated ones with the introduction of a new (public) macro:
    G_ATOMIC_LOCK_FREE.  If defined, our atomic operations are guaranteed to
    be done in hardware.
    We need to use __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4 to determine if our
    compiler supports GCC-style atomic operations from the gatomic.h header
    because we might be building a program against GLib using a different
    set of compiler options (or a different compiler) than was used to build
    GLib itself.
    Unfortunately, this macro is not available on clang, so it has currently
    regressed to using the mutex emulation.  A bug about that has been
    opened here:
  2. @desrt

    gatomic: cast to the correct pointer sign

    desrt authored
    In the fallback case of the g_atomic_int_ macros we had some (gint*)
    casts that should have been (guint*) casts.
  3. [l10n] Updated German translation

    Mario Blättermann authored
  4. gio: Introduce get_sort_key() methods on GDrive, GVolume and GMount

    David Zeuthen authored
    This is needed to implement efficient and predictable proxy volume
    monitors, see

    for details.
    Signed-off-by: David Zeuthen <>
  5. @jjardon
  6. @jjardon

    gobject: Use G_VALUE_INIT

    jjardon authored
  7. @jjardon

    gio: Use G_VALUE_INIT

    jjardon authored
  8. @smcv

    GDBusConnection: Fix race in /gdbus/connection/life-cycle

    Sjoerd Simons authored smcv committed
    GDBusConnection sets the closed flag in the worker thread, then adds an
    idle callback (which refs the Connection) to signal this in the main
    thread. The tests session_bus_down doesn't spin the mainloop, so the
    "closed" signal will always fire if iterating the mainloop later (and
    drops the ref when doing so). But _is_closed can return TRUE even before
    signalling this, in which case the "closed" signal isn't fired and the
    ref isn't dropped, causing the test to fail.
    Instead simply always wait for the closed signal, which is a good thing
    to check anyway and ensures the ref is closed.
    Reviewed-by: Matthias Clasen <>
  9. @alexlarsson

    Actually Don't define GLIB_COMPILATION in libgthread

    alexlarsson authored
    Last commit was wrong, fixing it up
  10. @alexlarsson

    Don't define GLIB_COMPILATION in libgthread

    alexlarsson authored
    This was turning all the GLIB_VARs in the glib headers into
    dllexports on windows, causing all sort of nastiness. libgthread is
    mostly empty now anyway, so we don't need any GLIB_COMPILATION like
Commits on Oct 17, 2011
  1. Fix an include guard mismatch

    Matthias Clasen authored
    Spotted by Colin Walters.
  2. @alexlarsson
  3. @fanc999

    Move _glib_get_locale_dir to ggettext.c

    fanc999 authored
    -Move _glib_get_locale_dir to ggettext.c, as Matthias suggested
    -Made up for the headers that needed to be included in ggettext.c to avoid
     C4013 (implicit declaration of ...) errors/warnings
  4. @piotrdrag


    piotrdrag authored
  5. @fanc999

    Fix gio.symbols

    fanc999 authored
    g_simple_action_get_parameter_type is now static, so this symbol needs to
    be removed from here...
  6. @fanc999

    GLib: Add forgotten includes and build fixes

    fanc999 authored
    -gcharset.c, genviron.c, gunicollate.c: Some headers were missed in those
     files that triggered C4013 warnings/errors (aka. implicit declaration
     of ... in GCC).  Make up for them here.
    -gwin32.h: Only define g_win32_get_package_installation_directory/
     g_win32_get_package_installation_subdirectory as macros
     (alias of g_win32_get_package_installation_directory_utf8/
     g_win32_get_package_installation_subdirectory_utf8) on Win64 (x64) as
     g_win32_get_package_installation_subdirectory have seperate existing
     implmentations for Win32-this is a long-standing problem but was covered-
     up by G_DISABLE_DEPRECATED, which we are stopping to use as of 2.31.0.
  7. @desrt

    Revert "Bug 652827 - glib-2.29.8 no longer builds with's to…

    desrt authored
    This reverts commit 3492122.
  8. @fanc999

    Update VS property sheets

    fanc999 authored
    Some new headers were added...
  9. @fanc999

    glib/tests/thread.c: Add config guards

    fanc999 authored
    Not all systems come with unistd.h and sys/time.h, so use config guards
    on them so that they are only included when available.
  10. @fanc999

    Update VS property sheets

    fanc999 authored
    gcache.h is now a deprecated header, so up the "install" part for it.
  11. More include cleanups

    Matthias Clasen authored
  12. @fanc999

    Update VS property sheets

    fanc999 authored
    Stop using G_DISABLE_DEPRECATED as there are now warnings for usage of
    deprecated APIs/items in GLib
  13. include cleanup

    Matthias Clasen authored
  14. Make things compile again

    Matthias Clasen authored
  15. Move gettext variations into their own files

    Matthias Clasen authored
  16. Reshuffle some functions between gutils and gfileutils

    Matthias Clasen authored
    Move filename-related functions to gfileutils, and move
    size formatting functions to gutils.
  17. include cleanup

    Matthias Clasen authored
Something went wrong with that request. Please try again.