Permalink
Commits on Jul 14, 2012
  1. Updates for 2.32.4

    Matthias Clasen committed Jul 14, 2012
  2. GApplication: remove reference to non-existing example

    Matthias Clasen committed Jul 14, 2012
    There's no example called gapplication-example-menu.c in
    the gio/tests/ directory.
  3. Fix contenttype tests

    Matthias Clasen committed Jul 14, 2012
  4. Fix GModule documentation a bit

    Matthias Clasen committed Jul 13, 2012
    The documentation for g_module_make_resident was for some reason
    in the doc comment for g_module_name.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=679813
  5. GDBusNodeInfo: the XML string must contain exactly one node element

    rtcm committed with Matthias Clasen Jul 10, 2012
    Make the documentation clear about this.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=679671
  6. GVariant: fix string validation

    desrt committed with Matthias Clasen Jul 9, 2012
    String validation was done by checking if the string was valid utf8 and
    ensuring that the first non-utf8 character was the last character (ie:
    the nul terminator).
    
    No check was actually done to make sure that this byte actually
    contained a nul, however, so it was possible that you could have a
    string like "hello\xff" with length 6 that would correctly validate.
    
    Fix that, and test it.
  7. goptions: use G_N_ELEMENTS instead of nitems

    ajacoutot committed with Matthias Clasen Jul 9, 2012
  8. OpenBSD: explicitely define nitems

    ajacoutot committed with Matthias Clasen Jul 8, 2012
    nitems is never guaranteed to be defined in sys/params.h as it is meant
    to be defined within a protected ifdef __KERNEL condition.
  9. GVariant: support comparing booleans

    desrt committed with Matthias Clasen Jul 6, 2012
    g_variant_compare() is documented as working on booleans but somehow
    this case was missed.  Add it and test it.
    
    Problem discovered by Charles Kerr.
  10. GSettings: be more careful about keys names with /

    desrt committed with Matthias Clasen Jul 6, 2012
    Prevent attempts to access keys ending with slashes that exist in the
    schema file as references to child schemas.
    
    Also: don't emit change signals for these same keys.
  11. Constify collect and lcopy strings in GTypeValueTable

    Emmanuele Bassi committed with Matthias Clasen Mar 7, 2012
    This avoids warnings when creating idiomatic value tables, like:
    
      static const GTypeValueTable _clutter_shader_float_value_table = {
        clutter_value_init_shader_float,
        clutter_value_free_shader_float,
        clutter_value_copy_shader_float,
        clutter_value_peek_pointer,
        "ip",
        clutter_value_collect_shader_float,
        "pp",
        clutter_value_lcopy_shader_float
      };
    
    Because the strings are literals. And, really: nobody should be using
    allocated values for the collection and lcopy strings.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=671545
  12. Improve the g_dir_read_name documentation

    Matthias Clasen committed Jul 6, 2012
    This function can return NULL in error cases as well. Document
    this, and explain how to discriminate the cases.
    https://bugzilla.gnome.org/show_bug.cgi?id=639771
  13. Fix the 'Since' tag for G_SOURCE_{REMOVE,CONTINUE}

    bpeel committed with Matthias Clasen Jul 2, 2012
    The Since tag for these was saying 2.28 but it was actually added in
    2.31. It looks like all of the Since tags list stable version numbers
    so this patch bumps that up to 2.32.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=679258
  14. Updated codegen to work with python3.

    sfeltman committed with Matthias Clasen Jun 14, 2012
    Most changes were just replacing usage of "has_key" with "in".
    Also updated the sorting function which was simplified and
    changed to a "key" function instead of "cmp" (which is no longer
    supported in python3. Verified everything builds with
    python 2.7 and 3.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=678066
  15. Use the same Python as we found in configure

    Johan Dahlin committed with Matthias Clasen Jun 29, 2012
    Don't assume /usr/bin/python is python 2.x, on newer Ubuntu versions
    it's actually python 3.x.
  16. Fix /contenttype/guess test

    Martin Pitt committed with Matthias Clasen Jun 27, 2012
    After fixing bug 674452 this test case now reliably fails, as "ABC abc" is text
    and definitively not PowerPoint. It previously worked as g_content_type_guess()
    was reading beyond the boundary of the data due to specifying -1 as data
    length.
    
    Update that test case to expect a PO template instead, and add two more with a
    definitive PO template syntax and some binary data. We do not currently have a
    MIME magic for PowerPoint, so we cannot actually detect it with certainty, but
    at least make sure that the returned MIME type is correct.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=678941
  17. Fix the mimetype default fix

    alexlarsson committed with Matthias Clasen Jun 28, 2012
    We need to ignore the defaults.list item only when there
    was a mimetype handler found in a previous mimetype, not
    if one was found for the same mimetype as the one that
    is listed in defaults.list (same for the new-style defaults).
  18. Fix default app lookup wrt parent types and defaults.list

    alexlarsson committed with Matthias Clasen Jun 28, 2012
    There was an issue when looking up the default handler
    for a type where a supertype was listed in defaults.list.
    We would pick the default for the parent type even if
    there was a handler for the more specific type.
    
    In the case of the new-style defaults marking (
    "Default Applications" in mimeapps.list) we were already
    checking for a more specific handler befor using a default,
    but we also need to do a similar check for the defaults.list
    case.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=678944
  19. GTlsInteraction: Fix incorrect locking of mutex

    stefwalter committed with Matthias Clasen Jun 28, 2012
     * Fix incorrect locking of mutex in g_tls_interaction_invoke_ask_password()
    
    https://bugzilla.gnome.org/show_bug.cgi?id=678758
  20. gio/tests/contenttype: Call g_content_type_guess() with valid data len

    Martin Pitt committed with Matthias Clasen Jun 27, 2012
    g_content_type_guess() requires specifying a valid data length. Fixes a
    segfault when running the test.
    
    Also add an explicit check for this and return XDG_MIME_TYPE_UNKNOWN when
    data_size is specified as -1, to avoid crashing.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=674452
  21. /mainloop/timeouts test: Reduce race condition

    Martin Pitt committed with Matthias Clasen Jun 27, 2012
    Due to load, particular traits of the architecture, or other circumstances, the
    /mainloop/timeouts sometimes manages to call the "every
    100 ms" timer loop only 9 times in 1050 ms.
    
    This is an inherent race-condition in the test; allow it some slack and accept
    9 times as well.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=678959
  22. valuetransform: Fix definition of ulong_bool

    pkern committed with Matthias Clasen Jun 27, 2012
    On big endian 64 bit machines such as s390x, an uint is too small to hold a
    ulong_bool; it needs to be an actual ulong.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=678949
    http://bugs.debian.org/662057
  23. Allow slightly too small poll duration in /socket/timed_wait test

    Martin Pitt committed with Matthias Clasen Jun 26, 2012
    Sometimes the poll duration in the /socket/timed_wait test is slightly lower
    than the requested 100000, causing failures like
    
    ERROR:/build/buildd/glib2.0-2.33.2/./gio/tests/socket.c:619:test_timed_wait:
      assertion failed (poll_duration > = 100000): (99240 >= 100000)
    FAIL
    
    Adjust the test to also allow some jitter in the "too small" direction, similar
    to the already existing span for "slightly too large".
    
    https://bugzilla.gnome.org/show_bug.cgi?id=678881
  24. GDbusActionGroup: always set strict when _query_action fails

    Lars Uebernickel committed with Matthias Clasen Jun 25, 2012
  25. Remove a few redundant ;s

    Matthias Clasen committed Jun 23, 2012
  26. Add missing annotation to GDBusConnection::closed

    pclayton committed with Matthias Clasen Jun 12, 2012
    Add annotation (allow-none) to the parameter error.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=677952
  27. Update the comment in gmarshal.list

    ebassi committed with Matthias Clasen May 31, 2012
    The current note makes it look like the marshaller code generation has
    been deprecated in favour of the libffi-based generic marshaller; this
    is not the case, so we should probably clarify the point a bit.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=677235
  28. regex: Fix unicode othercasing

    Christian Persch committed with Matthias Clasen Jun 17, 2012
    The old _pcre_ucp_othercase() function was wrong in returning
    NOTACHAR (0xffffffff) for characters that aren't changed by upper-
    and lower-casing. This led to PCRE internally using incorrect (or
    at least inefficient) character classes when using G_REGEX_CASELESS.
    
    E.g. [Z-\x{100}] turned into:
    
    [Z\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{39c}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{fffe}\x{178}z-\x{101}]
    
    instead of the expected and efficient
    
    [Z\x{39c}\x{178}z-\x{101}]
    
    https://bugzilla.gnome.org/show_bug.cgi?id=678273
  29. GRand: Check return value of fopen directly

    cgwalters committed with Matthias Clasen Jun 21, 2012
    This doesn't fix anything, it should just silence some static analysis
    tools.
  30. gspawn: Abort if we can't open /dev/null

    cgwalters committed with Matthias Clasen Jun 21, 2012
    This really "shouldn't happen", but if we have an assertion here, it
    will help static analysis tools know we're not hitting undefined
    state.
  31. tests/unix: Ensure buffer is NUL terminated

    cgwalters committed with Matthias Clasen Jun 21, 2012
  32. gsignal: Properly handle NULL nodes

    cgwalters committed with Matthias Clasen Jun 21, 2012
  33. gresourcefile.c: Remove stray semicolon

    cgwalters committed with Matthias Clasen Jun 21, 2012
  34. gmenu: Remove stray semicolon in g_menu_clear_item()

    cgwalters committed with Matthias Clasen Jun 21, 2012