Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: windows
Fetching contributors…

Cannot retrieve contributors at this time

11858 lines (8273 sloc) 426.044 kb
Tue Mar 16 13:29:58 2004 Owen Taylor <>
* === Released 2.4.0 ===
* Version 2.4.0, interface age 0;
require glib-2.4.0, pango-1.4.0.
* Change gtk_binary_version to 2.4.0;
there are some compatibility issues with older theme engines.
* NEWS: Updates
* Updates
Tue Mar 16 13:54:07 2004 Jonathan Blandford <>
* gtk/gtkentry.c (gtk_entry_completion_key_press): Block the
::changed handler during the ::match-selected when done by
Tue Mar 16 00:56:11 2004 Matthias Clasen <>
* gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
Block the ::changed handler during the emission of ::match-selected.
Partial fix for #137226.
* gtk/gtkfilechooserentry.c: Remove the no longer needed
no_pop_down flag.
Tue Mar 16 00:20:51 2004 Matthias Clasen <>
* gtk/gtkfilechooserwidget.c (gtk_file_chooser_widget_new_with_backend):
Fix a typo in the docs.
2004-03-15 Tor Lillqvist <>
* README.win32: Updates.
2004-03-15 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (update_appearance): Only hide the
"create folder" button in OPEN mode; all the others should show it
(get_paths_foreach): Handle the editable row.
* gtk/gtkfilesystemunix.c (gtk_file_system_unix_create_folder):
Force a re-get of the folder so that the new directory gets added
to its hash table of file info.
2004-03-15 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (update_from_entry): In the Save
modes, set the Name entry of the file chooser if we get a
nonexistent filename from the file entry. Fixes #135911.
(gtk_file_chooser_default_set_current_name): Oops, this should
also work if we are in CREATE_FOLDER mode.
* gtk/gtkfilesystem.c (gtk_file_path_real_copy): Use
* gtk/gtkfilechooserentry.c (check_completion_callback): Free the
path that we got from the model.
(completion_match_func): Use DISPLAY_NAME_COLUMN rather than a
hard-coded constant.
Mon Mar 15 13:50:14 2004 Owen Taylor <>
* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_set_property):
Don't leak the temporary font description. (Nils O. Selåsdal)
Mon Mar 15 12:51:17 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (location_popup_handler): Only show
the title string in OPEN/SELECT_FOLDER mode as it's open-specific.
Put a blank title for SAVE/CREATE_FOLDER; we are in string freeze,
so we'll fix it for 2.4.1 as #137272.
* gtk/gtkpathbar.c (gtk_path_bar_scroll_down): calculate
space_available correctly for RTL mode. w/o this, you can't
scroll down again. Fixes #137021.
2004-03-15 Federico Mena Quintero <>
* gtk/gtkpathbar.c (gtk_path_bar_scroll_up): Queue a resize.
(gtk_path_bar_scroll_down): Likewise.
Mon Mar 15 11:40:43 2004 Owen Taylor <>
* gtk/gtkfilechooserentry.c: Store the position of the
file part and use that in check_completion_callback()
and match_selected_callback() to figure out where
to operate on the text, rather than recomputing the
Mon Mar 15 10:35:19 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): set
changing_folders to be true so we don't trigger a callback when we
remove the selection
(shortcuts_add_bookmarks): ditto
Mon Mar 15 10:47:18 2004 Owen Taylor <>
* gtk/gtkfilechooserentry.c: s/seperator/separator/.
Mon Mar 15 09:54:36 2004 Owen Taylor <>
* gtk/gtklabel.c (gtk_label_focus): Check for
Control-Tab or Control-Shift-Tab, not any Control-key
as a current event ... handles the case where a dialog
is triggered from a control accelerator better.
Mon Mar 15 08:48:48 2004 Jonathan Blandford <>
* gtk/gtkfilechooserentry.c (match_selected_callback): implement
(completion_match_func): Allow surpressing popdowns.
(maybe_append_seperator_to_path): New function to add a separator
item to a display_name. Bad hack.
(check_completion_callback): Implement select-ahead as an idle.
(add_completion_idle): new function to handle select-ahead
(gtk_file_chooser_entry_do_insert_text): starf the select-ahead
(gtk_file_chooser_entry_focus): Override tab for completion.
(gtk_file_chooser_entry_activate): commit select_ahead when
* gtk/gtkfilechooserdefault.c (location_popup_handler): grab the
appropriate widget for the mode.
2004-03-15 Tor Lillqvist <>
* gdk/win32/gdkgc-win32.c (gdk_gc_copy): Don't just copy the whole
GdkGCWin32 with a single assignment, that overwrites GObject's
private data (for instance ref_count). (#137012, John Ehresman)
2004-03-15 Mark McLoughlin <>
* gtk/gtkfilechooserdefault.c: remove the unused "lowest_folder"
GtkFileChooserDefault member. Leftover from my original patch
for bug #136987.
Mon Mar 15 01:50:28 2004 Jonathan Blandford <>
* gtkfilechooserentry.c: Rewritten to use the GtkEntryCompletion
API more correctly. Now pops down the dropdown well.
* gtkfilesystem.c (gtk_file_path_get_type): New boxed type for the
* test/testfilechooser.c: disable preview widget temporarily.
It's not representative of a good preview widget.
2004-03-15 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (shortcuts_find_current_folder):
Renamed from shortcuts_unselect_all(); now selects the row that
corresponds to the current folder, if any. Fixes #135916.
* gtk/gtkpathbar.h: Added prototypes for _gtk_path_bar_up() and
2004-03-15 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c: Surround the
drag-outside-to-remove-bookmarks code with "#if 0" blocks; it's
too unstable right now.
Sun Mar 14 23:36:15 2004 Owen Taylor <>
* gtk/gtkfilechooserdefault.c: Implement local_only by
filtering the shortcuts and bookmarks list by
gtk_file_system_path_to_filename (file_system, path) != NULL.
* gtk/gtkfilesystem.c (gtk_file_system_path_is_local): Add
a convenience function, may by interesting to push to the
file system vtable later for performance.
2004-03-14 Federico Mena Quintero <>
* gtk/gtkfilesystem.c (gtk_file_folder_get_info): Allow the path
to be NULL, so that people can ask for information about a
parent-less file system root (e.g. get_info (get_folder ("/"), NULL)).
* gtk/gtkfilesystemunix.c (gtk_file_folder_unix_get_info): Allow
the condition describe above.
* gtk/gtkfilechooserdefault.c (get_file_info): Allow getting
information of root paths.
* gtk/gtkpathbar.c (_gtk_path_bar_set_path): Handle root paths correctly.
Sun Mar 14 22:32:36 2004 Owen Taylor <>
* gtk/gtktreeview.c (gtk_tree_view_set_search_equal_func): Mention
GtkTreeViewSearchEqualFunc return value oddity here as well.
* gtk/gtktreeview.c (gtk_tree_view_search_equal_func): On failure
to get a string to compare to, return TRUE (no match), not
FALSE (match). Handle %NULL string values gracefully.
Remove unused variable. (#135962, Mark McLoughlin)
2004-03-14 Morten Welinder <>
* gtk/gtkfilesystemunix.c: Kill some debug g_prints.
Sun Mar 14 21:03:15 2004 Owen Taylor <>
* gtk/gtkpathbar.[ch]: Add _gtk_path_bar_up()/
* gtk/gtkfilechooserdefault.c: Use _gtk_path_bar_up()/
_gtk_path_bar_down() as bindings for Alt-Up
and new Alt-Down. (Partly based on a patch by
Mark McLoughlin, #136987)
2004-03-14 Federico Mena Quintero <>
Fixes #136185, patch by Morten Welinder, with some changes.
* gtk/gtkfilechooserdefault.c (check_is_folder): New helper function.
(shortcuts_insert_path): Check the path first with check_is_folder().
(gtk_file_chooser_default_set_current_folder): Likewise.
(gtk_file_chooser_default_add_shortcut_folder): Likewise.
(browse_widgets_create): Unref the size group.
* gtk/gtkfilesystemunix.c (gtk_file_system_unix_get_folder):
Handle the case where the file exists but it is not a directory.
(IconType): Add value for ICON_UNDECIDED.
(struct stat_info_entry): New structure to hold a file's struct
stat, its MIME type and its icon type.
(struct _GtkFileFolderUnix): Added a hash of struct
stat_info_entry, and flags to remember which info types we've read
so far.
(get_icon_type): Use a helper function for the icons-from-stat
(gtk_file_system_unix_render_icon): Use the cached file info.
(gtk_file_folder_unix_get_info): Put the info in the cache.
(gtk_file_system_unix_get_folder): Create the cache of file info
* gtk/gtkfilesystem.c (gtk_file_info_set_display_name): Handle the
case where display_name is the same as the existing
Sun Mar 14 19:26:48 2004 Owen Taylor <>
#136672, reported by Christian Persch; fixes based
on a patch by Soeren Sandmann.
* gtk/gtkmenu.c: Change the handling of mixed gridded
and non-gridded menu items; the old method was causing
major performance problems even with the "avoid relayout
on destruction" hack put in recently.
Now we first lay out the gridded items and then put the
non-gridded items into empty rows / after the gridded items.
Layout is done in a central menu_shell_ensure_layout(). Also
avoid emitting property notifications when we initially
insert or attach items.
* gtk/gtkmenushell.[ch] gtk/gtkmenu.c: Stop setting the
unused menu_shell->menu_flag, and document it as unused
in the header.
* tests/testactions.c: Add a test of creating/removing
lots of items.
* test/testgtk.c: Add some more cruft to the menu test.
Mon Mar 15 02:36:07 2004 Matthias Clasen <>
* gtk/gtkentrycompletion.c (gtk_entry_completion_class_init): Add
some signal docs.
Sun Mar 14 15:38:39 2004 Jonathan Blandford <>
* gtk/gtkentrycompletion.c (gtk_entry_completion_visible_func):
always use the match_func, even if text_column is set.
2004-03-14 Morten Welinder <>
* gtk/gtkfilesystemunix.c (get_parent_dir): Don't turn "/" into
(gtk_file_system_unix_get_folder): Use the same value for lookup
as for insertion. Make sure we have a directory.
* gtk/gtkfilechooserdefault.c (error_dialog): Don't crash on NULL
path; don't crash on NULL error.
2004-03-14 Hans Breuer <>
gtk/gtkcombobox.c : prototype cell_view_sync_cells() before
first usage
gtk/ : updated 'gtk_public_h_sources'
tests/makefile.msc : added testspinbutton
Sun Mar 14 01:01:18 2004 Matthias Clasen <>
* gtk/gtkcellview.c (gtk_cell_view_set_cell_data): Align
this function with gtk_tree_view_column_set_cell_data();
call the cell data func after setting the attributes.
Sun Mar 14 01:00:08 2004 Matthias Clasen <>
* gtk/gtkcellview.c (gtk_cell_view_expose): One more try;
make sure not to call gtk_cell_view_set_cell_data() when
displayed_row is NULL.
Sat Mar 13 18:13:13 2004 Owen Taylor <>
* gtk/gtktextlayout.c (gtk_text_layout_get_line_display): When not
wrapping, do the offset of the line for justification ourselves.
(#120256, Felipe Heidrich)
Sun Mar 14 00:03:18 2004 Matthias Clasen <>
* gtk/gtkcellview.c (gtk_cell_view_expose): Support the
model-less use of GtkCellView shown in testcombo.c.
2004-03-13 Tor Lillqvist <>
* gdk/win32/gdkdisplay-win32.c: Don't undefine HAVE_MONITOR_INFO
when compiling with gcc. Mingw's headers do have the required
* gdk/win32/gdkdrawable-win32.c (draw_polygon): When drawing
filled polygons, don't draw the outline, similarily as
draw_rectangle(). Apparently GTK and GIMP don't use
gdk_draw_polygon() much (or always draw the outline, too), as this
has gone undetected for so long. Thanks to Bruce Hochstetler.
Sat Mar 13 15:19:17 2004 Owen Taylor <>
* gtk/gtkwindow.c (gtk_window_destroy): Remove
the window from the toplevel_list here rather in destroy.
While this is theoretically speaking wrong, it fits
in better with the current reality that destroyed
widgets are not reusable. (#126808, Michael Natterer)
Sat Mar 13 21:47:47 2004 Matthias Clasen <>
* gtk/gtkcellview.c (gtk_cell_view_expose): Don't do anything
beyond clearing to the background if there is no active row.
(#137066, reported by Owen Taylor)
Sat Mar 13 21:37:44 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_list_key_press): Pop down the
list when an item is selected via the keyboard.
2004-03-13 Anders Carlsson <>
* gtk/gtkfilesystemunix.c: (remove_trailing_slash),
(gtk_file_system_unix_create_folder), (get_parent_dir),
(gtk_file_system_unix_get_parent), (gtk_file_folder_unix_get_info):
Remove trailing slashes in path names.
Sat Mar 13 12:17:16 2004 Owen Taylor <>
* gdk/x11/gdkwindow-x11.c (gdk_window_reparent): Make
this a total no-op when the new or old parent is
destroyed. (#134230, patch from Soeren Sandmann)
* gdk/gdkwindow.c (_gdk_window_destroy_hierarchy):
For foreign windows in our heirarchy, call
_gdk_windowing_window_destroy_foreign (window) and skip
all the normal destruction logic.
* gdk/x11/gdkwindow-x11.c gdk/win32/gdkwindow-win32.c:
Move code to request destruction of a foreign window
code into a separate _gdk_windowing_window_destroy_foreign().
* gdk/x11/gdkwindow-x11.c (gdk_window_impl_x11_finalize):
Call GDK_WINDOW_DISPLAY() on the wrapper not on the
impl. (Also from Soeren's patch)
Sat Mar 13 10:49:46 2004 Owen Taylor <>
* gtk/gtkdnd.c (_gtk_drag_dest_handle_event): For
GTK_IS_PLUG toplevels, call gdk_window_get_origin()
not gtk_window_get_position, as a hackround for not
having accurate notification of window position for
embedded windows. (#136112, Dan Winship)
Sat Mar 13 10:34:03 2004 Owen Taylor <>
* gtk/gtktextview.c gtk/gtktextbuffer.c: Revert last change;
it causes problems for pastes from other applications; see
comments in bugzilla for #81880.
Sat Mar 13 02:55:51 2004 Matthias Clasen <>
Fix middle button pasting in the TextView (#81880, reported
by Evert Verhellen, patch by Paolo Borelli):
* gtk/gtktextview.c (gtk_text_view_button_press_event): Retrieve
the insert mark and move the cursor to it making sure of also
scroll the window if needed.
* gtk/gtktextbuffer.c (pre_paste_prep): Move the insert mark
to the insertion point.
Sat Mar 13 01:38:55 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_remove): Add a remove
implemenatation which restores the cell_view when the custom
child is removed. (#136555, Owen Taylor)
Sat Mar 13 00:07:51 2004 Matthias Clasen <>
* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_layout_clear):
Keep the cell_list in a consistent state while iterating over it,
since clear_attributes() also iterates over it. (another instance
of #136585, Morten Welinder)
Fri Mar 12 17:20:15 2004 Owen Taylor <>
* gtk/gtkarrow.c (gtk_arrow_expose): Swap GTK_ARROW_LEFT
Semion Chichelnitsky)
* gtk/gtkpathbar.c gtk/gtktoolbar.c: Remove no-longer-needed
gtk_toolbar_direction-changed handlers and explicit
flipping of GtkArrow widgets.
Fri Mar 12 23:37:15 2004 Soeren Sandmann <>
* gtk/gtkfilechooserdialog.c
(file_chooser_widget_default_realized_size_changed): Clamp the
new size to the screen.
Fri Mar 12 15:06:44 2004 Owen Taylor <>
* gtk/gtkexpander.c (gtk_expander_realize): Create the
event_window at the right size using the same logic as
in size_allocate. (#136994, Niklas Knuttson)
2004-03-12 Federico Mena Quintero <>
* gtk/gtkwindow.c (gtk_window_activate_focus): Don't ignore the
return value of gtk_widget_activate().
(gtk_window_activate_default): Likewise. Fixes #137008.
* gtk/gtkfilechooserdialog.c (response_cb): Act on positive
response IDs we recognize, rather than bailing out on cancellation
ones. Fixes #136237; patch by Olivier Andrieu
(file_chooser_widget_file_activated): If the dialog doesn't have a
default widget, try to find a suitable response widget on our own.
People should *really* be using gtk_dialog_set_default_response(),
but this is to help lazy programmers.
* gtk/gtkdialog.c (_gtk_dialog_get_response_for_widget): New
internal function.
(get_response_data): Add a "create" argument so that we don't
unconditionally create the response data.
2004-03-12 Morten Welinder <>
* tests/ Add new testspinbutton.c
2004-03-11 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (shortcuts_drag_set_delete_cursor):
Put the trash icon on the right for LTR locales, or on the left
for RTL.
(shortcuts_drag_motion_cb): Cancel the idle handler here as well.
(shortcuts_drag_leave_cb): Test whether the idle is present.
(shortcuts_drag_data_received_cb): Ahem, don't assert here.
Thu Mar 11 17:51:10 2004 Owen Taylor <>
* modules/input/gtkimcontextxim.c (preedit_done_callback):
Clear preedit string and emit preedit_changed as needed
on AIX. (#130617, Philip K Warren)
2004-03-11 Morten Welinder <>
* gtk/gtkpathbar.c (_gtk_path_bar_set_file_system): Plug leak.
Thu Mar 11 16:28:15 2004 Owen Taylor <>
* gtk/gtkmenu.c (gtk_menu_get_toplevel): Fix attach/attach->parent
type. (#136919, Tim Mooney)
Thu Mar 11 16:18:51 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (shortcuts_insert_path): revert
earlier change to insert_path so that we test that the directory
* gtk/gtkfilechooserdialog.c
(gtk_file_chooser_dialog_constructor): move focus.
Thu Mar 11 22:12:14 2004 Matthias Clasen <>
* gtk/gtkspinbutton.c (gtk_spin_button_size_request): Use the same
logic as GtkEntry when calculating border width. (#116368, reported
by Morten Welinder)
Thu Mar 11 15:59:05 2004 Owen Taylor <>
* tests/testgtk.c (create_spins): Use gtk_entry_set_width_chars()
rather than gtk_widget_set_size_request().
2004-03-11 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (remove_settings_signal): New
function, copied from gtkpathbar.c.
(gtk_file_chooser_default_dispose): Use remove_settings_signal()
rather than our own code.
(gtk_file_chooser_default_screen_changed): Use
remove_settings_signal(); this should handle per-screen settings
Thu Mar 11 14:07:18 2004 Owen Taylor <>
* gtk/gtklabel.c (gtk_label_focus): Fix a missing return
Thu Mar 11 13:58:24 2004 Owen Taylor <>
* gtk/gtkmessagedialog.c gtk/gtklabel.c: Back out the
put-labels-into-the-standard-focus-chain patches
from bug #59707.
* gtk/gtklabel.c (gtk_label_focus): Only put the
label in the tab chain when the control key is pressed.
2004-03-11 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (error_message_with_parent): Use a
single OK button, not a Close button, as per the HIG.
* gtk/gtkfilesel.c (gtk_file_selection_fileop_error): Likewise.
2004-03-11 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (shortcuts_drag_motion_cb): Oops,
initialize "action" before jumping. Fixes #136900.
2004-03-11 Mark McLoughlin <>
* gtk/gtksettings.c: (apply_queued_setting): don't overwrite
application properties. Fixes bug #136802.
2004-03-11 Dov Grobgeld <>
* gtk/gtktextlayer.c: (gtk_text_layout_set_buffer): Added
call to gtk_text_layout_update_cursor_line() to solve in
problem of switching keyboard direction at widget creation:
bug #136680
Thu Mar 11 10:28:30 2004 Owen Taylor <>
* gtk/gtkfilechooserembed.c (delegate_initial_focus): Remove
stray 'return' statement. (#136855, David L. Cooper II)
2004-03-11 Mark McLoughlin <>
* gtk/gtkstyle.c: (gtk_default_draw_expander): Use the PRELIGHT
fg color for drawing the expander when prelit. Fixes problem
with the HighContrast theme: bug #136789.
2004-03-11 Federico Mena Quintero <>
Fix #135912 and #135913.
* gtk/gtkfilechooserdefault.c
(shortcuts_filter_model_row_draggable): Implement.
(shortcuts_model_filter_new): New function, create a
ShortcutsModelFilterClass derived from GtkTreeModelFilter, so that
we can implement our own DnD interface methods.
(shortcuts_model_create): Use shortcuts_model_filter_new().
(shortcuts_list_create): Enable the shortcuts list as a drag
(file_list_source_targets): Renamed from shortcuts_targets.
(shortcuts_list_create): Change the options for
gtk_drag_dest_set(). Connect to more drag signals so that we can
implement drops by hand.
(shortcuts_drag_data_delete_cb): New handler; just stop the emission.
(shortcuts_drag_motion_cb): New handler; validate the drop.
(shortcuts_drag_leave_cb): New handler; unset the drag_dest_row.
(shortcuts_drag_drop_cb): New handler; just stop the emission and
remove the idle handler for the drag cursor.
(shortcuts_add_bookmark_from_path): Add a position argument,
return a boolean success code.
(shortcuts_drag_data_received_cb): Handle two cases: 1) Insert
the bookmarks at the proper position, rather than always appending
them to the list; 2) alternatively, reorder the bookmarks.
(struct _GtkFileChooserDefault): New field shortcuts_drag_outside.
(shortcuts_drag_motion_cb): Turn off impl->shortcuts_drag_outside.
(shortcuts_drag_leave_cb): Turn on impl->shortcuts_drag_outside in
an idle handler.
(shortcuts_drag_end_cb): New handler; remove the selected bookmark.
Thu Mar 11 01:08:25 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (location_entry_create): up the
width of the entry a tad.
* gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_init): use
gtk_entry_completion_selection_changed. Also, unref the
completion as we were leaking a reference to it.
2004-03-10 Federico Mena Quintero <>
* gtk/gtkstyle.c (draw_dot): Remove spurious semicolon. Thanks to
Kjartan Maraas for pointing it out.
Wed Mar 10 23:40:15 2004 Matthias Clasen <>
* gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Set the
background on the action view cell renderer here, not in init, so
that a) we catch style changes, and b) we get the real style, not
the default one. Partial fix for #127648, reported by Dave Bordoley.
2004-03-10 Tor Lillqvist <>
* gdk/win32/gdkevents-win32.c (build_key_event_state): Set also
the pointer button bits. (#136636, Dave Neary)
* gdk/win32/gdkwindow-win32.c (show_window_internal): Show
transparent (input only) windows using SetWindowPos(). (#132331,
John Ehresman)
(gdk_window_set_type_hint): For splash screens, remove the resize
handles, menu, and minimize/maximize/close buttons. (#132896)
Wed Mar 10 22:30:23 2004 Matthias Clasen <>
* gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Keep the
cell_list in a consistent state while iterating over it, since
clear_attributes() also iterates over it. (#136585, Morten Welinder)
2004-03-10 Mark McLoughlin <>
* gtk/gtkexpander.c: (gtk_expander_expose): don't propagate
the expose to the label. The expose handler for GtkContainer
already does that. Fixes bug #136719. Reported by Dennis
Cranston, exact cause nailed down by Owen.
2004-03-10 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (list_mtime_data_func): Use an
untranslatable "%x" for dates, rather than a custom format. Fixes
2004-03-10 Morten Welinder <>
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_add_shortcut_folder): Test validity of
path here.
(shortcuts_insert_path): Don't check here.
(get_file_info): Barf if name-only fails.
* tests/testfilechooser.c (main): Add support for --multiple.
Wed Mar 10 02:41:05 2004 Jonathan Blandford <>
* gtk/gtkpathbar.c: (gtk_path_bar_init), (gtk_path_bar_class_init),
(remove_settings_signal), (gtk_path_bar_dispose),
(gtk_path_bar_style_set), (gtk_path_bar_screen_changed),
(gtk_path_bar_scroll_up), (reload_icons), (change_icon_theme),
(settings_notify_cb), (gtk_path_bar_check_icon_theme),
(get_button_image), (gtk_path_bar_update_button_appearance),
(make_directory_button), (gtk_path_bar_check_parent_path): Support
changes in icon themes.
* gtk/gtkpathbar.h: add two elements
* tests/testfilechooser.c: (main): use gnome-vfs method again to
get more testing.
Wed Mar 10 01:17:40 2004 Jonathan Blandford <>
* gtk/gtkpathbar.c: added 'Desktop' to the list of volumes. We
don't have any more untranlated strings in the dialog.
Wed Mar 10 00:24:24 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (error_dialog): use uri instead of
the pathname for UTF-8 safety.
Wed Mar 10 00:10:47 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (shortcuts_insert_path): Always
check to see if the shortcuts exists. We don't want to put
invalid dirs in the shortcuts pane.
Tue Mar 9 16:40:34 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
remove unneeded shortuts_swin;
Wed Mar 10 01:49:27 2004 Matthias Clasen <>
Fix #136614 in a better way:
* gtk/gtkoptionmenu.c (gtk_option_menu_init): Undo the last change.
* gtk/gtkbutton.c (struct _GtkButtonPrivate): Add a flag, align_set.
* gtk/gtkbutton.c (gtk_button_init): Initialize align_set to 0.
* gtk/gtkbutton.c (maybe_set_alignment): Rework to only set the
alignment if priv->align_set is set.
* gtk/gtkbutton.c (gtk_button_set_alignment): Set align_set to 1.
Wed Mar 10 01:21:05 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): Place
grid mode popups left aligned, not right aligned.
Tue Mar 9 23:09:46 2004 Matthias Clasen <>
* gtk/gtkoptionmenu.c (gtk_option_menu_init): Avoid centering
the label that is reparented from the menuitem. (#136614, Dennis
Tue Mar 9 16:19:09 2004 Jonathan Blandford <>
* gtk/gtkpathbar.c (struct _ButtonData): Encapsulate all of the
information about a button in a struct instead of ugly
(gtk_path_bar_size_request): Use ButtonData.
(gtk_path_bar_update_slider_buttons): ditto
(gtk_path_bar_size_allocate): ditto
(gtk_path_bar_remove): ditto
(gtk_path_bar_forall): ditto
(gtk_path_bar_scroll_down): ditto
(gtk_path_bar_clear_buttons): ditto
(button_clicked_cb): ditto. Also, add an ignore_changes variable
(button_data_free): destroy ButtonData
(update_button_appearance): Use ButtonData
(make_directory_button): ditto
(gtk_path_bar_check_parent_path): ditto
(_gtk_path_bar_set_path): ditto
2004-03-09 Federico Mena Quintero <>
Fix #136533.
* gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): New
(check_icon_theme): New helper function, installs a handler for
changes in the icon theme.
(gtk_file_chooser_default_style_set): Use check_icon_theme().
(gtk_file_chooser_default_screen_changed): Use check_icon_theme().
(gtk_file_chooser_default_dispose): Disconnect from GtkSettings.
(change_icon_theme): New function, updates impl->icon_size and
reloads the icons.
(struct _GtkFileChooserDefault): New field settings_signal_id.
(struct _GtkFileChooserDefault): New field icon_size.
(shortcuts_insert_path): Use impl->icon_size.
(list_icon_data_func): Likewise.
2004-03-09 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (get_file_info): Handle the returned
parent_path being NULL. Fixes #136662.
2004-03-09 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (shortcuts_drag_data_received_cb):
Stop the emission so that GtkTreeView's handler won't try to poke
the filter model. Fixes #136127.
Tue Mar 9 13:49:14 2004 Owen Taylor <>
* gtk/gtkstyle.c (gtk_paint_polygon): Fix
g_return_if_fail() that was checking draw_shadow.
(#136669, Morten Welinder)
Tue Mar 9 09:57:25 2004 Owen Taylor <>
* === Released 2.3.6 ===
* Version 2.3.6, interface age 0.
* NEWS: Updates
Tue Mar 9 11:01:45 2004 Jonathan Blandford <>
* gtk/gtkpathbar.c (gtk_path_bar_finalize): unref the correct
icon. Reported by Michael Natterer <>.
2004-03-09 Morten Welinder <>
* tests/testfilechooser.c (main): Destroy widgets to reveal leaks.
Tue Mar 9 02:11:50 2004 Soeren Sandmann <>
* gtk/gtkmenu.c Fix bug 136446. [Marco Pesenti Gritti]
(struct _GtkMenuPrivate): Add boolean destroying
(gtk_menu_destroy): Set priv->destroying
(gtk_menu_remove): don't update the table information when the
menu is being destroyed.
* gtk/gtkmenu.c (gtk_menu_set_monitor): Formatting fix
* gtk/gtktoolbar.[ch]: Some formatting fixes
Tue Mar 9 01:25:10 2004 Matthias Clasen <>
* gtk/gtkframe.c (gtk_frame_paint): Fix a typo.
2004-03-08 Federico Mena Quintero <>
Fixes #136080.
* gtk/gtkfilesystemunix.c: Only lstat() if stat() failed due to
(filename_get_info): Likewise.
2004-03-08 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_initial_focus): Use
2004-03-08 Federico Mena Quintero <>
Patch "1a" from #136185, by Morten Welinder.
* gtk/gtkfilechooserdefault.c (get_file_info): Take in an argument
that says whether the caller just wants the display name.
(shortcuts_insert_path): We only want the name in the call to
* gtk/gtkpathbar.c (_gtk_path_bar_set_path): Don't request more
info than needed from the file_folder.
2004-03-08 Federico Mena Quintero <>
Fixes #136105.
* gtk/gtkfilechooserembed.h (struct _GtkFileChooserEmbedIface):
Added an ::initial_focus() method.
* gtk/gtkfilechooserembed.c
(_gtk_file_chooser_embed_delegate_iface_init): Set the
initial_focus method.
(delegate_initial_focus): Implement.
(_gtk_file_chooser_embed_initial_focus): New function.
* gtk/gtkfilechooserdialog.c
(gtk_file_chooser_dialog_constructor): Call
* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
Install the ::initial_focus() handler.
(gtk_file_chooser_default_initial_focus): Implement.
2004-03-08 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (update_from_entry): Return a
boolean success code.
(location_popup_handler): Refocus the file chooser if appropriate.
Fixes #135905.
(save_widgets_create): Don't set the text of the save_folder_label
(update_appearance): Set the text here as appropriate for the save
mode. Also fixes #136387.
(update_appearance): Don't show the Create Folder button in
(update_appearance): Show the extra widget in all Save modes
Mon Mar 8 11:57:27 2004 Owen Taylor <>
* gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't
call g_signal_handler_disonnect() if priv->model is
NULL. (#136551, Damon Chaplin)
* gtk/gtkcombobox.c (gtk_combo_box_model_row_inserted):
Back out code to set the active item when the first
item is added to the model; this causes problems for
GtkComboBoxText. (#136535)
* gtk/gtkcombobox.c (gtk_combo_box_menu_destroy)
* gtk/gtkcombobox.c (gtk_combo_box_list_destroy):
* gtk/gtkcombobox.c (gtk_combo_box_list_setup):
* gtk/gtkcombobox.c (gtk_combo_box_menu_setup):
Remove calls to gtk_combo_box_unset_model.
* gtk/gtkcombobox.c (gtk_combo_box_check_appearance):
Clean up handling of wrap->width > 0.
* gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't
switch list/menu mode here.
* gtk/gtkcombobox.c (gtk_combo_box_set_model): Protect
against the same model being set back.
* gtk/gtkcombobox.c (gtk_combo_box_relayout): Call
gtk_combo_box_menu_fill() rather than duplicating
a large chunk of code.
2004-03-08 Anders Carlsson <>
* gtk/gtkfilesystemmodel.c (gtk_file_system_model_get_flags):
If max_depth is 0 then we have a list.
2004-03-08 Morten Welinder <>
* gtk/gtkpathbar.c (_gtk_path_bar_set_path): If we fail, leave
widget unchanged. Explicitly verify final directory.
* gtk/gtkfilesystemunix.c (gtk_file_system_unix_create_folder,
get_icon_type, filename_get_info): Protect errno.
2004-03-08 Marco Pesenti Gritti <>
* gtk/gtkentry.c: (gtk_entry_completion_key_press):
When an action is selected stop the event to be propagated
otherwise the activate signal is emitted too. (Bug #133394)
Mon Mar 8 04:50:12 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (create_path_bar): new function to
consolidate creating the path_bar.
(gtk_file_chooser_default_set_current_folder): no longer need to
pass in the filesystem.
* gtk/gtkpathbar.h: Removed unused set_pixbuf functions in favor
of just setting the filesystem.
* gtk/gtkpathbar.c (gtk_path_bar_finalize): Free root path and
(get_button_image): Add images to path_bar.
(update_button_appearance): use images
(make_directory_button): Clasify buttons based upon location.
(_gtk_path_bar_set_path): no longer need a file-system. Also, add
rerooting, #135845, #135914
* tests/testfilechooser.c: Fix reused error handling.
2004-03-08 Anders Carlsson <>
* gtk/gtkfilesystemunix.c: (get_icon_for_directory),
Use better icons for home and desktop.
2004-03-08 Anders Carlsson <>
* gtk/gtkfilechooserentry.c:
Set the base folder path in the entry.
2004-03-08 Christian Neumair <>
* tests/testentrycompletion.c: Fix typo.
2004-03-08 Tor Lillqvist <>
* README.win32: Update.
* gtk/gtk.def: Small update. Thanks to J. Ali Harlow. Re-sorted.
* tests/testfilechooser.c: Correct localtime_r() emulation on
Win32. Remove a couple of unnecessary Win32-only includes.
Mon Mar 8 01:06:17 2004 Matthias Clasen <>
* tests/testentrycompletion.c: Test dynamic addition/removal.
Sun Mar 7 22:38:49 2004 Matthias Clasen <>
* gtk/gtkframe.c (gtk_frame_paint): Use ythickness, not
xthickness in the calculation of vertical dimensions.
Sun Mar 7 17:38:03 2004 Jonathan Blandford <>
* gtk/gtkbutton.c (gtk_button_class_init): actually use
* gtk/gtkfilechooserdefault.c (error_building_filename_dialog):
use the uri, not the path, #136317
(renderer_edited_cb): ditto
(shortcuts_add_bookmark_from_path): ditto
(remove_bookmark_button_clicked_cb): ditto
(gtk_file_chooser_default_remove_shortcut): ditto
(update_from_entry): ditto
(up_folder_handler): ditto
Sun Mar 7 16:07:08 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): set
redraw_on_allocate, #135902.
* gtk/gtkfilesystemmodel.c (model_refilter_recurse): Patch from
Damon Chaplin to set a node to be visible before emitting the
inserted signal, #135555.
Sun Mar 7 22:24:28 2004 Matthias Clasen <>
* gtk/gtkbutton.c (_gtk_button_paint): Don't use xthickness in the
height calculation.
Sun Mar 7 14:34:04 2004 Jonathan Blandford <>
Fixes #121500.
* gtk/gtkfilechooserdefault.c (trap_activate_cb): stop activate
from unselecting rows when pressed in multiple-selection mode.
2004-03-07 Hans Breuer <>
* gdk/win32/gdkproperty-win32.c (gdk_screen_get_setting) :
some more settings from system, also reflect some name changes
done a while ago in the x11 backend
* gdk/win32/makefile.msc : build gdkspawn-win32.c
* gtk/gtkdnd.c : gtk_drag_source_[gs]et_target_list, added "Since: 2.4"
* gtk/ : build gtkpathbar, link shell32.lib
* tests/makefile.msc : some more tests get build
Sun Mar 7 03:03:57 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_get_paths): if action is
SELECT_FOLDER, then return the currentd folder if none is
(gtk_file_chooser_default_should_respond): Allow 'Ok' to be hit if
no directory is selected in SELECT_FOLDER mode.
Sat Mar 6 23:31:18 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
remove unneeded elements.
(tree_selection_changed): removed
(tree_name_data_func): removed
(gtk_file_chooser_default_finalize): don't unref dir model
(create_folder_tree): removed
(get_selection): no longer need to abstract away the selection
(create_file_list): We now create a tree for all actions.
(file_pane_create): Make one tree.
(update_appearance) We really change the mode only, now.
Sun Mar 7 02:38:00 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_size_request): Do a
size_request on the button and cell_view_frame, otherwise
their style will still be the default here in the initial
size_request. (#136301, Mark McLoughlin)
2004-03-06 Gustavo J. A. M. Carneiro <>
* gtk/gtktoolbar.c (internal_insert_element): Check return value
of gtk_stock_lookup; if stock lookup fails, just use stock_id as
label, instead of crashing. Fixes #136202.
2004-03-05 Federico Mena Quintero <>
* gdk/linux-fb/gdkglobals-fb.c: Make <config.h> the very first
* gdk/linux-fb/gdkwindow-fb.c: Likewise.
* gdk/linux-fb/gdkinput.c: Likewise.
2004-03-05 Federico Mena Quintero <>
Fixes #136082 and #135265, patch by Morten Welinder.
* */*.c: #include <config.h>
2004-03-05 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_select_path): No need to have a
temporary error variable.
2004-03-05 Tor Lillqvist <>
* Move check for native Win32 (mingw) a bit
earlier. If Win32, disable static builds (as in GLib). Remove
unnecessary AC_LIBTOOL_WIN32_DLL.
* gdk/gdk.def: Add missing entries, thanks to J. Ali Harlow.
* gdk/win32/gdkcursor-win32.c (color_is_white): const-correctness.
(gdk_cursor_new_from_pixbuf): Copy of the non-Xcursor X11
gdk_display_supports_cursor_color): Dummy implementations.
gdk_display_get_maximal_cursor_size): Implement.
* gdk/win32/gdkdisplay-win32.c (gdk_display_get_default_group):
Dummy implementation.
* gdk/win32/gdkevents-win32.c (gdk_net_wm_supports): Dummy
* gdk/win32/gdkfont-win32.c (gdk_font_get_display): Implement.
* gdk/win32/gdkinput-win32.c (gdk_input_motion_events): Remove,
not in API.
* gdk/win32/gdkwindow-win32.c (gdk_window_get_group): Dummy
Fri Mar 5 18:00:36 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (new_folder_button_clicked): scroll
to the new path.
* gtk/gtktreeview.c (gtk_tree_view_adjustment_changed): Update the
allocation when scrolling instead of cancelling editing.
Fri Mar 5 23:52:34 2004 Matthias Clasen <>
* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_set_modify_func):
Improve the docs. (#127727, Murray Cumming)
Fri Mar 5 23:37:16 2004 Matthias Clasen <>
* gtk/gtktreeview.c (gtk_tree_view_set_reorderable): Clarify the
doc comment. (#118602)
Fri Mar 5 22:37:15 2004 Matthias Clasen <>
* gtk/gtkbutton.c (gtk_button_construct_child): Don't let
the priv->image pointer dangle. (#136259, Padraig O'Briain)
2004-03-05 Federico Mena Quintero <>
* gtk/gtkfilechooserprivate.h (struct _GtkFileChooserIface): Add
gboolean return values and GError arguments to
::set_current_folder() and ::select_path().
* gtk/gtkfilechooser.c (gtk_file_chooser_set_current_folder):
Return a boolean value for success/failure.
(gtk_file_chooser_set_current_folder_uri): Likewise.
(gtk_file_chooser_select_filename): Likewise.
(gtk_file_chooser_select_uri): Likewise.
(gtk_file_chooser_set_filename): Likewise.
(gtk_file_chooser_set_uri): Likewise.
(_gtk_file_chooser_set_current_folder_path): Likewise, plus take
in a GError.
(_gtk_file_chooser_select_path): Likewise.
* gtk/gtkfilechooserutils.c (delegate_set_current_folder):
(delegate_select_path): Likewise.
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_select_path): Likewise.
(gtk_file_chooser_default_set_current_folder): Likewise; this also
fixes #136024.
(error_changing_folder_dialog): New helper function.
(change_folder_and_display_error): New helper function.
(switch_to_selected_folder): Use change_folder_and_display_error().
(tree_selection_changed): Likewise.
(shortcuts_activate_volume): Likewise.
(shortcuts_activate_item): Likewise.
(list_row_activated): Likewise.
(path_bar_clicked): Likewise.
(update_from_entry): Likewise.
(up_folder_handler): Likewise.
(home_folder_handler): Get the home path from the shortcuts model,
and use change_folder_and_display_error().
* tests/testfilechooser.c (set_current_folder): New helper
function; pops up a simple error dialog if necessary.
(set_filename): Likewise.
(set_folder_nonexistent_cb): Use set_current_folder().
(set_folder_existing_nonexistent_cb): Likewise.
(set_filename_nonexistent_cb): Use set_filename().
(set_filename_existing_nonexistent_cb): Likewise.
Fri Mar 5 11:17:35 2004 Owen Taylor <>
* gtk/gtktreemodel.c (gtk_tree_row_reference_new_proxy):
Improve the docs (reported by Vitaly Tishkov,
#74362) Add some comments to the code about the
row reference handling that are hopefully not entirely
2004-03-05 Michael Natterer <>
* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_show_all):
s/object/widget/. Makes it compile again.
Fri Mar 5 03:37:14 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_show_all):
chain to the extra_widget.
Fri Mar 5 02:53:41 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_finalize):
Patch from Damon Chaplin to free models when we're finalized,
2004-03-05 Alexander Larsson <>
* gtk/gtkfilesystem.c (gtk_file_system_get_volume_for_path):
Document the fact that there might not be a volume for all
* gtk/gtkfilechooserdefault.c (shortcuts_add_current_folder):
Don't assume there is a volume for all paths.
Fri Mar 5 01:45:04 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (shortcuts_append_paths): insert in
the correct place instead of naïvely appending.
(shortcuts_add_volumes): refilter the model
(shortcuts_add_bookmarks): refilter the model
(gtk_file_chooser_default_add_shortcut_folder): refilter the model
2004-03-04 Federico Mena Quintero <>
* gtk/gtkfilechooserdialog.c (response_cb): New handler. Ask the
GtkFileChooser widget if it wants to do something special rather
than letting us terminate the dialog.
(gtk_file_chooser_dialog_init): Connect to "response"; see the
comment in the sources to see why we don't override the method in
* gtk/gtkfilechooserembed.h (struct _GtkFileChooserEmbedIface):
Added a ::should_respond() method.
* gtk/gtkfilechooserembed.c
(_gtk_file_chooser_embed_delegate_iface_init): Add a delegate for ::should_respond().
(delegate_should_respond): New delegate.
(_gtk_file_chooser_embed_should_respond): New function.
* gtk/gtkfilechooserdefault.c (set_list_model, create_file_list):
Use dashes in signal names rather than underscores.
(gtk_file_chooser_default_init): Hook up our ::should_respond() implementation.
(gtk_file_chooser_default_should_respond): Implement. go into a
folder rather than responding if we are in File mode and the
selected file is a folder.
(get_selection): New helper function.
(add_bookmark_button_clicked_cb): Use get_selection().
(bookmarks_check_add_sensitivity): Likewise.
(gtk_file_chooser_default_get_paths): Likewise.
(check_save_entry): New helper function.
(gtk_file_chooser_default_get_paths): Use check_save_entry().
(selection_check): Renamed from selection_is_folders(). Now
checks whether the selection is empty, all files, all folders.
(bookmarks_check_add_sensitivity): Use selection_check().
Fri Mar 5 00:05:59 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_list_setup):
* gtk/gtkcombobox.c (gtk_combo_box_menu_setup): Connect to
key_press_event and handle Alt-Down/Alt-Up to show or hide the
list popup. Also handle Down/Up/PageDown/PageUp/Home/End and
make them change the active item without popping up the list.
These keybindings are inherited from GtkCombo.
Thu Mar 4 23:15:58 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_menu_position): Initially
select the active item when using optionmenu-like positioning.
Thu Mar 4 16:54:30 2004 Owen Taylor <>
* gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Don't
open/close the file, just check for existence
with g_file_test(). This is considerably cheaper,
and lack-of-permissions for pixmap dirs is
Wed Mar 3 17:53:21 2004 Owen Taylor <>
* gtk/gtksocket.c (gtk_socket_class_init): Overide
show_all/hide_all to be gtk_widget_show/gtk_widget_hide,
since we don't want to propagate to the in-process
plug, if any. (#122949, Michael Meeks)
Thu Mar 4 15:20:55 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (update_appearance): show the 'New
Folder' button in SAVE mode again.
Thu Mar 4 21:53:46 2004 Matthias Clasen <>
* gtk/gtkiconfactory.c (copy_cache): Increment the reference
count of the style when copying the cached icon. (#135890, Crispin
Thu Mar 4 21:45:43 2004 Matthias Clasen <>
* gtk/gtkcombobox.c: In list mode, set the background color
of the cell view to the base color of the style, instead of
hardwiring white. (#136158)
Thu Mar 4 01:32:19 2004 Jonathan Blandford <>
* gtk/gtkpathbar.c (gtk_path_bar_set_path): Modified patch from
muppet <> to keep child directories around if we
change to a child.
* gtk/gtkpathbar.c (_gtk_path_bar_set_home_icon): Start of
icon-setting functions. Not used yet.
(_gtk_path_bar_set_root_icon): Ditto.
Thu Mar 4 00:31:54 2004 Matthias Clasen <>
* gtk/gtktextview.c (extend_selection):
* gtk/gtktextview.c (gtk_text_view_move_cursor_internal): Allow
to select the last word in the buffer. (#135487, Paolo Borelli)
Wed Mar 3 23:54:31 2004 Matthias Clasen <>
* gtk/gtkentrycompletion.c: Doc update.
Wed Mar 3 17:30:18 2004 Owen Taylor <>
* gtk/gtkwindow.c (gtk_window_mnemonic_activate): Check
whether widgets are viewable, not just if they are
mapped. (#122912, reported by Tim Evans)
Wed Mar 3 23:28:48 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_set_active): Move the actual
implementation into a new gtk_combo_box_set_active_internal()
function, which doesn't do the short-circuiting.
* gtk/gtkcombobox.c (gtk_combo_box_model_row_deleted): Use
set_active_internal() here, since the active item may change here,
although the index is unchanged.
Wed Mar 3 23:26:49 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_menu_position): Reintroduce the
traditional option menu placement of the popup for regular combo
boxes. Grids and editable combo boxes use the combo-like placement
below the entry. (#136021)
* gtk/gtkcombobox.c (gtk_combo_box_menu_button_press):
* gtk/gtkcombobox.c (gtk_combo_box_popup): Call gtk_menu_set_active()
before popping up the menu, to make the placement work.
Wed Mar 3 17:20:15 2004 Owen Taylor <>
* gtk/gtkmain.c (gtk_propagate_event): Special case
scroll events so that they propagate up the widget
heirarchy when received on insensitive widgets.
(#101102, reported by Geoff Reedy)
Wed Mar 3 16:47:10 2004 Owen Taylor <>
#109594, reported by Olivier Ripoll
* gtk/gtkentry.c (gtk_entry_size_request): Use max of
width and digit width for gtk_entry_set_width_chars,
and round up.
* gtk/gtkcolorsel.c (gtk_color_selection_init): Set the
width of the entry to 7 chars.
Wed Mar 3 16:00:10 2004 Owen Taylor <>
* Strip out the "export-dynamic" libtool
option from library link lines. (#124687, James Henstridge)
Wed Mar 3 16:06:03 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (save_folder_combo_changed_cb):
Don't activate the combo if we're in the midst of changing
2004-03-03 Mark McLoughlin <>
* tests/testsocket_common.c: (print_hello): don't try and store
pointers in ints. Fixes 64-bit build.
2004-03-03 Federico Mena Quintero <>
* gtk/gtkfilesystem.c (gtk_file_system_get_parent): Simplify by
not using a temporary variable, and clarify the documentation.
Fixes #136008.
2004-03-03 Mark McLoughlin <>
* gtk/gtkexpander.c:
(gtk_expander_enter_notify), (gtk_expander_leave_notify),
(gtk_expander_set_label_widget): Set the label widget's
state to prelight if we're prelit. Fixes bug #136078.
2004-03-03 Murray Cumming <>
* gtk/gtkradiobutton.h, radiomenuitem.h: Corrected the group_changed
signal vfunc declaration, adding the first parameter, which is the
widget emitting the signal.
2004-03-03 Morten Welinder <>
* tests/testfilechooser.c (update_preview_cb): Plug leak.
Tue Mar 2 23:39:55 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdialog.c
(file_chooser_widget_default_realized_size_changed): Split
function into realized and unrealized variants, and consolidate
the handling fo size-changing and default changing.
* gtk/gtkfilechooserembed.[ch] (gtk_file_chooser_embed_class_init):
remove resizable-hints-changed, as it just complicated things.
* gtk/gtkfilechooserdefault.c (update_appearance): Don't emit
2004-03-03 Tor Lillqvist <>
* gtk/gtk.def: Add a missing entry. (#135982, J. Ali Harlow)
* NEWS: Correct spelling of my name in one place.
2004-03-02 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_set_current_folder): Handle errors in
setting the path bar's path. Fixes #136000, based on a patch by
Morten Welinder.
* gtk/gtkfilesystemunix.c (gtk_file_system_unix_insert_bookmark):
Don't free our own propagated error.
* gtk/gtkpathbar.c (gtk_path_bar_set_path): Likewise, and free the
parent_path upon error. Fixes #136006, patch by Morten Welinder.
(gtk_path_bar_set_path): Unref the file_folder upon error.
(gtk_path_bar_set_path): Return a boolean success code.
Wed Mar 3 00:28:59 2004 Matthias Clasen <>
* tests/testcombochange.c: Add an animation mode, to test
how the combobox behaves if the model changes while it is popped
Tue Mar 2 17:06:05 2004 Owen Taylor <>
* === Released 2.3.5 ===
* NEWS: Updates
* Version 2.3.5, interface age 0.
Require glib-2.3.5, pango-1.3.5.
Tue Mar 2 23:08:12 2004 Matthias Clasen <>
* gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Avoid
popping up the completions across the edge of the monitor.
Part of #135561.
Tue Mar 2 16:47:40 2004 Owen Taylor <>
* tests/testfilechooser.c (set_filename_existing_nonexistent_cb):
Move the /nonexistant stuff out of the main window,
keep the main window somewhat normal looking.
Tue Mar 2 16:18:43 2004 Owen Taylor <>
* gtk/gtktreestore.c (gtk_tree_store_reorder)
* gtk/gtkliststore.c (gtk_list_store_reorder): Fix
up the interpretation of new_order to match what
it means elsewhere, document the meaning of new_order.
* gtk/gtkcombobox.c (gtk_combo_box_model_rows_reordered):
Fix interpretation of new_order.
* tests/testcombochange.c (on_reorder): Fix interpretation
of new_order.
* tests/testcombochange.c (on_reorder): Fix hitting
"reorder" with an empty list.
Tue Mar 2 21:23:30 2004 Soeren Sandmann <>
Patch from Frederic Crozat, test code from Jean-Philippe
Chancelier. Fixes bug #120479.
* gtk/gtkcombo.c (gtk_combo_popup_list): Make sure popup belongs
to the right window group.
* gtk/gtkmenu.c (gtk_menu_popup): Same
* tests/testsocket.c (main): Pack the plugs into an hbox instead
of a vbox.
* tests/testsocket_common.c: Add a GtkMenuBar, a GtkCombo and a
GtkComboBox to the children.
Tue Mar 2 14:38:23 2004 Owen Taylor <>
* gtk/gtkcombobox.c (gtk_combo_box_model_row_inserted):
If the model was empty before, select the first inserted
* gtk/gtkcombobox.c (gtk_combo_box_model_row_deleted):
Fix up the logic for the new row to select.
* gtk/gtkcombobox.c (gtk_combo_box_class_init):
Rename "appearance" property to "appears-as-list".
* tests/testcombochange.c tests/ Test case
for combos and dynamically changing models.
Tue Mar 2 15:19:52 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_get_resizable_hints): set the default
value, spotted by Morten Welinder.
Tue Mar 2 15:03:15 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_get_resizable_hints): get the logic
correct. This will fix sizing on save dialogs.
(save_widgets_create): set_mnemonic_widget.
2004-03-02 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_set_current_folder): Don't update the
save folder combo if we are already switching folders; based on a
patch by Jonathan Blandford.
* gtk/gtkfilechooserdefault.c (shortcuts_add_current_folder):
Handle failure to insert the path. Based on a patch by Morten
Welinder attached to bug #135380.
* tests/testfilechooser.c (extra_widget_create): Add a bunch of
buttons to test various things.
Tue Mar 2 20:59:23 2004 Matthias Clasen <>
* tests/ Add testentrycompletion.
* tests/testentrycompletion.c: New file to test some of the
more exotic GtkEntryCompletion features.
Tue Mar 2 14:38:10 2004 Jonathan Blandford <>
* tests/testfilechooser.c (main): improve tests a little.
Tue Mar 2 11:45:50 2004 Owen Taylor <>
* gtk/gtkcombobox.c: Always connect to the changed
signals on the model, update the active item as
appropriate when rows are inserted/deleted/reordered,
re-layout the menu on ::rows-reordered.
* gtk/gtkcellview.c (gtk_cell_view_set_displayed_row):
Allow %NULL for path to unset and leave no current
Tue Mar 2 19:54:53 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_list_position): Position
the popup above the sample if there is not enough room below.
Part of #135543.
Tue Mar 2 19:53:36 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget): Make the
frame for the list mode etched in, to give the popup a slightly
less flat appearance.
Tue Mar 2 17:55:31 2004 Matthias Clasen <>
* gtk/gtk.def: Add gtk_combo_box_entry_new_text().
2004-03-02 Morten Welinder <>
* tests/testfilechooser.c (size_prepared_cb): Don't scale images
that are small enough to fit. Avoid using incompatibly typed data
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_get_resizable_hints): Test the
resize_horizontally pointer, not the deferenced pointer.
2004-03-01 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): New
flag shortcuts_current_folder_is_volume.
(shortcuts_add_current_folder): Set
impl->shortcuts_current_folder_is_volume as appropriate.
(remove_current_folder_cb): Handle the flag.
(shortcuts_activate_item): Likewise.
(shortcuts_update_current_folder): Handle the
impl->shortcuts_current_folder_active flag; only add the folder if
it doesn't already exist in the list.
(shortcuts_model_create): Don't insert the current folder
separator here.
(shortcuts_add_current_folder): Insert the separator here.
(shortcut_find_position): Renamed from shortcut_exists(); now
returns an index.
(shortcuts_add_current_folder): Set the active item in the combo.
2004-03-01 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (shortcuts_row_activated_cb): Eep,
use gtk_tree_model_filter_convert_iter_to_child_iter(), not the reverse.
2004-03-01 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (shortcuts_model_create): Don't
unref an old model; there isn't one. This was a leftover from
when we recreated the model on every change.
(save_widgets_create): Create the save folder combo.
(shortcuts_model_create): Don't set the model on the tree view
(gtk_file_chooser_default_constructor): Create the shortcuts model
here, before the rest of the widgets.
(shortcuts_list_create): Don't call shortcuts_model_create() here;
just set the model on the tree.
(save_folder_combo_create): New function, provided by Jonathan
(update_appearance): Set the sensitivity of the folder combo.
(shortcuts_activate_iter): New helper function; code moved from
(shortcuts_activate_item): New helper function.
(shortcuts_row_activated_cb): Use shortcuts_activate_iter().
(ShortcutsIndex): Renamed SHORTCUTS_SEPARATOR to
(struct _GtkFileChooserDefault): New field shortcuts_current_folder_active.
(shortcuts_insert_separator): Add a position argument.
(shortcuts_get_index): Handle the SHORTCUTS_CURRENT_FOLDER_SEPARATOR
(shortcut_exists): Ignore the current folder row.
(struct _GtkFileChooserDefault): New field shortcuts_filter_model.
(shortcuts_model_create): Create a filter model for the shortcuts list.
(shortcuts_list_create): Set the model to the shortcuts_filter_model.
(remove_bookmark_button_clicked_cb): Use the shortcuts_filter_model.
(bookmarks_check_remove_sensitivity): Likewise.
(shortcuts_row_activated_cb): Likewise.
(gtk_file_chooser_default_set_current_folder): New function.
(gtk_file_chooser_default_set_current_folder): Update the current
folder row in the shortcuts list.
* gtk/gtkfilechooserwidget.c
(gtk_file_chooser_widget_constructor): Cast correctly for
Mon Mar 1 19:30:25 2004 Owen Taylor <>
* gtk/gtkdnd.[ch]: Add gtk_drag_source_set/get_target_list().
(#127499, based on patch from Michael Natterer)
* tests/testgtk.c: Fix bidi strings to display correctly
with new auto-bidi.
Tue Mar 2 01:34:40 2004 Matthias Clasen <>
* gtk/gtksettings.c: Remove the include of Xft.h, which is already
dragged in via pangoxft.h. (#135496, David Hawthorne)
Mon Mar 1 23:52:15 2004 Tim Janik <>
* gtk/gtkbindings.[hc]: expose gtk_bindings_activate_event(), changed
* gtk/gtkwindow.[hc]: added gtk_window_propagate_key_event() to expose
the key event propagation mechanism used for focus widgets.
(gtk_window_key_release_event): use the same key event propagation logic
as gtk_window_key_press_event().
2004-03-01 Simon Budig <>
* gdk/x11/gdkinput-x11.c: X11 R6.4 specifies 15 events
for the XInput extension. We want to see them all.
We now get Proximity Out events again. Fixes bug #135320.
Tue Mar 2 00:47:21 2004 Matthias Clasen <>
* gtk/gtkimmodule.c (match_locale): Use case-insensitive
comparison. Fixes XIM module loading on AIX. (#131277)
Mon Mar 1 23:59:18 2004 Matthias Clasen <>
* gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_deleted):
Make it work correctly when the child model is cleared
completely. (#121633)
2004-03-01 Michael Natterer <>
* gtk/gtkfilechooserwidget.h: removed accidentially committed char
which broke the build.
Mon Mar 1 16:51:21 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdialog.c
(file_chooser_widget_default_size_changed): only store the size if
we can resize in that direction.
Mon Mar 1 16:32:52 2004 Jonathan Blandford <>
* gtk/gtkfilechooserwidget.c
(gtk_file_chooser_widget_new_with_backend): new function. Long
2004-03-01 Morten Welinder <>
* gtk/gtkfilesystemunix.c (filename_get_info): Only stat when
* gtk/gtkfilesystemmodel.c (file_model_node_is_visible): Simplify
semantics and check for errors.
* gtk/gtkpathbar.c (gtk_path_bar_set_path): Propagate errors.
* gtk/gtkfilefilter.c (gtk_file_filter_filter): Don't crash if
display_name is NULL.
Mon Mar 1 14:16:52 2004 Owen Taylor <>
Based on patch by Alex Larsson
* gtk/gtkfilechooserdefault.c: Use gtk-file-chooser-backend
GtkSetting to set the backend if the app doesn't specify one.
* gdk/x11/gdkevents-x11.c gtk/gtksettings.c:
Add Gtk/FileChooserBackend.
Mon Mar 1 20:32:06 2004 Tim Janik <>
- exit with $? instead of 1 in case of failure
- exit with $? if ./configure failed
(that's so && make lines work)
- removed --enable-gtk-doc option
2004-03-01 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (list_model_filter_func): Test for
filter_info.uri correctly. Fixes #135379, pointed out by Damon
(shortcuts_get_index): Compute the bookmarks index correctly.
Fixes #135714, pointed out by Damon Chaplin.
(gtk_file_chooser_default_list_shortcut_folders): Handle the case
with no shortcuts, and don't run off the end of the list if there
are no bookmarks and their separator. Fixes #135572, patch by
Damon Chaplin.
Mon Mar 1 12:23:06 2004 Owen Taylor <>
* gtk/gtklabel.c: Handle dynamically resolved bidi direction
when drawing the cursor. (#118541)
* gtk/gtkentry.c (get_better_cursor_x): Use entry->resolved_dir;
* gtk/gtkentry.c (draw_insertion_cursor): Fix up
some confusion in parameter ordering.
Mon Mar 1 12:05:54 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdialog.c
(file_chooser_widget_resizable_hints_changed): Handle
2004-03-01 Michael Natterer <>
* gtk/gtktextbtree.c: removed underscores from calls to
Mon Mar 1 10:41:27 2004 Owen Taylor <>
Patch from Dov Grobgeld to implement auto-bidi-direction
for GtkTextView (#118543)
* gtk/gtktextbtree.[ch]: Resolve bidi base direction
for each line by propagating backwards/forwards as
* gtk/gtktextlayout.[ch] gtk/gtktextview.c: Set the
bidi base direction for the ;ine with the cursor from
the keyboard direction. Add gtk_text_layout_set_keyboard_direction().
Mon Mar 1 10:31:11 2004 Owen Taylor <>
* gtk/gtkentry.[ch]: Implement auto-bidi-direction,
based on a patch from Dov Grobgeld. (#118540)
Sun Feb 29 22:01:49 2004 Owen Taylor <>
* gtk/gtkentry.[ch]: Add gtk_entry_set_alignment()
to allow right-aligned entries and a "xalign"
property. (#59799, patch from Egon Andersen and
Steffen Gutmann)
* gtk/gtkmisc.c (gtk_misc_class_init): Use improved
xalign property description here too.
* tests/testtext.c: UNDERLINE_ERROR test addition
from Nicolas Settons' patch.
Sun Feb 29 20:34:06 2004 Owen Taylor <>
* gtk/gtkwindow.[ch] gtk/gtkmenushell.c: export
gtk_window_activate_key() (Request from Tim Janik)
Mon Mar 1 01:00:11 2004 Matthias Clasen <>
* gtk/gtktextview.c (gtk_text_view_drag_data_received):
Make DND operations within a buffer move the dragged
text instead of copying it; also make DND operations
a single user action for undo purposes. (#135191,
#93139, reported by Tommi Komulainen, patch by Paolo Borelli
and Paolo Maggi)
Mon Mar 1 00:51:11 2004 Matthias Clasen <>
* NEWS: News for 2.3.5.
Sun Feb 29 23:25:35 2004 Matthias Clasen <>
* gtk/gtkentry.c (gtk_entry_completion_key_press):
Fix the Shift-Tab support to go backwards.
Sun Feb 29 16:40:40 2004 Owen Taylor <>
* gtk/gtktextview.c (gtk_text_view_class_init): Fix
capitalization to match other style properties.
Sun Feb 29 16:38:53 2004 Owen Taylor <>
* gtk/gtktextview.c (gtk_text_view_class_init): Fix a
typo in property string.
Sun Feb 29 16:35:23 2004 Owen Taylor <>
* gdk/gdkpango.c gtk/gtktextdisplay.c: Implement
PANGO_UNDERLINE_ERROR (Based on a patch by
Nicolas Setton, #114237)
* gtk/gtktextview.c: Add a error-underline-color style
Sun Feb 29 19:04:33 2004 Soeren Sandmann <>
* gtk/gtkrange.c (_gtk_range_get_wheel_delta): New internal
function returning a good step value for the mouse wheel. For
scrollbars, base the step on page_size^(2/3), for other ranges,
use 2 * step_increment.
* gtk/gtkrange.c (gtk_range_scroll_event): Use it here ...
* gtk/gtkscrolledwindow.c (gtk_scrolled_window_scroll_event):
... and here.
* gtk/gtkmenu.c (gtk_menu_leave_notify): Fix a warning.
Sun Feb 29 01:51:27 2004 Jonathan Blandford <>
* gtk/gtkfilechooserembed.c
(_gtk_file_chooser_embed_get_default_size): Add g_return_if_fail()
(_gtk_file_chooser_embed_get_resizable_hints): Add g_return_if_fail()
* gtk/gtkfilechooserdialog.c
(file_chooser_widget_default_size_changed): Get the correct
initial size for the dialog. Also, don't bother with
gtk_window_set_default_size(). It's not really meaningful.
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_get_default_size): Get the correct
spacing for the preview_widget
(update_preview_widget_visibility): Clear widget field after we
destroy it.
2004-02-29 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_set_property): Handle
(gtk_file_chooser_default_get_property): Likewise.
(struct _GtkFileChooserDefault): Added fields for preview_label,
use_preview_label, preview_display_name, preview_box. Removed
(set_preview_widget): Reorder the widget in relation to the label.
(update_preview_widget_visibility): Create or destroy the preview
(check_preview_change): Update impl->preview_display_name and the
(find_good_size_from_style): Use the preview_box.
(gtk_file_chooser_default_finalize): Free
(gtk_file_chooser_default_init): Initialize
* gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add a
"use-preview-label" property.
(gtk_file_chooser_set_use_preview_label): New function. This sets
whether one wants the file chooser to display a stock label with
the previewed filename. Apps that do really fancy previews can
turn this off and draw the name themselves.
(gtk_file_chooser_get_use_preview_label): New function.
(gtk_file_chooser_get_preview_widget_active): Documentation fix.
* gtk/gtkfilechooserutils.h (GtkFileChooserProp): Add a
* gtk/gtkfilechooserutils.c
(_gtk_file_chooser_install_properties): Override the
"use-preview-label" property.
Sun Feb 29 04:43:29 2004 Matthias Clasen <>
* gtk/gtkentry.c (gtk_entry_completion_key_press): Make Tab and
Shift-Tab work when the completion popup is shown.
2004-02-28 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (create_folder_tree): Use "Name" for
the title of the filename column.
(create_file_list): Likewise.
Sun Feb 29 03:31:42 2004 Matthias Clasen <>
* gtk/gtkentry.c (gtk_entry_completion_key_press): Fix Page_Up
and Page_Down in the completion popup to move page-wise if we're
2004-02-28 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (set_cell_text_bold_if_folder):
(list_name_data_func): Don't call the function above.
(list_mtime_data_func): Likewise.
Sun Feb 29 02:34:35 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_list_position): New
function which calculates position and size for the popup in
list mode. Currently it only pushes the popup horizontally
into the screen.
Sun Feb 29 01:10:09 2004 Matthias Clasen <>
* gtk/gtkcombobox.c: Implement the previous fix in a better way,
small cleanups.
2004-02-28 Hans Breuer <>
* gtk/gtkfilesystemwin32.c : applied patch from
J. Ali Harlow <>, fixes bug #135641
Sat Feb 28 23:30:36 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_popup): Actually resize the
popup window before popping up. (#135651)
Sat Feb 28 23:29:35 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_class_init):
* gtk/gtkcombobox.c (gtk_combo_box_init): Override the default
handler for style_set in class_init instead of connecting to
the signal in init. (noticed by Yosh).
Sat Feb 28 14:48:35 2004 Owen Taylor <>
* demos/gtk-demo/main.c (read_line): #ifdef HAVE_FLOCKFILE,
not #ifndef HAVE_FLOCKFILE. (#135642, J. Ali Harlow)
2004-02-28 Hans Breuer <>
* gtk/gtkfilesystemwin32.c : adapt to add -> insert_bookmark
change. Also merged some crossplatform code from
* gtk/gtk.def : updated externals
* gtk/ : added gtkfilechooserembed.obj
2004-02-28 Hans Breuer <>
* gdk/win32/gdkdnd-win32.c : set current_dest_drag to NULL
when destroying, fixes bug #120007. Also removed the mirrored
ref counting for deprecated gdk_drag_context_<ref|unref>()
cause it wasn't reliable anymore anyway.
* gdk/win32/gdkdisplay-win32.c : fix typo, which should
have broken the win32 build for everyone not using msvc
* gdk/win32/gdkevents-win32.c : WM_GETMINAMXINFO ensure not to
return negative values for ptMaxTrackSize, it caused snapping
windows to their minimum size
Sat Feb 28 01:39:01 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_set_wrap_width): Support
switching back to non-gridded mode. (#135169)
Fri Feb 27 22:29:46 2004 Matthias Clasen <>
* gtk/gtkwidget.c (gtk_widget_can_activate_accel): Add "Since: 2.4".
Fri Feb 27 18:52:19 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdialog.c (gtk_file_chooser_dialog_style_set):
Whoops. Didn't mean to commit the size change.
Fri Feb 27 18:46:27 2004 Jonathan Blandford <>
* gtk/gtkfilechooserembed.h: New private interface to help
negotiate the default size of the widget. Still a bit buggy, but
better than the old behavior.
* gtk/gtkfilechooserdefault.c: Implement the embed interface.
* gtk/gtkfilechooserwidget.c: Proxy the embed interface.
* gtk/gtkfilechooserdialog.c: Use the embed interface.
2004-02-27 Federico Mena Quintero <>
* gtk/gtkfilesystem.c (gtk_file_system_insert_bookmark): Added a
"position" argument.
* gtk/gtkfilesystem.h (GtkFileSystemError): Added value for
(struct _GtkFileSystemIface): Added a "position" argument to the
::insert_bookmark() method.
* gtk/gtkfilesystemunix.c (gtk_file_system_unix_insert_bookmark):
Updated; renamed from gtk_file_system_unix_add_bookmark(). Return
an error if the path already exists in the bookmarks list.
(gtk_file_system_unix_remove_bookmark): Return an error if the
path does not exist in the bookmarks list.
* gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
For now, use gtk_file_system_insert_bookmark() with -1 for the
position. DnD will come next.
Fri Feb 27 21:42:28 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_relayout):
* gtk/gtkcombobox.c (gtk_combo_box_style_set): Simplify, only
create a new setup if appearance actually changed.
* gtk/gtkcombobox.c (gtk_combo_box_cell_layout_clear):
* gtk/gtkcombobox.c (gtk_combo_box_get_cell_info): Make
these more robust. (#127623, Damon Chaplin)
Fri Feb 27 15:06:00 2004 Jonathan Blandford <>
* gtk/gtkfilechooser.c (gtk_file_chooser_class_init): remove
folder-mode property.
* gtk/gtkfilechooserutils.c
(_gtk_file_chooser_install_properties): remove FOLDER_MODE property.
Thu Feb 26 17:38:40 2004 Manish Singh <>
* gtk/gtkcombobox.c: Add function declaration for
Fri Feb 27 02:33:21 2004 Matthias Clasen <>
* gtk/gtkentry.c (keyval_is_cursor_move): Classifiy Page Up/Down as
cursor move, but not Home and End.
* gtk/gtkentry.c (gtk_entry_completion_key_press): Lets Page Up/Down
jump to the ends of the list, not Home and End - since we're not
scrolling yet, a "page" is always the complete list. (#127430, Marco
Pesenti Gritti)
Fri Feb 27 00:39:11 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_list_destroy):
* gtk/gtkcombobox.c (gtk_combo_box_menu_destroy): Don't let
the priv pointers dangle. (#127623, Damon Chaplin)
Thu Feb 26 17:31:34 2004 Manish Singh <>
* gdk/x11/xsettings-client.c (read_settings): fix ytpo: s/eles/else/
Thu Feb 26 19:53:32 2004 Owen Taylor <>
* gdk/x11/xsettings-common.h (xsettings_client_process_event):
Add xsettings_client_set_grab_func,
Add xsettings_client_set_ungrab_func to the list of renames.
Thu Feb 26 19:48:39 2004 Owen Taylor <>
* gdk/x11/xsettings-client.c (read_settings): Fix memory leak
in case of mismatched property type.
Thu Feb 26 18:25:57 2004 Jonathan Blandford <>
* gtk/gtkfilechooser.h (GtkFileChooserAction): Add two more folder
modes to the enum.
* gtk/gtkfilechooser.c (gtk_file_chooser_set_folder_mode): Remove.
(gtk_file_chooser_get_folder_mode): Remove
Thu Feb 26 17:29:04 2004 Owen Taylor <>
* gdk/x11/gdkevents-x11.c (gdk_wm_protocols_filter): Return
GDK_FILTER_CONTINUE for unhandled message types.
* gdk/x11/gdkevents-x11.c (gdk_event_translate): Allow
multiple filters for the same event type with the standard
"GDK_FILTER_CONTINUE == pretend I wasn't here" semantics.
* gdk/x11/gdkevents-x11.c (gdk_display_add_client_message_filter):
Append to the filter list not prepend, since order now matters.
* gdk/win32/gdkevents-win32.c (gdk_add_client_message_filter):
Append to the filter list not prepend, since order now matters.
Thu Feb 26 23:39:07 2004 Matthias Clasen <>
Fixes for #135333, analysed by Damon Chaplin:
* gtk/gtkcombobox.c (gtk_combo_box_list_button_pressed): Don't
grab here.
* gtk/gtkcombobox.c (gtk_combo_box_popup): Do the grabs here,
so that we don't forget to grab when the menu is popped via
* gtk/gtkcombobox.c (gtk_combo_box_list_button_released): Don't
ungrab here.
* gtk/gtkcombobox.c (gtk_combo_box_popdown): Do the ungrabs here.
Thu Feb 26 23:26:00 2004 Soeren Sandmann <>
* gtk/gtkstatusbar.c (set_grip_cursor): New function. Use resize
cursors for resize grips. (Bug #129621)
* gtk/gtktoolbar.c (gtk_toolbar_get_relief_style): Documentation
fix - patch by Torsten Schoenfeld.
* gtk/gtkmenubar.c (gtk_menu_bar_size_request): don't request
space between the items. (Bug #110775)
* gtk/gtkrc.c (_gtk_rc_init): Provide extra horizontal padding
inside menu items that are inside a menu bar. (Bug #110775)
* (HAVE_XCURSOR): Make XCurosr part of GDK_EXTRA_,
not GDK_PACKAGES, to prevent applications from getting linked to
it (Bug #119804)
* gtk/gtkmenubar.c (gtk_menu_bar_size_allocate): Put the vertical
ipadding inside the item. (Bug #61843)
Thu Feb 26 22:56:40 2004 Matthias Clasen <>
* gtk/gtkwidget.c: Replace gtk_widget_get_mnemonic_widgets()
by list_mnemonic_widgets() in doc comments as well.
Thu Feb 26 16:36:38 2004 Owen Taylor <>
Fixes from Torsten Schoenfeld.
* gtk/gtkwidget.c (gtk_widget_add_mnemonic_label):
Fix name in doc comment.
* gtk/gtkwidget.h: gtk_widget_list_mnemonic_labels(),
not get_mnemonic_labels.
Thu Feb 26 22:20:44 2004 Matthias Clasen <>
* gtk/gtkcomboboxentry.h:
* gtk/gtkcomboboxentry.c (gtk_combo_box_entry_new_text): New
convenience API to construct simple text combos, implemented by
Damon Chaplin.
* tests/testcombo.c: Use gtk_combo_box_entry_new_text.
Thu Feb 26 22:19:29 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_new_text): Improve the docs.
Thu Feb 26 15:43:43 2004 Owen Taylor <>
* gtk/gtkstyle.[ch]: Export insertion cursor drawing functionality
in a simplified form as gtk_draw_insertion_cursor().
(#99031, request from Alex Larsson)
* gtk/gtktextdisplay.c gtk/gtkentry.c gtk/gtklabel.c:
Adapt to new gtk_draw_insertion_cursor().
* gtk/gtkradiomenuitem.c (gtk_radio_menu_item_class_init)
gtk/gtkstyle.c (gtk_style_class_init): Add some missed
Since: 2.4.
* gtk/gtkiconfactory.c (icon_size_settings_changed)
gtk/gtkicontheme.c (do_theme_change)
gtk/gtkrc.c (_gtk_rc_context_get_default_font_name)
* gtk/gtksettings.c (gtk_settings_notify):
_gtk_rc_reset_styles => gtk_rc_reset_styles.
Thu Feb 26 21:52:58 2004 Matthias Clasen <>
Fixes for #127804 and #134722, Damon Chaplin:
* gtk/gtkcombobox.c (gtk_combo_box_cell_layout_pack_end):
* gtk/gtkcombobox.c (gtk_combo_box_cell_layout_pack_start):
Ref and sink the cell renderers here.
* gtk/gtkcombobox.c (gtk_combo_box_finalize): Unref the cell
renderers here, and free attributes and func_data.
Thu Feb 26 21:41:38 2004 Matthias Clasen <>
* gtk/gtkrc.c (gtk_rc_reset_styles): Mark as 2.4 API addition.
Thu Feb 26 14:47:22 2004 Dom Lachowicz <>
* gtk/gtk.def: Export gtk_rc_reset_styles()
Thu Feb 26 14:47:22 2004 Owen Taylor <>
* gtk/gtkrc.[ch]: Export gtk_rc_reset_styles().
(Request from Dom Lachowicz, #123769)
Wed Feb 25 19:11:31 2004 Owen Taylor <>
* gtk/gtkradiobutton.[ch] gtk/gtkradiomenuitem.[ch]: Add a
::group-changed signal emitted when the radio button/menu item
is moved from one group of radio buttons to another.
(#79563, based partially on a patch from Padraig O'Briain)
Thu Feb 26 13:23:47 2004 Owen Taylor <>
* gdk/x11/gdkwindow-x11.c (set_text_property): Use the right
free() function. (#135511, George Bronnikov)
2004-02-26 Federico Mena Quintero <>
* Added a comment to inform translators that they
must add .po files to both po/ and po-properties/ when they add
new languages to ALL_LINGUAS.
Wed Feb 25 15:36:50 2004 Owen Taylor <>
* gdk/x11/gdkselection-x11.c (gdk_utf8_to_compound_text_for_display):
Call g_convert(), not g_convert() with fallback, since Emacs is
happier if we reject the COMPOUND_TEXT request and it can
then ask for UTF-8. (#114527)
* gtk/gtkselection.c (gtk_selection_data_set_text): When
TEXT is requested, if COMPOUND_TEXT fails, fall back to STRING.
Wed Feb 25 22:35:00 2004 Tomasz Kłoczko <>
* After changes in G_DEFINE_TYPE minimal required glib
vesion for build gtk+ is now 2.3.3.
Wed Feb 25 16:00:40 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (update_appearance): move the
expander code.
2004-02-25 Danilo Šegan <>
* (ALL_LINGUAS): po-properties/sr@ije.po added, so
adding back sr@ije.
2004-02-25 Federico Mena Quintero <>
* (ALL_LINGUAS): Remove sr@ije until po-properties/
is fixed for it.
Wed Feb 25 12:44:49 2004 Owen Taylor <>
* gtk/gtkstyle.[ch]: Make realize and unrealize signals. (#73310)
Wed Feb 25 12:21:32 2004 Owen Taylor <>
* gtk/gtkwidget.[ch] gtk/gtklabel.c: Patch from
Padraig O'Briain to add gtk_widget_add/remove_mnemonic_label,
gtk_widget_get_mnemonic_labels(). (#103456)
2004-02-25 Danilo Šegan <>
* Added sr@ije to ALL_LINGUAS.
Wed Feb 25 09:46:34 2004 Owen Taylor <>
* gtk/gtkstyle.c (gtk_style_finalize): Free
style->icon_factories (#130128)
Wed Feb 25 03:52:58 2004 Jonathan Blandford <>
* gtk/gtkpathbar.c: use gtk_widget_push/pop_composite_child around
internal buttons.
* gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
rename some widgets to make it clear where they are packed.
(update_appearance): New function to handle all the 'logic' of
layout in one place. We aren't trying to keep all our properties
in sync.
(gtk_file_chooser_default_set_property): use update_appearance()
2004-02-24 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (shortcuts_model_create): Renamed
from create_shortcuts_model().
(struct _GtkFileChooserDefault): Renamed the shortcuts_tree field
to shortcuts_list.
(shortcuts_list_create): Renamed from shortcuts_tree_create().
(create_file_list): Enable the tree view as a model drag source.
(create_folder_tree): Likewise.
* gtk/gtkfilesystemmodel.c (_gtk_file_system_model_get_type):
Register the drag source interface.
(drag_source_iface_init): New function.
(drag_source_row_draggable): New function.
(drag_source_drag_data_get): New function.
Tue Feb 24 19:12:07 2004 Owen Taylor <>
* === Released 2.3.4 ===
* Bump version to 2.3.4, fix broken
gtk_binary_age value by copying the GLib logic
to automatically set it to the right values.
Wed Feb 25 00:13:24 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_menu_row_changed):
* gtk/gtkcombobox.c (gtk_combo_box_list_row_changed):
Don't resize priv->cell_view if it is NULL. (#127804,
Damon Chaplin)
Wed Feb 25 00:06:50 2004 Matthias Clasen <>
* gtk/gtkcombobox.c: Add a comment about the different
modi of this widget. Get rid of priv->hbox, and some other
cleanups. Make sure that gtk_combo_box_unset_model() is
always called before setting up a different mode.
Tue Feb 24 17:51:49 2004 Owen Taylor <>
* gtk/gtkaccellabel.c (gtk_accel_label_refetch): Convert
underscores in keyval names to spaces. (#131480)
Tue Feb 24 17:35:59 2004 Owen Taylor <>
* m4macros/gtk-2.0.m4: Add some quotes around ***. (#130073,
Uwe Zeisberger)
Tue Feb 24 14:45:03 2004 Owen Taylor <>
* === Released 2.3.3 ===
* Version 2.3.3, interface age 0.
* NEWS: Finish updates for 2.3.3.
2004-02-24 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (save_widgets_create): Use a plain
GtkEntry for the filename, not a GtkFileChooserEntry.
(update_chooser_entry): Use gtk_entry_set_text() rather than
(gtk_file_chooser_default_set_current_name): Likewise.
(gtk_file_chooser_default_set_current_folder): Don't set the base
folder of the entry, and don't call update_chooser_entry().
(gtk_file_chooser_default_get_paths): Use the plain entry.
(save_widgets_create): Store the "Save in Folder" label in the
impl structure.
(expander_activate_cb): Set the sensitivity of the label and
(save_widgets_create): Connect to "notify::expanded" rather than
"activate" on the expander.
(expander_changed_cb): Renamed from expander_activate_cb(). Flip
the conditions again...
Tue Feb 24 14:43:07 2004 Jonathan Blandford <>
* gtk/gtktreeview.c (gtk_tree_view_bin_expose): only draw the sort
column as different if there are 3 or more visible columns.
2004-02-24 Anders Carlsson <>
* gtk/gtkfilechooserdefault.c: (shortcuts_insert_separator):
Fix compilation (#135278, Padraig O'Briain).
2004-02-24 Anders Carlsson <>
* gtk/gtkfilechooserdefault.c: (shortcuts_append_desktop):
Translate the desktop label.
(shortcuts_get_index), (shortcuts_add_bookmarks),
(shortcuts_insert_separator), (create_shortcuts_model):
Don't show the bookmark separator if there are no bookmarks.
Tue Feb 24 01:41:30 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (location_popup_handler): Make the
dialog look like the nautilus dialog.
(expander_activate_cb): get the order correct.
2004-02-23 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (list_selection_changed): Call
(shortcut_exists): New helper function; moved the testing code
over from bookmarks_check_add_sensitivity().
(bookmarks_check_add_sensitivity): Check the contents of the
selection in the file/folder list. Use shortcut_exists().
(shortcuts_add_bookmark_from_path): Don't insert the bookmark if
the path is already in the shortcuts list.
(add_bookmark_button_clicked_cb): Add the bookmarks from the list
selection or from the current folder, as appropriate.
Mon Feb 23 21:09:06 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (shortcuts_pane_create): Add
mnemonics. Sorry translators.
Tue Feb 24 02:24:58 2004 Matthias Clasen <>
* NEWS: Additions. This should be complete for the main ChangeLog
now, still need to sift through gdk-pixbuf, docs, and translations.
Mon Feb 23 19:57:45 2004 Jonathan Blandford <>
* gtk/gtkcellrendererseptext.c (gtk_cell_renderer_sep_get_size):
Add a get_size implementation so that we are no longer the same
height as text.
2004-02-24 Anders Carlsson <>
* gtk/gtkfilechooserdefault.c: (shortcuts_insert_path),
(shortcuts_remove_rows), (shortcuts_append_bookmarks),
(create_shortcuts_model), (shortcuts_tree_create),
Improve bookmark list rendering by controlling the visibility
of the pixbuf cell so that it will be invisible for the separator
row, also use a list store instead of a tree store for the model
so we won't get unnecessary space for an expander.
Tue Feb 24 01:08:27 2004 Matthias Clasen <>
* gtk/gtkcombobox.c: Add a destroy implementation in order to
set priv->cell_view to NULL before finalize stumbles over the
dangling pointer. This big array of pointers into the widget
tree in GtkComboBoxPrivate is really fragile and should be
cleaned up.
Mon Feb 23 17:52:43 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (main_paned_create): use a size
group when allocating space for the buttons at the bottom just in
case. Also, move the filter to below the file list.
Mon Feb 23 16:52:12 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_class_init): Seth was confused by
keybindings. They should be Alt, not Ctl. Also, A-Home should go
home, not up.
Mon Feb 23 15:23:23 2004 Jonathan Blandford <>
* gtk/gtkpathbar.c (gtk_path_bar_set_path): Display the root a bit
more cleanly.
* gtk/gtkpathbar.h (struct _GtkPathBarClass): fix the signal.
2004-02-23 Federico Mena Quintero <>
Rework the user interface of the file chooser, as per
Seth Nickell's design.
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_class_init): Add binding signals and bindings:
"location-popup" - C-l
"up-folder" - C-Up
"home-folder" - C-Home
(up_folder_handler): New function; moved the code from up_button_clicked().
(up_button_clicked_cb): Call up_folder_handler().
(home_folder_handler): New function.
(location_popup_handler): New function.
(struct _GtkFileChooserDefault): Add an hpaned field.
(gtk_file_chooser_default_set_current_name): Check that we are in
Save mode.
(save_widgets_create): New function, create the widgets specific
to Save mode.
(main_paned_create): New function, create the hpaned's widgets here.
(gtk_file_chooser_default_constructor): Create the open and save
widgets, and show only one set.
(gtk_file_chooser_default_set_property): Show/hide the save widgets.
(gtk_file_chooser_default_get_paths): Only pay attention to the
entry in Save mode.
(update_chooser_entry): Update the entry only in Save mode.
(entry_activate): Removed.
Mon Feb 23 11:20:34 2004 Owen Taylor <>
* Remove the check for fontconfig
entirely; it's not needed, since PangoXft implies that sufficiently
new fontconfig is present.
Mon Feb 23 02:26:53 2004 Jonathan Blandford <>
* gtk/gtkpathbar.c (gtk_path_bar_finalize):
for (i = 0; i < 10; i++)
g_print ("I will compile before committing.\n");
Mon Feb 23 02:08:42 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (file_pane_create): Use the
GtkPathBar by default now.
* gtk/gtkpathbar.c (gtk_path_bar_set_path): Correctly set the
current path from the path.
(gtk_path_bar_class_init): new signal
(button_clicked_cb): emit the signal when we're selected.
(gtk_path_bar_clear_buttons): Fix a crasher when we weren't
clearing thr first_scrolled_button.
Mon Feb 23 02:26:15 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_size_allocate): Fix the
allocation for the toggle button so that it actually shows up
in LTR list mode.
* gtk/gtkcombobox.c (gtk_combo_box_set_column_span_column):
* gtk/gtkcombobox.c (gtk_combo_box_set_row_span_column):
* gtk/gtkcombobox.c (gtk_combo_box_set_wrap_width): Add
notification, and avoid excessive relayouting.
Mon Feb 23 00:38:21 2004 Matthias Clasen <>
Fix bug 134982, reported by Morten Welinder:
* gtk/gtkpathbar.c (gtk_path_bar_destroy):
* gtk/gtktooltips.c (gtk_tooltips_destroy):
* gtk/gtkinvisible.c (gtk_invisible_destroy): Chain up to the
parent's ::destroy handler.
* gdk/gdkdisplay.c (gdk_display_dispose): Chain up to the
parent's ::dispose handler.
Sat Feb 21 19:09:55 2004 Manish Singh <>
* gtk/gtksettings.c (gtk_default_substitute): Guard the FC_HINT_STYLE
stuff with an #ifdef, so we still build with most fontconfig versions.
Sun Feb 22 03:03:29 2004 Matthias Clasen <>
* gtk/gtkaction.c: (gtk_action_finalize):
* gtk/gtkclipboard.c: (gtk_clipboard_finalize):
* gtk/gtkentrycompletion.c: (gtk_entry_completion_class_init),
* gtk/gtkfilechooserwidget.c: (gtk_file_chooser_widget_finalize):
* gtk/gtkfilesystemmodel.c: (gtk_file_system_model_class_init),
* gtk/gtkicontheme.c: (gtk_icon_theme_class_init),
* gtk/gtktextchild.c: (gtk_text_child_anchor_finalize):
* gtk/gtkuimanager.c: (gtk_ui_manager_class_init),
* modules/input/gtkimcontextxim.c: (gtk_im_context_xim_finalize):
Add chains to the parent's ::finalize() handler (#134901, Morten Welinder,
patch by Jan Arne Petersen)
Sun Feb 22 02:10:34 2004 Matthias Clasen <>
* gtk/gtkentrycompletion.c (gtk_entry_completion_default_completion_func):
Don't crash if item is NULL. (#131542, Dan Damian)
Sun Feb 22 02:04:03 2004 Matthias Clasen <>
* Add a check for a new enough fontconfig, since
we picked up a direct dependency on it with the Xft settings.
Sun Feb 22 00:23:40 2004 Matthias Clasen <>
Bug 112647 (Bill Haneman, patch by Narayana Pattipati):
* gtk/gtkcheckmenuitem.c: Introduce a new style property
indicator_size and use it instead of the hardcoded value.
* gtk/gtkmenu.c (gtk_menu_size_request): Make sure each menu
item gets enough vertical space for the label and the indicator.
Sat Feb 21 20:20:11 2004 Soeren Sandmann <>
* gtk/gtksettings.c (gtk_settings_class_init): Use P_ instead of
_ for the new Xft settings.
Sat Feb 21 20:09:53 2004 Soeren Sandmann <>
Bug 130790 (Federico Mena Quintero, Owen Taylor)
* gdk/x11/gdkevents-x11.c: Add Xft XSETTINGS
* gtk/gtksettings.c: Add new GtkSettings corresponding to the Xft
Sat Feb 21 19:18:26 2004 Soeren Sandmann <>
Bug 132502
* gtk/gtkmenu.c (gtk_menu_motion_notify): Make sure we pop down
if we enter a non-selectable menu item.
* gtk/gtkmenu.c (gtk_menu_leave_notify): Don't pop a submenu
when the user has left the item.
Sat Feb 21 17:57:35 2004 Soeren Sandmann <>
* gtk/docs: Commit auto-generated changes
Fri Feb 20 18:20:22 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c: conditional compile for GtkPathBar
* gtk/gtkpathbar.c (gtk_path_bar_size_allocate): Clean up
allocation code. Works fully in RTL languages, I think.
(gtk_path_bar_scroll_up): Scroll up.
(gtk_path_bar_scroll_down): Scroll down.
2004-02-20 Christian Rose <>
* Added "en_CA" to ALL_LINGUAS.
2004-02-20 Michael Meeks <>
* gtk/gtktoolitem.c (gtk_tool_item_property_notify): impl.
(gtk_tool_item_class_init): hook it up.
(gtk_tool_item_set_proxy_menu_item): synchronize sensitivity.
* gtk/gtktoolbutton.c (gtk_tool_button_property_notify):
chain to parent, fix strcmp bug.
* tests/testtoolbar.c (main): re-arrange widgets to allow
more overflowing toolbar goodness.
2004-02-20 Alexander Larsson <>
* gtk/gtkfilechooserdefault.c: (shortcuts_append_desktop):
Desktop directory is not translated.
There might not be volumes for all paths.
* gtk/gtkfilechooserwidget.c:
Use gtk_file_chooser_set_current_folder to set cwd.
Thu Feb 19 19:58:53 2004 Jonathan Blandford <>
* gtk/gtkpathbar.[ch]: New widget to handle the path in the
fileselector implementation. Not hooked up to anything yet.
* gtk/ support the path bar.
Fri Feb 20 00:21:38 2004 Matthias Clasen <>
* gtk/gtkstyle.c (gtk_default_draw_handle):
(gtk_default_draw_box): Make the paned handles gray when the the
widget is_focus() but not HAS_FOCUS(). (#122751, Soeren Sandmann)
Thu Feb 19 23:41:06 2004 Matthias Clasen <>
Fixes for #82099:
* gdk/x11/gdkevents-x11.c: Introduce new XSettings "Gtk/ButtonImages"
and "Gtk/MenuImages" and map them to "gtk-button-images" and
* gtk/gtkimagemenuitem.c: Add a boolean setting "gtk-menu-images" and
use it to set the visibility of the embedded image.
* gtk/gtkbutton.c: Add a boolean setting "gtk-button-images" and use
it to set the visibility of an embedded image.
Thu Feb 19 21:26:10 2004 Matthias Clasen <>
* gtk/gtkactiongroup.c (gtk_action_group_add_radio_actions_full):
Give each radio action its own value. (#134889, Paolo Borelli)
2004-02-19 Federico Mena Quintero <>
* gtk/gtkfilechooserdialog.c (gtk_file_chooser_dialog_finalize):
Chain to the parent's ::finalize() handler. Fixes #134885; caught
by Jan Arne Petersen.
2004-02-19 Mark McLoughlin <>
Make the entire expander widget width prelight as suggested
by Seth in bug #134263.
* gtk/gtkexpander.c:
(gtk_expander_paint_prelight): impl.
(gtk_expander_paint): use it.
(gtk_expander_redraw_expander): don't only redraw the
arrow when prelit.
2004-02-19 Alexander Larsson <>
* gtk/gtkfilechooser.c: (gtk_file_chooser_class_init):
* gtk/gtkfilechooserutils.c:
* gtk/gtkfilechooserutils.h:
* gtk/gtkfilechooserwidget.c:
Remove old file-system property.
Add new file-system-backend string property
* gtk/gtkfilechooserdefault.[ch]:
Handle the file-system-backend property
* gtk/gtkfilechooserdialog.[ch]:
Remove old file-system property.
Add new file-system-backend string property
Add new function gtk_file_chooser_dialog_new_with_backend
* gtk/gtkfilesystem.c:
* gtk/gtkfilesystem.h:
Add filesystem module support.
2004-02-18 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (shortcuts_tree_create): Renamed
from create_shortcuts_tree().
(shortcuts_pane_create): New function.
(button_new): Renamed from toolbar_button_new().
(shortcuts_pane_create): New function, create the whole shortcuts
pane here.
(current_folder_create): Renamed from toolbar_create(). Don't
create the bookmarks buttons here.
(file_pane_create): New function.
(gtk_file_chooser_default_constructor): Use the new helper
functions, and don't use an extra vbox as GtkFileChooserDefault is
already a vbox.
Thu Feb 19 01:39:30 2004 Matthias Clasen <>
* gtk/gtkuimanager.h:
* gtk/gtkuimanager.c (gtk_ui_manager_class_init): Add
default handlers for all signals; for consistency and for the
benefit of language bindings which still rely on header parsing
to find the signals. (#134269, Jeroen Zwartepoorte)
Thu Feb 19 00:45:02 2004 Matthias Clasen <>
* gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
Improve the efficiency here by prepending on the list and reverting
it after the loop. (#134435, Christian Biere)
Thu Feb 19 00:32:21 2004 Matthias Clasen <>
* gtk/gtkplug.c (_gtk_plug_remove_from_socket): Avoid errors when
removing the plug from the socket. (#128546, Christopher Blizzard)
Thu Feb 19 00:09:35 2004 Matthias Clasen <>
* gtk/gtkradiomenuitem.h:
* gtk/gtkradiomenuitem.c (gtk_radio_menu_item_new_from_widget):
(gtk_radio_menu_item_new_with_mnemonic_from_widget): New
convenience functions analogous to similar API on GtkRadioButton.
(#51700, Vitaly Tishkov, patch by Soeren Sandmann)
Wed Feb 18 17:53:27 2004 Soeren Sandmann <>
* gdk/gdkwindow.c (gdk_window_get_bg_gc): Use a scratch GC in the
case where the background is a solid color.
(gdk_window_clear_backing_rect): Reset the clip region after use.
* gdk/gdkpixbuf-render.c (gdk_pixbuf_render_threshold_alpha): Go
back to using a scratch GC. Pointed out by Owen Taylor
* gdk/gdkdraw.c (gdk_drawable_real_draw_pixbuf): Only use a
scratch GC if the passed-in one is NULL
Wed Feb 18 14:27:08 2004 Soeren Sandmann <>
* gdk/gdkwindow.c (gdk_window_get_composite_drawable): Reset clip
region back to NULL on cached GC (rest of #134728)
Wed Feb 18 13:28:57 2004 Soeren Sandmann <>
Fix bug reported by Nam SungHyun (#134728)
* gdk/gdkpixbuf-render.c (gdk_pixbuf_render_threshold_alpha):
Don't use a cached GC here since the function needs to modify the
foreground color.
* gdk/gdkwindow.c (gdk_window_end_paint): Reset clip region back
to NULL on the cached GC.
2004-02-17 Federico Mena Quintero <>
* gtk/gtkfilechooserdialog.c
(gtk_file_chooser_dialog_style_set): Use HIG-compliant spacings.
This sucks a lot.
Wed Feb 18 02:03:47 2004 Matthias Clasen <>
* gtk/gtktextbuffer.c (gtk_text_buffer_class_init): Document some
peculiarities of the ::delete_range signal. (#132135, Grant Gayed)
Wed Feb 18 01:44:59 2004 Soeren Sandmann <>
GC caching, bug #125645 (based on patch by Brian Cameron)
* gdk/gdkscreen.h (struct _GdkScreen): Add GC cache
* gdk/gdkscreen.c (gdk_screen_dispose): New function. Unref the
cached GC's here.
* gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): New function to
get a scratch gc.
* gdk/gdkinternals.h: Declare the function here
* gdk/gdkdraw.c (gdk_drawable_real_draw_pixbuf): Use
_gdk_drawable_get_scratch_gc() instead of creating a new GC.
* gdk/x11/gdkgeometry-x11.c (gdk_window_copy_area_scroll): same
* gdk/x11/gdkdrawable-x11.c (draw_with_images): same
* gdk/gdkwindow.c (gdk_window_get_composite_drawable): same
* gdk/gdkwindow.c (gdk_window_end_paint): same
* gdk/gdkpixmap.c (gdk_pixmap_colormap_new_from_pixbuf): same
* gdk/gdkpixbuf-render.c (gdk_pixbuf_render_threshold_alpha): same
* gdk/gdkpixbuf-render.c (gdk_pixbuf_render_pixmap_and_mask_for_colormap): same
Tue Feb 17 23:28:33 2004 Matthias Clasen <>
* gtk/gtkmenu.c (gtk_menu_init): ...and don't forget to initalize
priv->columns to 1.
Tue Feb 17 23:11:21 2004 Matthias Clasen <>
* gtk/gtkmenu.c (gtk_menu_do_remove): Make sure that we keep
priv->columns >= 1 even for empty menus, since we divide by it
somewhere else. (#133428, Vincent Noel)
Tue Feb 17 23:02:58 2004 Soeren Sandmann <>
Fix for #119722, reported by Olexiy Avramchenko, patch by Owen
* gdk/x11/gdkprivate-x11.h (struct _GdkGCX11): Add a depth field
* gdk/x11/gdkgc-x11.c (_gdk_x11_gc_new): Keep track of the GC's
* gdk/x11/gdkgc-x11.c (_gdk_gc_x11_get_fg_xft_color): First query
the colormap, if no colormap, special case depth 1,
* gdk/x11/gdkgc-x11.c (_gdk_x11_gc_get_fg_picture): Use
_gdk_gc_x11_get_fg_xft_color() to get the foreground color.
* gdk/x11/gdkdrawable-x11.c (gdk_x11_drawable_get_xft_draw):
Special-case bitmaps without a colormap.
* gdk/x11/gdkdrawable-x11.c (gdk_x11_draw_pixbuf): Use inherited
draw_pixbuf() implementation in the bitmap case.
2004-02-17 Mark McLoughlin <>
* modules/input/ only reference input method
modules we've actually built. Fixes re-build failure with
stale hangul module lying aroung. Bug #134518.
Mon Feb 16 19:13:21 2004 Owen Taylor <>
* gdk/gdkdraw.c: Revert last commit, please don't commit patches
without approval, this isn't the right way to do it.
2004-02-16 DindinX <>
* gdk/gdkdraw.c (gdk_draw_segments): don't try to draw more than 32767
segments at a time, since XDrawSegments cannot handle more than this.
fixes bug #122026.
Mon Feb 16 18:26:39 2004 Soeren Sandmann <>
* gtk/gtktoolbar.c (gtk_toolbar_set_child_property): Call
gtk_tool_item_set_expand(), not gtk_tool_item_set_homogeneous()
in the CHILD_PROP_EXPAND branch. (#134543, Damon Chaplin)
Mon Feb 16 00:04:46 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_cell_layout_*):
Split declaration and assignment of combo_box.
* gtk/gtkcombobox.c (gtk_combo_box_list_setup): Remove a
pointless cast
Sun Feb 15 22:08:53 2004 Matthias Clasen <>
* gtk/gtkoptionmenu.c (gtk_option_menu_get_history): Add
deprecation note pointing people to GtkComboBox.
Sun Feb 15 02:49:45 2004 Matthias Clasen <>
* gtk/gtktreednd.c:
* gtk/gtktreeview.c: Document the tree DND API.
* gtk/gtktreeview.c (gtk_tree_view_unset_rows_drag_source):
Call gtk_drag_source_unset().
Sun Feb 15 00:49:59 2004 Matthias Clasen <>
* gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_class_init):
Make stock_size an uint property, to allow custom icon
sizes. Also clarify the blurb. (#130047, Erik Grinaker)
Sat Feb 14 11:05:26 2004 Manish Singh <>
* Remove unnecessary STRIP_* definitions, and GNU
make check.
2004-02-13 Federico Mena Quintero <>
* gtk/gtkfilesystemunix.c (gtk_file_system_unix_add_bookmark):
Duh, duh, duh! Don't bail out if the bookmarks file doesn't exist
the very first time you try to save one.
2004-02-13 Federico Mena Quintero <>
Fix #129020.
* gtk/gtkfilechooserdialog.c
(set_default_size): New function, sets a reasonable default size
for the window.
(gtk_file_chooser_dialog_realize): New function, call
(gtk_file_chooser_dialog_style_set): Likewise.
(gtk_file_chooser_dialog_screen_changed): Likewise.
* tests/testfilechooser.c (main): Don't set a default size for the
Sat Feb 14 00:05:18 2004 Matthias Clasen <>
* gtk/gtktreemodelfilter.c (bsearch_elt_with_offset):
Use do instead of while. (#134031, Morten Welinder);
Sat Feb 14 00:00:52 2004 Matthias Clasen <>
* Suppress xsltproc and xmlcatalog checks
if enable_man=no. (#134162, Julio M. Merino Vidal)
Fri Feb 13 23:54:48 2004 Matthias Clasen <>
* Remove checks for sgml2html. It was once
used for building the linuxdoc version of the tutorial.
Nowadays, we use db2html. (#134164, Julio M. Merino Vidal)
Fri Feb 13 08:17:43 2004 Owen Taylor <>
Fix various compilation problems (#134312, David
* gtk/gtkscale.c (gtk_scale_get_layout_offsets): Use
g_return_if_fail(), not g_return_val_if_fail().
* gtk/gtkvscale.c (gtk_vscale_get_layout_offsets):
* gtk/gtkhscale.c (gtk_hscale_get_layout_offsets): Use
g_return_if_reached(), not g_return_val_if_reached().
* gtk/gtkvscale.c (gtk_vscale_expose): Fix the types
of some parameters.
* gtk/gtkhscale.c (gtk_hscale_get_layout_offsets): Remove
extra 'scale' parameter.
Thu Feb 12 21:58:20 2004 Owen Taylor <>
Various reentrancy fixes for widgets being destroyed
out of focus-out-event. (#128821, Grant Gayed)
* gtk/gtkwindow.c (_gtk_window_unset_focus_and_default):
Ref window and widget over callbacks.
* gtk/gtkwidget.c (gtk_widget_hide)
gtk/gtkwidget.c (gtk_widget_set_child_visible):
Ref the widget before calling _gtk_window_unset_focus_and_default(),
since that can call user callbacks.
* gtk/gtkwidget.c (gtk_widget_invalidate_widget_windows):
Do nothing if the widget isn't realized.
Fri Feb 13 01:31:44 2004 Matthias Clasen <>
* gtk/gtkbutton.c (_gtk_button_paint): Don't draw bevels around
active, RELIEF_NONE buttons that aren't depressed. This improves
the appearance of buttons in notebook tabs. (#109213, reported
by Benjamin Otte, patch by Rodney Dawes)
Fri Feb 13 01:06:08 2004 Matthias Clasen <>
* demos/gtk-demo/main.c (read_line): Protect getc_unlocked() by
HAVE_FLOCKFILE in all cases. (#134205, Julio M. Merino Vidal)
Fri Feb 13 00:54:59 2004 Matthias Clasen <>
Fix for #104811, Padraig O'Briain:
* gtk/gtkscale.h:
* gtk/gtkscale.c (_gtk_scale_clear_layout):
* gtk/gtkscale.c (gtk_scale_get_layout_offsets):
* gtk/gtkscale.c (gtk_scale_get_layout): New functions to determine the
text and its position from a GtkScale, to make it more accessible.
* gtk/gtkhscale.c (gtk_hscale_get_layout_offsets):
* gtk/gtkvscale.c (gtk_vscale_get_layout_offsets): Implementations of the
new GtkScale vfunc.
Thu Feb 12 17:59:52 2004 Owen Taylor <>
* gtk/gtkicontheme.c (gtk_icon_theme_get_search_path):
Remove an extraneous + 1 (#134015, Torsten Schoenfeld)
Thu Feb 12 23:55:08 2004 Matthias Clasen <>
* gtk/gtktooltips.h:
* gtk/gtktooltips.c (gtk_tooltips_get_info_from_tip_window): New
function to improve the accessibility of tooltips. (#114851,
Padraig O'Briain)
Thu Feb 12 23:16:04 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_popup):
* gtk/gtkcombobox.c (gtk_combo_box_popdown): Make these public and
add docs. (#132847)
Thu Feb 12 11:05:16 2004 Manish Singh <>
* gdk/x11/gdkproperty-x11.c (gdk_property_get): Assign xtype using
gdk_x11_atom_to_xatom_for_display () when type != GDK_NONE.
* gtk/gtkselection.c (_gtk_selection_request): Use GDK_NONE in
gdk_property_get call instead of 0.
* docs/reference/gdk/tmpl/properties.sgml: Document the above
as GDK_NONE instead of simply 0.
Thu Feb 12 15:46:26 2004 Soeren Sandmann <>
* gtk/gtktoolbar.c (gtk_toolbar_size_allocate): Fix up item_area
correctly in RTL mode. (#133984, patch from Semion Chichelnitsky).
Thu Feb 12 02:22:02 2004 Matthias Clasen <>
* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_set_modify_func):
Correct the docs.
Thu Feb 12 01:17:01 2004 Matthias Clasen <>
* gtk/gtktreeview.c (gtk_tree_view_enable_model_drag_source): Call
gtk_drag_source_set(), so that things like gtk_drag_set_icon_*() work
for automatic DND. (#133485, Tommi Komulainen)
Thu Feb 12 00:37:00 2004 Matthias Clasen <>
* gdk/x11/gdkproperty-x11.c (gdk_property_change): Fix misleading
debug output.
2004-02-11 Federico Mena Quintero <>
* gtk/gtkmessagedialog.c (gtk_message_dialog_map): New ::map()
handler. If no widget has the focus, try to give it to the
default widget. If there is no default widget, give it to the
first button. Fixes the cause for which #59707 was reopened.
2004-02-11 Federico Mena Quintero <>
Fixes #134051.
* gtk/gtkicontheme.c (struct _GtkIconInfo): Remove the ref_count field.
(icon_info_new): Don't initialize the ref_count field.
2004-02-11 Federico Mena Quintero <>
* gtk/gtkicontheme.c (gtk_icon_theme_prepend_search_path): Shift
the array correctly. Fixes #134055, patch by Tosten Schoenfeld
Wed Feb 11 02:23:39 2004 Matthias Clasen <>
* gtk/gtkcontainer.c (gtk_container_real_set_focus_child): Handle
focus [hv]adjustment correctly when the focus is located deeper
down in the hierarchy. (#133489)
Wed Feb 11 02:06:38 2004 Matthias Clasen <>
* gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Remove
arbitrary low upper limits on the xpad, ypad, width and height
properties. (#129696, John Ellis)
Wed Feb 11 01:24:20 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_cell_layout_clear_attributes):
Ugh. Don't try to free ints, even if they're stored in pointers.
(#133997, Morten Welinder)
2004-02-10 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_finalize):
Free the filters. Fixes #133547, patch by Morten Welinder
Tue Feb 10 12:02:14 2004 Owen Taylor <>
* gdk/x11/xsettings-client.c (read_settings): Avoid
triggering an X error when the client->manager_window
is None...makes logs look cleaner.
* gdk/x11/gdkproperty-x11.c (gdk_property_get): Handle
GDK_NONE to mean AnyPropertyType as documented. (Reported
by Yu Shao)
* gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window,
gdk_x11_screen_get_window_manager_name): Fix error trap
we've been leaking since 2002... (#129538)
2004-02-10 Federico Mena Quintero <>
Fixes the entry-related part of #133852.
* gtk/gtkfilechooserdefault.c (update_chooser_entry): Don't change
the file part of the entry if the selected item is a folder.
2004-02-10 Federico Mena Quintero <>
Fixes #133995, patch by Morten Welinder <>.
* tests/prop-editor.c (create_prop_editor): Free the title.
(object_changed): Free the children list.
Tue Feb 10 01:58:55 2004 Matthias Clasen <>
* gtk/gtkcontainer.c (gtk_container_set_focus_hadjustment):
* gtk/gtkcontainer.c (gtk_container_set_focus_vadjustment): Document
these functions.
2004-02-09 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (set_list_model): Request
GTK_FILE_INFO_ALL from the file system model, so that arbitrary
filtering will work. Perhaps we should have a way of aggregating
info types to the model as filters get installed.
Mon Feb 9 22:22:19 2004 Matthias Clasen <>
* gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear_attributes):
Ugh. Don't try to free ints, even if they're stored in pointers.
2004-02-09 Federico Mena Quintero <>
Fix #132256.
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_get_paths): Read the contents of the
filename entry in both OPEN and SAVE mode. In multiple-selection
mode, add this to the selection from the file/folder list.
(struct get_paths_closure): Add a path_from_entry field.
(get_paths_foreach): Only add the iterated path if it is not the
same as the path from the entry.
2004-02-09 Federico Mena Quintero <>
* gtk/gtkfilesystemunix.c (gtk_file_system_unix_get_folder): If
the folder is already open, add the requested info types to it.
Sun Feb 8 01:28:02 2004 Manish Singh <>
* gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget): Add appropriate
type casts for the gtk_window_set_screen() call.
Sun Feb 8 01:44:06 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget): Make popups
come up on the same screen as the combo box. (#133544,
Morten Welinder)
Fri Feb 6 23:40:24 2004 Jonathan Blandford <>
* gtk/gtkfilechooserdefault.c (create_file_list): clean up the
packing of the file selector.
Sat Feb 7 01:21:09 2004 Matthias Clasen <>
* gtk/gtktreemodel.c (gtk_tree_model_base_init): Don't use function
calls in array initializers, as some compilers seem to hate this.
(#133216, Jonas Jonsson)
Sat Feb 7 00:06:44 2004 Matthias Clasen <>
* gtk/gtkaccelmap.[hc]: Add change notification for GtkAccelMap,
by on-demand instantiating a singleton object with a "changed"
* gtk/gtkmarshalers.list (VOID:STRING,UINT,FLAGS): Add marshaller
for GtkAccelMap::changed.
Fri Feb 6 23:08:29 2004 Matthias Clasen <>
* gtk/gtktextbtree.c (_gtk_text_btree_check):
* gtk/gtkcombobox.c (gtk_combo_box_cell_layout_clear_attributes):
* gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear_attributes):
Actually free the lists. Pointed out by Morten Welinder.
Fri Feb 6 22:38:54 2004 Matthias Clasen <>
* gtk/gtkcombo.c (gtk_combo_entry_key_press): Handle character
positions in UTF-8 strings correctly. (#133315, Theppitak
2004-02-06 Morten Welinder <>
* gtk/gtktoolbar.c (show_menu): Cleanup using
gtk_menu_attach_to_widget. Also fixes leak, see #133411.
2004-02-06 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free the
list. Fixes #133546.
2004-02-06 Federico Mena Quintero <>
Fix #132327.
* gtk/gtkfilesystemunix.c (struct _GtkFileSystemUnix): Add a
folder_hash field to keep a list of live folder objects.
(gtk_file_system_unix_init): Create the folder_hash.
(gtk_file_system_unix_finalize): Destroy the folder_hash.
(gtk_file_system_unix_get_folder): Ref and return an existing
folder if we have it around, otherwise return a new folder object.
(struct _GtkFileFolderUnix): Add a field for the parent file system.
(gtk_file_folder_unix_finalize): Remove the folder from the file
system's hash table.
(gtk_file_system_unix_create_folder): Emit "files-added" on the
newly-created folder's parent. Fixes #132327.
Fri Feb 6 00:51:57 2004 Matthias Clasen <>
* gtk/gtkstock.c (builtin_items): Change the labels of the
ZOOM_100 and ZOOM_FIT stock items to "_Normal Size" and
"Best _Fit", to be HIG compliant. (#124080, Mariano
Fri Feb 6 00:45:16 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_finalize): Add a finalize
function to plug a few memory leaks. (#133544, Morten Welinder)
Fri Feb 6 00:15:38 2004 Matthias Clasen <>
* gtk/gtkcomboboxentry.c (gtk_combo_box_entry_mnemonic_activate):
Support mnemonic_activate here as well.
* gtk/gtkcombobox.c (gtk_combo_box_mnemonic_activate): Focus
the button, not the tree_view.
Thu Feb 5 23:48:19 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_mnemonic_activate): Add this
function, to make mnemonic_activate work for combo boxes.
(#133443, Paolo Borelli)
Thu Feb 5 22:05:52 2004 Matthias Clasen <>
* gtk/gtkfilesystemunix.c (bookmark_list_read): Initialize result
to FALSE. (#133539, Morten Welinder)
Thu Feb 5 21:36:43 2004 Matthias Clasen <>
* gtk/gtkcombobox.c (gtk_combo_box_set_active_iter): Fix the logic
of the depth one check. (#133488, Christian Persch)
Thu Feb 5 01:50:19 2004 Matthias Clasen <>
* gtk/gtktearoffmenuitem.c (gtk_tearoff_menu_item_paint): Fix
the drawing of tearoff menu items which don't come first in their
menu. (#33311)
Thu Feb 5 00:59:08 2004 Matthias Clasen <>
* gtk/gtkcombo.c (gtk_combo_entry_key_press): Use
g_completion_complete_utf8(). (#133313, Theppitak Karoonboonyanan)
2004-02-04 Federico Mena Quintero <>
Fix #59707.
* gtk/gtklabel.c (gtk_label_focus): Removed, so we don't ignore
the focus chain.
(gtk_label_button_press): Fix prototype.
(gtk_label_button_release): Likewise.
(gtk_label_motion): Likewise.
* tests/testgtk.c (create_message_dialog): For the dialog with
2004-02-04 Morten Welinder <>
* gtk/gtktoolbar.c (show_menu): Show on the right screen. (Fixes
bug 133411, apart from the leak.)
Tue Feb 3 13:39:27 2004 Manish Singh <>
* gtk/gtkadjustment.c (gtk_adjustment_new): pass value in last
in g_object_new, since it depends on lower and upper being set.
2004-02-03 Federico Mena Quintero <>
* gtk/gtkmessagedialog.c (gtk_message_dialog_init): Make the
window not resizable. Fixes #114032.
2004-02-03 Federico Mena Quintero <>
* gtk/gtkmessagedialog.c (gtk_message_dialog_class_init): Add
documentation for the use_separator style property.
2004-02-03 Federico Mena Quintero <>
Fix #68938.
* gtk/gtkdialog.c (GtkDialogPrivate): New private structure for
GtkDialog; right now it only contains an ignore_separator field.
(gtk_dialog_class_init): Register the private structure.
(gtk_dialog_init): Initialize the priv->ignore_separator field.
(_gtk_dialog_set_ignore_separator): New private function.
(gtk_dialog_set_has_separator): Ignore the setting if appropriate.
* gtk/gtkmessagedialog.c (gtk_message_dialog_class_init): Add a
use_separator style property.
(gtk_message_dialog_style_set): Change the dialog's separator
based on the style property.
(gtk_message_dialog_init): Set the dialog box to ignore the
separator setting.
Tue Feb 3 02:35:09 2004 Matthias Clasen <>
* gtk/ Build filesystemwin32.c if OS_WIN32 and
also dist gtkfilesystemwin32.[hc].
Tue Feb 3 02:04:44 2004 Matthias Clasen <>
* gtk/gtklabel.c (gtk_label_ensure_layout): Right-justify labels
in rtl mode. (#129071,
Tue Feb 3 02:01:25 2004 Matthias Clasen <>
* gtk/gtkmenushell.c (gtk_real_menu_shell_move_current): Exchange the
mode. (#107528)
Tue Feb 3 01:38:06 2004 Matthias Clasen <>
Clip narrow columns in rtl-oriented tree views (#128089,
* gtk/gtkstyle.c (gtk_default_draw_option):
* gtk/gtkstyle.c (gtk_default_draw_check): Clip to the
given area.
* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
Use the right clip area when calling gtk_cell_renderer_render().
* gtk/gtktreeviewcolumn.c (_gtk_tree_view_column_cell_draw_focus):
Use the right clip area when calling gtk_paint_focus().
* gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
Use the right clip area when calling gtk_paint_toggle() or
* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
Clip to the expose_area when drawing the background rectangle.
Tue Feb 3 00:14:36 2004 Soeren Sandmann <>
* gdk/x11/gdkgeometry-x11.c (queue_item_free, gdk_window_queue):
Use a weak reference instead of ref()/unref(). (#60857, reported
by Joshua N Pritikin)
* gdk/gdkimage.c (scratch_image_info_for_depth): Formatting fix.
Tue Feb 3 00:15:17 2004 Matthias Clasen <>
* gtk/gtktreeprivate.h (struct _GtkTreeViewPrivate): Add
init_hadjust_value and prev_width.
* gtk/gtktreeview.c (gtk_tree_view_init): Initialize
them here.
* gtk/gtktreeview.c (gtk_tree_view_update_size): ...and here.
* gtk/gtktreeview.c (gtk_tree_view_size_allocate): Use them
here to properly handle the initial position of rtl-oriented
tree views. (#127581,
2004-01-20 Federico Mena Quintero <>
Fix #130846, reported by R. McFarland <>.
* gtk/gtktreeview.c (gtk_tree_view_button_press): Return TRUE when
we handle an event in the colums, and FALSE at the end if the
event is not handled at all.
Mon Feb 2 23:41:48 2004 Matthias Clasen <>
* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_changed):
Don't access the level after removing the node, since that may
kill the level. (#132615, Crispin Flowerday)
2004-02-02 Tor Lillqvist <>
* gdk/win32/gdkevents-win32.c (gdk_pointer_grab): Set the cursor
in all cases. If no grab cursor specified, use the grabbing
window's cursor. If the grabbing window has no cursor, use the
default arrow cursor. (#118025)
Mon Feb 2 22:05:36 2004 Matthias Clasen <>
* gtk/gtkseparatormenuitem.c (gtk_separator_menu_item_init): The
latest in menu separation technology.
Mon Feb 2 19:04:17 2004 Soeren Sandmann <>
* gdk/x11/gdkwindow-x11.c: Assume gravity works. (Anything else
we have to take our chances with).
(Bug 97510)
Mon Feb 2 18:45:28 2004 Soeren Sandmann <>
Fix bug 110224.
* gdk/x11/gdkfont-x11.c (gdk_font_from_description_for_display):
Remove unused variable 'result'
* gdk/x11/xsettings-client.[ch]: Add new set_grab/ungrab_func() functions.
* gdk/x11/gdkevents-x11.c (_gdk_x11_events_init_screen): Use them
Mon Feb 2 14:32:32 2004 Pablo Saratxaga <>
* po/uz*.po: changed default for Uzbek; now just "uz"
is in cyrillic and "uz@Latn" for latin; "uz@Cyrl" has been removed
Sun Feb 1 16:34:07 2004 Soeren Sandmann <>
* gtk/gtktoolbar.c (gtk_toolbar_size_allocate): Only start
sliding when using the new API.
Sun Feb 1 16:03:39 2004 Soeren Sandmann <>
* gtk/gtktoolbar.c (gtk_toolbar_size_allocate): Make sure
item_area is positioned correctly. Fix #133070, reported by Jeroen
Sat Jan 31 23:13:43 2004 Matthias Clasen <>
* gtk/gtktextchild.c (gtk_text_child_anchor_finalize): Don't
crash when finalizing an unused GtkTextChildAnchor. (#132260,
Sat Jan 31 22:41:57 2004 Matthias Clasen <>
* gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Correct
the documentation for new_order. (#124790, Tim-Philipp Müller)
Sat Jan 31 22:38:07 2004 Matthias Clasen <>
* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_set_fixed_width):
Reset use_resized_width when setting fixed_width. (#108612,
Felipe Heidrich)
Sat Jan 31 16:27:44 2004 Matthias Clasen <>
* gtk/gtkmain.c (gtk_key_snooper_remove): Don't leak the
GtkKeySnooperData. (#132038, R. McFarland)
2004-01-30 Federico Mena Quintero <>
Fixes #132975.
* gtk/gtkfilesystem.c (gtk_file_system_make_path): Return NULL,
not FALSE.
(gtk_file_system_volume_render_icon): Likewise.
* gtk/gtkfilesystemwin32.c (gtk_file_system_win32_make_path):
* gtk/gtktreestore.c (gtk_tree_store_iter_n_children): Return 0,
not FALSE.
* gtk/gtktoolbar.c (gtk_toolbar_get_drop_index): Return -1, not
* gtk/gtktextiter.c (gtk_text_iter_get_chars_in_line): Return 0,
not FALSE.
(gtk_text_iter_get_bytes_in_line): Likewise.
* gdk/x11/gdkcursor-x11.c (gdk_display_get_default_cursor_size):
* gdk/linux-fb/gdkcolor-fb.c (gdk_colors_alloc): Return FALSE, not
2004-01-30 Not Zed <>
Fixes #132929.
* gtk/gtktreeview.c (cancel_arrow_animation): remove the timeout
handler when we clear the timeout id.
2004-01-30 Federico Mena Quintero <>
Fix #129872, based on a patch by Jan Arne Petersen
* gtk/gtkfilesystemunix.c (gtk_file_system_unix_list_bookmarks):
(gtk_file_system_unix_add_bookmark): Implement.
(gtk_file_system_unix_remove_bookmark): Implement.
2004-01-29 Federico Mena Quintero <>
Fixes #132693.
* gtk/gtkfilesystemunix.c (gtk_file_system_unix_get_parent): Don't
use filename_from_path(). Also, check that the filename is
(gtk_file_system_unix_get_folder): Likewise.
(gtk_file_system_unix_create_folder): Likewise.
(gtk_file_system_unix_make_path): Likewise.
(gtk_file_system_unix_parse): Likewise.
(gtk_file_folder_unix_get_info): Likewise.
(filename_from_path): Removed.
2004-01-30 Federico Mena Quintero <>
* gtk/gtkcalendar.c (arrow_action): Remove C++ comment; reported
by Damien Carbery <>. Fixes #132956.
Fri Jan 30 11:37:37 2004 Owen Taylor <>
* gdk/x11/gdkdrawable-x11.c: Revert changes from
#113476 and go back to using XftDrawSetClip, because
XftDrawSetClipRectangles is buggy in XFree86-4.3.
Thu Jan 29 18:08:06 2004 Owen Taylor <>
* gtk/gtktextlayout.c (line_display_iter_to_index)
* gtk/gtktextlayout.c (line_display_index_to_iter): Only
adjust the preedit position for lines that include the
preedit string. (#132353, Yao Zhang). How the heck
did this work as well as it did?!?!
* modules/input/gtkimcontextxim.c (gtk_im_context_xim_get_ic):
Reverse change to change of XNFilterEvents event mask from
#110493 -- it's documented and in the Xlib code an
unsigned long.
* modules/input/gtkimcontextxim.c (preedit_start_callback):
Return -1 rather than void to indicate no length limit.
Fri Jan 30 00:45:46 2004 Matthias Clasen <>
* gtk/gtkadjustment.c: Add properties to GtkAdjustment.
(#64601, Murray Cumming)
Fri Jan 30 00:13:46 2004 Matthias Clasen <>
* gtk/gtkcombo.c (gtk_combo_set_popdown_strings): Allow NULL
for strings to clear the list. (#105386, Marco Pesenti Gritti)
2004-01-28 Richard Hult <>
* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_get_size):
Free font_desc. Fixes #132805.
2004-01-29 Federico Mena Quintero <>
* gtk/gtkiconfactory.c (render_icon_name_pixbuf): Free the GError.
Patch provided by Christian Persch <>
Fixes #132574.
Thu Jan 29 11:00:18 2004 Owen Taylor <>
* gtk/gtkselection.c (gtk_selection_default_handler):
nul-terminate the target atoms. (#132656, Christian Persch)
Thu Jan 29 00:59:03 2004 Matthias Clasen <>
* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_rows_reordered):
Don't leak path if we bail out early. (#132505, Christian Persch)
Thu Jan 29 00:48:47 2004 Matthias Clasen <>
* gtk/gtkactiongroup.c (gtk_action_group_add_toggle_actions_full):
* gtk/gtkactiongroup.c (gtk_action_group_add_actions_full): Do
reference counting on the user_data that is shared between
multiple signal handlers, to avoid calling the destroy notify
multiple times. (#132447, Adam Hooper)
2004-01-28 Hans Breuer <>
* gtk/stock-icons/stock_network_(16|24).png : new GTK_STOCK_NETWORK ...
gtk/gtkstock.[hc] : ... define ...
gtk/gtkiconfactory.c : ... register ...
gtk/stock-icons/ gtk/stock-icons/makefile.msc : ... compile ...
* gtk/gtkfilesystemwin32.c : ... and use. Also adapt to recent
IFace changes.
* gtk/gtk.def : added a bunch of new exported symbols
* tests/testfilechooser.c (no_backup_files_filter) : don't crash
on filter_info->display_name being NULL
* tests/testgtk.c : make testgtk --bench=all work again
Wed Jan 28 21:40:47 2004 Matthias Clasen <>
* gtk/gtkentrycompletion.c (gtk_entry_completion_action_data_func):
Don't leak string. (#132482, Christian Persch)
Tue Jan 27 18:45:47 2004 Manish Singh <>
* m4macros/gtk-2.0.m4: quote AC_DEFUN macro names so automake
1.8 won't whine at us.
2004-01-28 Tor Lillqvist <>
* gdk/win32/gdkevents-win32.c (synthesize_leave_event,
synthesize_enter_event): Don' generate enter or leave events if
the pointer is grabbed with owner_events off, and the grab event
mask doesn't ask for them. (#129242)
(gdk_event_translate): Ditto for focus change events.
2004-01-27 Federico Mena Quintero <>
Fix #132314.
* gtk/gtkfilesystem.h: Removed the #ifdef-ed out, old icon API.
* gtk/gtkfilesystem.c: Likewise.
* gtk/gtkfilesystemunix.c (filename_get_info): Removed the old
icon-type code.
(gtk_file_system_unix_render_icon): Moved the icon-rendering code
from GtkFileInfo to here.
(gtk_file_system_unix_volume_render_icon): Implement.
2004-01-28 Changwoo Ryu <>
* modules/input/imhangul-defs.h:
* modules/input/imhangul.c:
* modules/input/ Remove broken hangul input module.
Tue Jan 27 01:56:46 2004 Soeren Sandmann <>
* gtk/gtktoolbar.c: Remove obsolete comment.
SPACE_LINE_END): Make separators wider and taller, so they are
easier to pick up when editing the toolbar.
* gtk/gtktoolbar.c (slide_idle_handler): Add a comment, simplify
a bit,
* gtk/gtktoolbar.c (rect_within): Formatting fix
* gtk/gtktoolbar.c (gtk_toolbar_set_drop_highlight_item): Make
sliding feel more responsive by only restarting sliding when the
placeholder actually changes its goal allocation.
Tue Jan 27 02:00:37 2004 Matthias Clasen <>
* gtk/gtktreeitem.c (gtk_tree_item_add_pixmaps): Avoid a
compiler warning. (#122725, Kjartan Maraas)
Tue Jan 27 01:46:54 2004 Matthias Clasen <>
Make menus work better on Xinerama (#126150):
* gtk/gtkmenuitem.c (gtk_menu_item_position_menu): Calculate the
monitor_num on the screen of the menu, not of the attach widget.
* gtk/gtkmenu.c (menu_change_screen): Forget the stored monitor_num.
(gtk_menu_window_size_request): Remember the monitor_num.
2004-01-26 Federico Mena Quintero <>
Fix #105497; constify uses of GdkColor.
* gdk/gdkgc.c (gdk_gc_set_rgb_fg_color): Constify.
(gdk_gc_set_rgb_bg_color): Constify.
(gdk_gc_set_foreground): Constify.
* gdk/x11/gdkcursor-x11.c (gdk_cursor_new_from_pixmap): Constify.
* gdk/win32/gdkcursor-win32.c (gdk_cursor_new_from_pixmap): Constify.
* gdk/linux-fb/gdkcursor-fb.c (gdk_cursor_new_from_pixmap): Constify.
* gdk/x11/gdkpixmap-x11.c (gdk_pixmap_create_from_data): Constify.
* gdk/win32/gdkpixmap-win32.c (gdk_pixmap_create_from_data): Constify.
* gdk/linux-fb/gdkpixmap-fb.c (gdk_pixmap_create_from_data): Constify.
* gdk/x11/gdkwindow-x11.c (gdk_window_set_background): Constify.
* gdk/win32/gdkwindow-win32.c (gdk_window_set_background): Constify.
* gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_background): Constify.
* gdk/gdkpango.c (gdk_draw_layout_line_with_colors): Constify.
(gdk_draw_layout_with_colors): Constify.
* gdk/gdkpixmap.c (gdk_pixmap_colormap_new_from_pixbuf): Constify.
(gdk_pixmap_colormap_create_from_xpm): Constify.
(gdk_pixmap_create_from_xpm): Constify.
(gdk_pixmap_colormap_create_from_xpm_d): Constify.
(gdk_pixmap_create_from_xpm_d): Constify.
* gtk/gtkcellview.c (gtk_cell_view_set_background_color): Constify.
* gtk/gtkclist.c (gtk_clist_set_foreground): Constify.
(gtk_clist_set_background): Constify.
* gtk/gtkcolorbutton.c (gtk_color_button_new_with_color): Constify.
(gtk_color_button_set_color): Constify.
* gtk/gtkcolorsel.c (gtk_color_selection_set_current_color):
Constify and add a check for color != NULL.
(gtk_color_selection_get_current_color): Add a check for color != NULL.
(gtk_color_selection_set_previous_color): Constify and add a check
for color != NULL.
(gtk_color_selection_get_previous_color): Add a check for color != NULL.
* gtk/gtkctree.c (gtk_ctree_node_set_foreground): Constify.
(gtk_ctree_node_set_background): Constify.
* gtk/gtktext.c (gtk_text_insert): Constify.
(insert_text_property): Constify.
(text_properties_equal): Constify.
(new_text_property): Constify.
* gtk/gtkwidget.c (gtk_widget_modify_color_component): Constify.
(gtk_widget_modify_fg): Constify.
(gtk_widget_modify_bg): Constify.
(gtk_widget_modify_text): Constify.
(gtk_widget_modify_base): Constify.
2004-01-26 Christian Rose <>
* Added "mi" to ALL_LINGUAS.
2004-01-25 Tor Lillqvist <>
* gdk/win32/gdkproperty-win32.c (gdk_property_delete): If the
WM_TRANSIENT_FOR property is being deleted, set the owner of the
window to the root window (i.e., effectively unset it). (#132411)
* gdk/win32/gdkprivate-win32.h
* gdk/win32/gdkglobals-win32.c
* gdk/win32/gdkmain-win32.c: Declare, define and initialize
_wm_transient_for, a GdkAtom for WM_TRANSIENT_FOR.
* acconfig.h: Remove HAVE_WINSOCK_H, not used any longer.
Sun Jan 25 15:14:46 2004 Soeren Sandmann <>
* gtk/gtktoolbar.c (gtk_toolbar_size_allocate): Base the decision
to map/unmap items on whether they are actually allocated outside
the toolbar, not on whether that will eventually happen. Improves
animation in the presence of overflown items.
* gtk/gtktoolbar.c (gtk_toolbar_begin_sliding): Add a
queue_resize() to so that the items will get their new goal
values and the idle handler will not immediately return FALSE.
* gtk/gtktoolbar.c (slide_idle_handler): simplify the logic and
make sure that a placeholder becoming invisible doesn't cause a
return TRUE.
* gtk/gtktoolbar.c (get_item_size): Don't special case
placeholders here.
Sat Jan 24 23:17:27 2004 Soeren Sandmann <>
* gtk/gtktoolbutton.c (gtk_tool_button_construct_contents): Only
try to pack icon if there actually is one.
* gtk/gtktoolbar.c (gtk_toolbar_size_allocate): Make sure
OVERFLOWN items get an allocation even when they are
unmapped. This ensures they will slide in properly.
* gtk/gtktoolbar.c (slide_idle_handler): Make sure we return TRUE
when there are overflown items that need to slide in. Also add
comments and make formatting more readable.
Sat Jan 24 17:38:48 2004 Soeren Sandmann <>
* gtk/gtkradiotoolbutton.c (gtk_radio_tool_button_class_init):
Add a write-only property ::group to be consistent with
GtkRadioAction and GtkRadioButton. (#132159, Patch from Olivier
Fri Jan 23 23:46:12 2004 Matthias Clasen <>
* gtk/gtkfontbutton.c (gtk_font_button_label_use_font): Don't leak the
font description. (#132168)
2004-01-23 Federico Mena Quintero <>
Fix #132247.
* gtk/gtkfilechooserdefault.c (set_select_multiple): Handle folder
(set_select_multiple): Optionally notify about changes to the
select-multiple property.
(list_selection_changed): Change the condition for the editable row to
test for save mode; this is more clear than testing for not being
in multiple selection mode.
(gtk_file_chooser_default_get_paths): Get impl->action directly
rather than calling gtk_file_chooser_get_action().
(entry_activate): Likewise.
(set_select_multiple): Annotate about #133255.
(update_chooser_entry): Likewise.
(check_preview_change): Likewise.
(tree_selection_changed): Likewise.
Fri Jan 23 14:56:18 2004 Jonathan Blandford <>
* gtk/gtktreeview.c (gtk_tree_view_get_path_at_pos): Don't crash
when there are no columns, or all columns are hidden, #131402
Fri Jan 23 16:58:28 2004 Soeren Sandmann <>
* gtk/gtkmenu.c (DEFAULT_POPUP_DELAY): Changing to 200 was a
mistake. Change back to 225.
Thu Jan 22 18:46:05 2004 Owen Taylor <>
* === Released 2.3.2 ===
Thu Jan 22 18:45:26 2004 Owen Taylor <>
* gtk/gtkicontheme.c: Patch from Christian Neumair
to make warning string more translator friendly.
* gtk/gtktreemodelfilter.h gtkseparatortoolitem.[ch]
gtk/gtktoolbar.c: Parameter name fixes to keep gtk-doc
* Require GLib-2.3.2, version 2.3.2,
interface age 0, binary age 302.
* NEWS: Organized, added some names.
Thu Jan 22 16:59:36 2004 Jonathan Blandford <>
* gtk/gtkliststore.c (gtk_list_store_reorder): Doc fix.
2004-01-22 Federico Mena Quintero <>
* gtk/gtkwidget.c (gtk_widget_class_init): Added documentation for
Thu Jan 22 21:45:24 2004 Matthias Clasen <>
* gtk/gtkmenu.c (gtk_menu_remove): Remove the attach
info after calling gtk_menu_do_remove(), since that function
uses the attach info. Doh!
* gtk/gtkmenu.c (gtk_menu_do_remove): Don't check priv->columns
for being 1 directly after setting it to 0.
Thu Jan 22 21:38:52 2004 Soeren Sandmann <>
* NEWS: Updates
2004-01-22 Alexander Larsson <>
* gdk/x11/gdkwindow-x11.c (WINDOW_IS_TOPLEVEL):
Fix typo
2004-01-21 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_finalize):
Free the path fields.
* gtk/gtkfilesystemmodel.c (gtk_file_system_model_finalize): Free
the root_path, reported by <>
(gtk_file_system_model_finalize): Unref the file system.
* gtk/gtkfilefilter.c (filter_rule_free): default:
(gtk_file_filter_finalize): Free the filter->name, reported by
(gtk_file_filter_finalize): Free the rules list.
Wed Jan 21 18:10:40 2004 Jonathan Blandford <>
* gtk/gtkcolorbutton.c (gtk_color_button_set_color):redraw the
color button when an alpha is set.
(gtk_color_button_set_alpha): redraw the color button when an
alpha is set.
Wed Jan 21 23:27:14 2004 Matthias Clasen <>
Fix #131869:
* gtk/gtkaction.c (_gtk_action_emit_activate): Hold
a reference to the group while emitting the signals.
* gtk/gtkactiongroup.c (gtk_action_group_init): Use a
destroy notify which does not only unref, but also resets
the action_group property of the action.
2004-01-20 Federico Mena Quintero <>
* NEWS: Added details about GtkFileChooser changes.
2004-01-20 Federico Mena Quintero <>
Fix #99425, add accessor functions for GtkPaned's children.
* gtk/gtkpaned.c (gtk_paned_get_child1): New function.
(gtk_paned_get_child2): New function.
Tue Jan 20 23:49:52 2004 Matthias Clasen <>
* NEWS: Start of 2.3.2 section.
Tue Jan 20 22:11:31 2004 Matthias Clasen <>
Fixes for #130370, based on a patch by Michael Meeks:
* gtk/gtkmenu.c (gtk_menu_do_remove): New auxiliary function to
adjust cell positions and recalculate row and column counts after
removing an item.
* gtk/gtkmenu.c (gtk_menu_remove): Call gtk_menu_do_remove.
* gtk/gtkmenu.c (gtk_menu_do_insert): Don't leave empty rows when
appending items.
* gtk/gtkmenu.c (gtk_menu_attach): Don't call gtk_menu_shell_append,
to avoid an unintended recursion.
2004-01-19 Federico Mena Quintero <>
Fix #131418.
* gtk/gtkfilechooserdefault.c (set_select_multiple): New helper
(gtk_file_chooser_default_set_property): Use
set_select_multiple(). Also, re-set this mode to single if the
file chooser is set to Save mode.
(entry_activate): Handle the case where the entry is completely
empty *and* its current folder does exist. Also, there is need to
test for select_multiple here now that we ensure that it won't
happen during Save mode.
Sun Jan 18 15:25:39 2004 Soeren Sandmann <>
* gtk/gtktoolbar.[ch]: Add _gtk_toolbar_paint_space_line(),
_gtk_toolbar_get_default_space_size ();
* gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose,
get_space_size): Use them here.
Sun Jan 18 13:16:34 2004 Soeren Sandmann <>
* tests/testgtk.c (create_toolbar): Set a small size request and
make the window resizable, to test mapping/unmapping of buttons.
* gtk/gtktoolbar.c (gtk_toolbar_remove_content,
gtk_toolbar_insert_tool_item): remove these functions.
* gtk/gtktoolbar.c (gtk_toolbar_show_all,
toolbar_content_show_all, gtk_toolbar_hide_all,
toolbar_content_hide_all): New functions.
Ignore show_all/hide_all for buttons created in compatibility mode.
* gtk/gtktoolbar.c (internal_insert_element, gtk_toolbar_show_all,
gtk_toolbar_hide_all): Make sure buttons are ignored by
gtk_toolbar_show_all() and gtk_toolbar_hide_all().
* gtk/gtktoolbar.c: s/regular_widget/compatibility/g
* gtk/gtktoolbar.c (struct _ToolbarContent): Allocate
GtkToolbarChild inline. Get rid of GtkToolbarChildSpace.
* gtk/gtktoolbar.c (toolbar_content_expose): Fix bug where widget
could become NULL.
* gtk/gtktoolbar.c (gtk_toolbar_add): Append new tool items
instead of prepending them.
* gtk/gtktoolbar.c (gtk_toolbar_size_allocate): Use the same
'elapsed' for all items.
* gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Turn booleans
into bitfields.
* gtk/gtktoolbar.c: Many formatting fixes
Sun Jan 18 01:51:12 2004 Matthias Clasen <>
* Add the necessary magic to create
Sat Jan 17 23:05:52 2004 Matthias Clasen <>
The second part of the fix for #114351 (see also
gdk-pixbuf/ChangeLog and po/ChangeLog):
* (SUBDIRS): Add po-properties.
* (AC_CONFIG_FILES): Add po-properties/
* gdk/gdkintl.h (P_):
* gtk/gtkintl.h (P_): Use translation domain gtk20-properties.
* gtk/gtkmain.c (gtk_parse_args): Call bindtextdomain and
bind_textdomain_codeset for gtk20-properties as well.
Sat Jan 17 22:00:07 2004 Soeren Sandmann <>
* gtk/gtktoolbar.c:
Fix rest of #128678: Implement all the toolbar_content()
methods for the old API case.
Sat Jan 17 16:53:08 2004 Soeren Sandmann <>
* gtk/gtktoolbar.c:
Phase 1 of fixing #128678: Only access ToolbarContent through a
set of new functions:
toolbar_content_expose, toolbar_content_visible,
toolbar_content_size_request, toolbar_content_is_homogeneous,
toolbar_content_is_placeholder, toolbar_content_disappearing,
toolbar_content_get_state, toolbar_content_child_visible,
toolbar_content_get_start_allocation, toolbar_content_get_expand,
toolbar_content_set_child_visible, toolbar_content_size_allocate,
toolbar_content_set_state, toolbar_content_get_widget,
toolbar_content_new_tool_item, toolbar_content_destroy,
Also fix #127092.
Sat Jan 17 12:55:13 2004 Soeren Sandmann <>
* gtk/gtktoolitem.c (gtk_tool_item_finalize): don't leak the menu
item ID.
Sat Jan 17 12:37:46 2004 Soeren Sandmann <>
* gtk/gtktoolbar.c (gtk_toolbar_finalize): Don't leak the
overflow menu.
* gtk/gtktoolbar.h (struct _GtkToolbar): Make some fields public.
2004-01-16 Federico Mena Quintero <>
* gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModel): Added a
has_editable field.
(_gtk_file_system_model_add_editable): New function.
(_gtk_file_system_model_remove_editable): New function.
(gtk_file_system_model_get_value): Return appropriate values for
the temporary editable row.
(_gtk_file_system_model_get_info): Handle the editable row.
(_gtk_file_system_model_get_path): Likewise.
* gtk/gtkfilechooserdefault.c (shortcuts_append_bookmarks):
Removed an unused variable.
(toolbar_button_new): Optionally show the button.
(up_button_clicked_cb): Renamed from up_button_cb(), fixed prototype.
(toolbar_create): Add a "New Folder" button for Save mode.
(error_building_filename_dialog): New helper function.
(gtk_file_chooser_default_get_paths): Use error_building_filename_dialog().
(create_file_list): Connect to the "edited" signal of the text
cell renderer. Store the name column and text renderer in the
impl structure.
(renderer_edited_cb): New callback.
(gtk_file_chooser_default_set_property): Show/hide the "New
folder" button when the save action changes.
(COMPARE_DIRECTORIES): Allow the info values to be NULL.
(COMPARE_DIRECTORIES): Duh, use the list_model, not the
(get_list_file_info): Likewise!
(list_icon_data_func): Handle the path being NULL.
(new_folder_button_clicked): New callback.
(list_name_data_func): If we are on the editable row, set the text
to "Type name of new folder".
(list_selection_changed): Handle the editable row.
(list_mtime_data_func): Likewise.
* gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Return
(gtk_file_system_unix_create_folder): Test the result of mkdir() correctly.
Fri Jan 16 23:59:01 2004 Matthias Clasen <>
The first part of the fix for #114351 (see also
gdk-pixbuf/ChangeLog and po/ChangeLog):
* gtk/gtkintl.h:
* gdk/gdkintl.h: Define P_() for property blurbs and nicks.
* gdk/gdkdisplaymanager.c:
* modules/input/gtkimcontextxim.c:
* gtk/*.c: Mark property blurbs and nicks with P_().
2004-01-16 Federico Mena Quintero <>
Fix #130969.
* gtk/gtkcellrenderer.h (struct _GtkCellRendererClass): Added an
editing_canceled signal.
* gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Create the
"editing-canceled" signal.
(gtk_cell_renderer_editing_canceled): New function.
* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_editing_done):
Call gtk_cell_renderer_editing_canceled().
2004-01-16 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_set_property): Do not allow setting
select_multiple when in Save mode.
(set_list_model): No need to nullify the list_model and
(gtk_file_chooser_default_get_paths): Handle folder mode as well.
(get_paths_foreach): Likewise.
* gtk/gtkfilechooser.c (gtk_file_chooser_get_filename): Clarify
documentation about folder mode.
(gtk_file_chooser_get_uri): Likewise.
2004-01-16 Federico Mena Quintero <>
* gtk/gtkfilesystem.h (struct _GtkFileSystemIface): New
get_volume_for_path() method.
(struct _GtkFileSystemIface): Finally removed the list_roots() and
get_root_info() methods, and the "roots-changed" signal.
* gtk/gtkfilesystem.c (gtk_file_system_get_volume_for_path): New
(gtk_file_system_list_roots): Removed.
(gtk_file_system_get_root_info): Removed.
* gtk/gtkfilesystemunix.c
(gtk_file_system_unix_get_volume_for_path): Implement.
(get_root_volume): New helper function.
(gtk_file_system_unix_list_volumes): Use get_root_volume().
(gtk_file_system_unix_list_roots): Removed.
(gtk_file_system_unix_get_root_info): Removed.
* gtk/gtkfilesystemmodel.c (_gtk_file_system_model_new): Don't
accept a NULL root_path.
(struct _GtkFileSystemModel): Add a field to remember the
(_gtk_file_system_model_new): Store the root_path in the model
(find_and_ref_path): Stop going up the hierarchy at the root_path
of the model. Also, don't return prematurely when walking up the
* gtk/gtkfilechooserdefault.c (create_file_list): Sigh, restore
the rules_hint.
(struct _GtkFileChooserDefault): Added a current_volume_path field.
(set_tree_model): New function; create the folder tree model here.
(create_folder_tree): Don't create the model here.
(set_list_model): Set the show_hidden flag on the list model.
Fri Jan 16 00:04:43 2004 Matthias Clasen <>
* gtk/gtknotebook.h:
* gtk/gtknotebook.c (gtk_notebook_append_page):
* gtk/gtknotebook.c (gtk_notebook_append_page_menu):
* gtk/gtknotebook.c (gtk_notebook_prepend_page):
* gtk/gtknotebook.c (gtk_notebook_prepend_page_menu):
* gtk/gtknotebook.c (gtk_notebook_insert_page):
* gtk/gtknotebook.c (gtk_notebook_insert_page_menu): Return the
index of the newly inserted page. (#130986, Olexiy Avramchenko)
Thu Jan 15 23:17:14 2004 Matthias Clasen <>
* gtk/gtkuimanager.c (gtk_ui_manager_get_toplevels): Inserting
a 'newly-allocated' to hint that the list should be freed after
Wed Jan 14 18:01:52 2004 Jonathan Blandford <>
* gtk/gtktreeview.c (gtk_tree_view_button_press): move grab_focus
to after handling the button presses in the TreeView to avoid
getting multiple selection_changes()
Wed Jan 14 21:16:20 2004 Matthias Clasen <>
* gtk/gtkimcontext.c: Documentation fix. (#131335, Theppitak
Wed Jan 14 21:00:49 2004 Matthias Clasen <>
* gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
Don't leak name and stock_id. (#131358, Morten Welinder)
Wed Jan 14 13:07:30 GMT 2004 Tony Gale <>
* docs/faq/gtk-faq.sgml: Updates to Section 5
Wed Jan 14 02:34:57 2004 Matthias Clasen <>
* gtk/gtkradioaction.c: Add a writable group property to align
with the GtkRadioButton API. (#129166, Olivier Andrieu)
Tue Jan 13 14:48:27 GMT 2004 Tony Gale <>
* docs/faq/gtk-faq.sgml: Update info on using autoconf
Mon Jan 12 23:40:34 2004 Matthias Clasen <>
* tests/testmerge.c: Adjust to the new connect_proxy signals.
* gtk/gtkuimanager.c
* gtk/gtkactiongroup.c
* gtk/gtkaction.c: Move the connect_proxy and disconnect_proxy signals
from GtkAction to GtkActionGroup and proxy it on GtkUIManager. This
removes the confusion between the disconnect_/connect_proxy signals
and the (unrelated) virtual functions of the same name and aligns
the setup with the pre_/post_activate signals.
2004-01-12 Jody Goldberg <>
* gtk/gtkaction.c (connect_proxy) : only connect activate for menus
with no submenus otherwise it looks like we activate every time a
submenu opens.
2004-01-12 Jody Goldberg <>
* gtk/gtkuimanager.c: Remove accidentially committed debug spew.
Sun Jan 11 01:55:07 2004 Matthias Clasen <>
* gtk/gtkaccelmap.c: Remove accidentally committed notification stuff.
(gtk_accel_map_unlock_path): Path locking can now be nested, a missing
entry is silently created during lock_path(), and treated as an error
during unlock_path(). These changes have been requested by Tim Janik.
2004-01-10 Jody Goldberg <>
* gtk/gtkuimanager.c (d) : Add a debug macro to quiet the spew.
s/merge_signals/ui_manager_signals/ for readability.
(gtk_ui_manager_class_init) : add pre_activate and post_activate
(cb_proxy_pre_activate) : new.
(cb_proxy_post_activate) : new.
(gtk_ui_manager_insert_action_group) : connect the proxies for
(gtk_ui_manager_remove_action_group) : disconnect them.
* gtk/gtkactiongroup.c (gtk_action_group_class_init) : add
'sensitive', and 'visible' properties. Also add pre_activate and
post_activate signals to help deal with activations at a higher
level (eg GtkUIManager)
(gtk_action_group_init) : init sensitive and visible
(gtk_action_group_set_property) : add sensitive and visible
(gtk_action_group_get_property) : add sensitive and visible
(gtk_action_group_get_sensitive) : new.
(gtk_action_group_get_visible) : new.
(cb_set_action_sensitivity) : new with minor optimization that only
signals sensitivity changes if the action could possibly change.
(cb_set_action_visiblility) : ditto.
(gtk_action_group_set_sensitive) : new. walk the actions directly
rather than using notify::sensitive because that is simpler, easier
to read, and more efficient.
(gtk_action_group_set_visible) : ditto.
(gtk_action_group_add_action) : Each action can only be in 1 group,
set GtkAction::action_group.
(gtk_action_group_remove_action) : clear it.
(gtk_action_group_add_toggle_actions_full) : warning suppression.
(gtk_action_group_add_radio_actions_full) : warning suppression.
(_gtk_action_group_emit_pre_activate) : new protected routine for use
by GtkAction.
(_gtk_action_group_emit_post_activate) : ditto.
* gtk/gtkaction.c (gtk_action_class_init) : add 'action_group' property.
(gtk_action_init) : initialize it.
(gtk_action_get_property) : get.
(gtk_action_set_property) : set it via
(gtk_action_set_action_group) : new function.
(gtk_action_sync_sensitivity) : new routine to sync proxy sensitivity
with the logical sensitivity (action & group) rather than the simple
(gtk_action_sync_visible) : use gtk_action_is_visible to handle
logical visibility (action & group) rather than the simple
action::visible. Use widget show/hide directly.
(connect_proxy) : handle the custom sensitivity handler.
Make the TOOL_BUTTON signals more general and support TOOL_ITEM
directly, with special cases for TOOL_BUTTON. Still not especially
good it might be useful to handle label/use_underline by parmspec
lookup. Those are likely to be implemented by custom types, and are
assumed to exist in GtkToolItem.
(disconnect_proxy) : disconnect the new sensitivity handler.
(_gtk_action_emit_activate) : add pre/post signals.
(gtk_action_activate) : use logical sensitivity.
(gtk_action_is_sensitive) : logical sensitivity.
(gtk_action_get_sensitive) : actual sensitivity.
(closure_accel_activate) : use logical sensitivity.
Fri Jan 9 22:23:45 2004 Matthias Clasen <>
* gtk/gtkuimanager.c: Introduce a new parser state for
accelerator elements to avoid misparsing files containing
such elements. (#131035, Morten Welinder)
Fri Jan 9 11:58:47 2004 Manish Singh <>
* gdk-pixbuf/gdk-pixbuf-io.c: #include <unistd.h> for unlink()
Fri Jan 9 15:28:21 GMT 2004 Tony Gale <>
* docs/faq/gtk-faq.sgml: update GtkEntry filter code example
Fri Jan 9 00:34:57 2004 Matthias Clasen <>
* gtk/gtkuimanager.h:
* gtk/gtkuimanager.c (gtk_ui_manager_get_toplevels): New function to
obtain a list of toplevel widgets constructed by the ui manager.
* gtk/gtkuimanager.h (GtkUIManagerItemType): Change to flags, so that
the values can be combined for gtk_ui_manager_get_toplevels().
* tests/testmerge.c: Add a "Dump toplevels" button to test
Wed Jan 7 23:20:06 2004 Matthias Clasen <>
* demos/gtk-demo/ (demos): Add entry_completion.c
* demos/gtk-demo/entry_completion.c: New demo for GtkEntryCompletion
by Anders Carlsson (#130464).
Wed Jan 7 23:07:28 2004 Matthias Clasen <>
* gtk/gtkmain.h:
* gtk/gtkmain.c (gtk_events_pending): Change the return value from
gint to gboolean. (#130718, reported by Johannes Weißl)
Wed Jan 7 23:03:32 2004 Matthias Clasen <>
* gtk/gtkactiongroup.h:
* gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
Remove the redundant name and stock_id parameters, adjust all callers.
Wed Jan 7 22:20:20 2004 Matthias Clasen <>
* gtk/gtkaction.h:
* gtk/gtkaction.c (gtk_action_new):
* gtk/gtktoggleaction.h:
* gtk/gtktoggleaction.c (gtk_toggle_action_new):
* gtk/gtkradioaction.h:
* gtk/gtkradioaction.c (gtk_radio_action_new): Add creation
functions for actions.
* gtk/gtkactiongroup.c (gtk_action_group_add_actions_full):
(gtk_action_group_add_radio_actions_full): and use the
new functions here. (#125322, Patch by Jeff Frank)
Wed Jan 7 21:42:49 2004 Matthias Clasen <>
* gtk/gtkaccelmap.c (gtk_accel_map_lock_path): Fix grammar of
2004-01-07 Jan Arne Petersen <>
* gtk/gtkfilechooserdefault.c: (shortcuts_insert_path),
(shortcuts_append_home), (shortcuts_append_desktop),
(shortcuts_append_paths), (shortcuts_add_volumes),
(shortcuts_append_bookmarks), (create_shortcuts_model),
(gtk_file_chooser_default_add_shortcut_folder): add REMOVABLE column
to the shortcuts_model.
(bookmarks_check_remove_sensitivity): use REMOVABLE column to check if
bookmarks can be removed. Fixes #129873
Wed Jan 7 02:50:55 2004 Matthias Clasen <>
* demos/testpixbuf-save.c: Make s, S, Control-S, p, P, Control-P,
i, I, Control-I test gdk_pixbuf_save(), gdk_pixbuf_save_to_buffer()
and gdk_pixbuf_save_to_callback() with jpeg, png and ico formats,
respectively. Tests #82203.
2004-01-06 Federico Mena Quintero <>
* gtk/gtkfilesel.c (gtk_file_selection_create_dir_confirmed): Use
0777 as the mode for mkdir() and let the umask do the right
thing. Fixes #121819.
* gtk/gtkfilesystemunix.c (filename_is_root): g_path_skip_root()
can return NULL; handle this. Fixes #129565.
2004-01-06 Alexander Winston <>
* gtk/gtkfilesel.c: (gtk_file_selection_delete_file): Removed space
that proceeded the end-of-sentence punctuation. Fixes: #130353.
2004-01-06 Jody Goldberg <>
* gtk/gtktoolitem.c (gtk_tool_item_set_property) : Call
gtk_tool_item_set_visible_vertical for PROP_VISIBLE_VERTICAL.
2004-01-05 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (shortcuts_append_bookmarks): Oops,
call shortcuts_add_bookmarks() here.
(remove_bookmark_button_clicked_cb): Ahem, fetch the selected
(shortcuts_append_paths): Don't display error dialogs here.
(create_file_list): Remove the @#$% rules hint.
2004-01-05 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (toolbar_button_new): New helper
(toolbar_create): Do not use a toolbar widget, just an hbox
instead. Add the bookmarks buttons and the current folder label
(create_filename_entry_and_filter_combo): Create the filter combo
(filter_create): Don't show the filter combo initially.
(up_button_cb): Renamed from toolbar_up_cb().
(create_shortcuts_buttons): Removed.
2004-01-05 Murray Cumming <>
* gdk/gdkimage.h: Added <public> documentation to the struct, as
suggested by Owen Taylor.
2004-01-05 Jody Goldberg <>
* gtk/gtkiconfactory.c (get_default_icons) : add stock indent, unindent
I would have prefered outdent, but compatibility seems more
* gtk/gtkstock.c (builtin_items) : ditto.
* gtk/gtkstock.h : ditto.
* gtk/stock-icons/ : ditto.
* gtk/stock-icons/stock_text_indent_16.png :
* gtk/stock-icons/stock_text_indent_24.png :
* gtk/stock-icons/stock_text_unindent_16.png :
* gtk/stock-icons/stock_text_unindent_24.png : from gnome-icon-theme
Sun Jan 4 15:29:04 2004 Soeren Sandmann <>
* gtk/gtkradiotoolbutton.[ch]
(gtk_radio_tool_button_new_with_stock_from_widget): Change API so
group is a GtkRadioButton, not a GtkWidget.
2004-01-04 Hans Breuer <>
* gdk/win32/gdkwindow-win32.c : use SWP_NOACTIVATE in
gdk_window_set_keep_(above|below) to make DND work again.
Thanks to Alif Wahid for noticing.
* gdk/gdk.def : update externals
* gtk/gtkfilesystemwin32.c : adapt to GtkFileSystemIFace changes
* gtk/gtk-stock.[hc] gtk/gtkiconfactory.c
gtk/stock-icons/ gtk/stock-icons/makefile.msc :
Harddisk stock icons for file system implementations. Beside
FLOPPY and CDROM there is now HARDDISK, probably some
GTK_STOCK_NETWORK would be useful, but I could not find one.
Sat Jan 3 11:39:42 2004 Manish Singh <>
* gtk/gtkclipboard.c: Update clipboard doc link.
Patch from Andrew Moise (#130462).
2004-01-01 Jody Goldberg <>
* gtk/gtkaction.c (_GtkActionPrivate) : add visible_horizontal,
(gtk_action_class_init) : here.
(gtk_action_init) : here.
(gtk_action_set_property) : here.
(gtk_action_get_property) : here.
(connect_proxy) : and here.
2003-12-30 Jody Goldberg <>
* gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel) : new
utility routine for use in derived GtkActions with the replicated code
(gtk_action_group_add_actions_full) : here.
(gtk_action_group_add_toggle_actions_full) : here.
(gtk_action_group_add_radio_actions_full) : and here.
2004-01-01 Taneem Ahmed <>
* Added "bn" to ALL_LINGUAS.
2004-01-01 Taneem Ahmed <>
* bn.po: Added Bangla translation by
of Ankur group <>.
Fri Jan 2 02:50:11 2004 Matthias Clasen <>
* gtk/gtkcalendar.c (gtk_calendar_compute_days):
* gtk/gtkcalendar.c (gtk_calendar_paint_day_names):
* gtk/gtkcalendar.c (gtk_calendar_init): Changes to support
week_start values other than 0 and 1, e.g. 6 will let weeks start
on Saturday. (#130349, Roozbeh Pournader)
2003-12-31 13:49 Daniel Rogers <>
* gdk/x11/gdkinput-x11.c: (gdk_input_translate_coordinates)
Fix to allow reasonable pointer behavior in window mode when an
extended input device reports an incorrect resolution of 0. Fixes
bug #123546
2003-12-31 Christian Neumair <>
* gdk-pixbuf/gdk-pixdata.c: (gdk_pixbuf_from_pixdata):
* gtk/gtkfilechooserdefault.c: (list_size_data_func): Use ngettext for
plurals (#123847).
Wed Dec 31 02:05:39 2003 Matthias Clasen <>
* gtk/gtkactiongroup.c (gtk_action_group_add_actions_full):
(gtk_action_group_add_radio_actions_full): Pull accelerator key
from the stock item if stock_id is given, but accelerator
not. (Noticed by Jeff Franks and Jody Goldberg)
* tests/testmerge.c: Remove the accelerator from the "Open" entry
to test the above change.
2003-12-29 Federico Mena Quintero <>
Make show_all() work for the extra and preview widgets; reported
by Paolo Maggi.
* gtk/gtkfilechooserdefault.c (set_preview_widget): show_all() the
preview widget.
(set_extra_widget): show_all() the extra widget.
Mon Dec 29 12:22:22 2003 Soeren Sandmann <>
* gtk/gtkuimanager.c (do_updates):
* gtk/gtktoolbar.c (slide_idle_handler):
* gtk/gtkdnd.c (gtk_drag_update_idle):
functions. (#130157, patch from Olexiy Avramchenko).
2003-12-29 Anders Carlsson <>
* gtk/gtkradiotoolbutton.c:
* gtk/gtkradiotoolbutton.h:
* gtk/gtkseparatortoolitem.c:
* gtk/gtkseparatortoolitem.h:
* gtk/gtktoggletoolbutton.c:
* gtk/gtktoggletoolbutton.h:
* gtk/gtktoolbar.c:
* gtk/gtktoolbar.h:
* gtk/gtktoolbutton.c:
* gtk/gtktoolbutton.h:
* gtk/gtktoolitem.c:
* gtk/gtktoolitem.h:
Update my e-mail address.
Mon Dec 29 01:36:22 2003 Matthias Clasen <>
* gtk/gtkaccelmap.[hc]: (gtk_accel_map_lock_path,
gtk_accel_map_unlock_path): Add a way to lock individual accelerator
paths. (#73207, reported by Havoc Pennington)
Sat Dec 27 23:17:56 2003 Soeren Sandmann <>
* gtk/gtktoolbar.c (slide_idle_handler): use CHILD_VISIBLE
instead of VISIBLE to determine whether we should stop
sliding. (#130018, reported by Christian Persch).
Fri Dec 26 23:24:35 2003 Matthias Clasen <>
* gtk/gtkactiongroup.c (gtk_action_group_add_radio_actions_full):
Don't use first_action without initializing it if n_entries is 0.
Thu Dec 25 00:26:34 2003 Matthias Clasen <>
* gdk/x11/gdkcursor-x11.c (gdk_display_get_default_cursor_size):
Add the missing _get_ to the name of the non-Xcursor version of
this function. (noticed by Torsten Schoenfeld)
Tue Dec 23 22:34:50 2003 Manish Singh <>
* gtk/gtkicontheme.h: fix GTK_TYPE_ICON_INFO macro, reported by
2003-12-24 Jody Goldberg <>
* gtk/gtkactiongroup.h : Add some const to the char * in
GtkActionEntry*. We're reccomending people pass static strings to
them, and not freeing them. This stems to flood of warnings that
* gtk/gtkactiongroup.c (gtk_action_group_add_actions_full) : change
temp vars to const to match above.
(gtk_action_group_add_toggle_actions_full) : ditto.
(gtk_action_group_add_radio_actions_full) : ditto.
Wed Dec 24 01:12:53 2003 Matthias Clasen <>
* gtk/gtkclipboard.[hc]: Add GtkClipboardTargetReceivedFunc,
gtk_clipboard_request_targets() and
gtk_clipboard_wait_for_targets(). (#101774, Dom Lachowicz)
Mon Dec 22 00:40:39 2003 Matthias Clasen <>
* gtk/gtkcalendar.c (gtk_calendar_paint_arrow): Use
gtk_paint_arrow instead of draw_arrow_left/draw_arrow_right.
* gtk/gtkcalendar.c (draw_arrow_left):
(draw_arrow_right): Removed.
* gtk/gtkcalendar.c (gtk_calendar_realize_arrows):
* gtk/gtkcalendar.c (gtk_calendar_state_changed): Set the
arrow_state to GTK_STATE_INSENSITIVE if the calendar is
insensitive. (#97376)
Sun Dec 21 23:17:01 2003 Matthias Clasen <>
* gtk/gtkuimanager.c (update_node):
* gtk/gtktreeview.c (gtk_tree_view_search_dialog_destroy):
* gtk/gtkcombobox.c (gtk_combo_box_relayout_item):
(gtk_combo_box_relayout): Fix memory leaks caused by the
failure to free the result of gtk_container_get_children().
Sun Dec 21 17:34:22 2003 Soeren Sandmann <>
* gdk/x11/gdkwindow-x11.c (gdk_window_reparent): Set the right
properties when the window becomes a toplevel. When a window that
was previously a toplevel becomes a toplevel again, restore its
window type. Also make sure the focus window is removed from the
XID hash when it is destroyed. (#117579, reported by Morten
Welinder, patch reviewed by Owen Taylor).
Sun Dec 21 01:54:40 2003 Matthias Clasen <>
* gtk/gtkmenushell.h:
* gtk/gtkmenushell.c (gtk_menu_shell_cancel): New function
to emit the "cancel" signal on a menu shell.
* gtk/gtkmenu.c (gtk_menu_key_press):
* gtk/gtkoptionmenu.c (gtk_option_menu_remove_menu):
* gtk/gtkmenubar.c (_gtk_menu_bar_cycle_focus): Use the
new function instead of directly emitting the
signal. (#81803, Owen Taylor)
Sun Dec 21 00:39:50 2003 Matthias Clasen <>
* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
Fix the "language_set" blurb.
Sat Dec 20 22:06:03 2003 Kristian Rietveld <>
* gtk/gtktreeview.c (gtk_tree_view_size_allocate): do not invalidate
all of treeview when resizing (#110074, patch from Soeren Sandmann).
Fri Dec 19 23:36:00 2003 Kristian Rietveld <>
Fixes #108458.
* gtk/gtkcelllayout.[ch]: added a reorder method.
* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_layout_init),
(gtk_tree_view_column_cell_layout_reorder): implement reorder.
* gtk/gtkcellview.c (gtk_cell_view_cell_layout_init),
(gtk_cell_view_cell_layout_reorder): ditto.
* gtk/gtkcombobox.c (gtk_combo_box_cell_layout_init),
(gtk_combo_box_cell_layout_reorder): ditto.
* gtk/gtkentrycompletion.c (gtk_entry_completion_cell_layout_init),
(gtk_entry_completion_reorder): ditto.
Fri Dec 19 22:18:19 2003 Kristian Rietveld <>
* gtk/gtktreeview.c (gtk_tree_view_search_equal_func): use strstr
instead of strcmp (#117127, suggestion from Soeren Sandmann).
Fri Dec 19 21:52:46 2003 Kristian Rietveld <>
* gtk/gtkmenu.c (gtk_menu_do_insert): move item insertion logic
here from gtk_menu_real_insert(),
(gtk_menu_real_insert): just call gtk_menu_do_insert(),
(gtk_menu_reorder_child): run _do_insert after inserting the child
(unbreaks _reorder_child, reported by Tim Janik).
2003-12-19 Federico Mena Quintero <>
* gtk/gtkfilechooserdefault.c (list_mtime_data_func): Use
g_date_strftime() for UTF-8 correctness; use Julian dates to
simplify the function.
Fri Dec 19 01:47:34 2003 Matthias Clasen <>
* gtk/gtkscrolledwindow.c (gtk_scrolled_window_size_request):
Test extra_width, not extra_height, when determining whether to
set extra_width. (#129647, Jan Arne Petersen)
Fri Dec 19 01:35:34 2003 Matthias Clasen <>
Fix the behaviour of insensitive actions, which was broken
when gtk_action_activate() was changed to pay attention to
sensitivity (#129557, Christian Persch)
* gtk/gtkaction.h:
* gtk/gtkaction.c (_gtk_action_emit_activate): New auxiliary
function to emit an activate signal without regard to sensitivity.
* gtk/gtkradioaction.c:
* gtk/gtktoggleaction.c: Always use _gtk_action_emit_activate()
instead of gtk_action_activate().
2003-12-18 Jody Goldberg <>
* gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon)) : Add a sanity test
to ensure that the base hicolor theme is installed. Silently
failing to produce icons that apps assume exist in the theme seems
like a bad idea.
Thu Dec 18 19:13:12 2003 Kristian Rietveld <>
Fixes #110249, reworked patch from Joshua N Pritikin.
* gtk/gtktreemodelsort.c (gtk_tree_model_sort_get_type),
(gtk_tree_model_sort_drag_data_delete): implement GtkTreeDragSource.
* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_get_type),
(gtk_tree_model_filter_drag_data_delete): ditto.
Thu Dec 18 18:01:01 2003 Kristian Rietveld <>
* gtk/gtktreeview.c (gtk_tree_view_class_init): add key bindings
for "*" and "/" (expand/collapse all). (#110195, reported by
Calum Benson).
Thu Dec 18 17:52:56 2003 Kristian Rietveld <>
* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_set_property):
clear the extra_attrs list if we set "text" after "markup".
(Fixes #121933, Federico Mena Quintero).
2003-12-18 Alexander Larsson <>
* gtk/gtkicontheme.c (gtk_icon_info_get_embedded_rect):
Fix typo that used the wrong x/y values for the x1, y1 point
Thu Dec 18 01:41:50 2003 Kristian Rietveld <>
* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init),
(gtk_cell_renderer_text_set_property), (get_layout): added language
and language_set properties like GtkTextTag has. (#103800, reported
by Owen Taylor).
Thu Dec 18 01:37:59 2003 Matthias Clasen <>
* gtk/gtkwidget.c (gtk_widget_activate): Correct misleading docs.
* gtk/gtkbutton.c (gtk_button_class_init): Add docs for the
"activate" signal. (#129358, Ka-Hing Cheung)
Thu Dec 18 01:21:59 2003 Kristian Rietveld <>
* gtk/gtktreeview.c (gtk_tree_view_class_init): Jonathan got
the logical flag backwards in the expand_collapse_cursor_row
bindings, fixing.
(gtk_tree_view_real_expand_collapse_cursor_row): invert expand
flag when !logical and in RTL. (Fixes #107527, reported by
Noah Levitt).
Thu Dec 18 01:10:16 2003 Kristian Rietveld <>
* gtk/gtktreeview.c (gtk_tree_view_button_press): only start
editing when activated by the left mouse button. (#106869,
patch from Evan Martin).
Thu Dec 18 00:57:18 2003 Kristian Rietveld <>
Migrating all cell renderers to use the new instance private data
* gtk/gtktreeprivate.h: remove GtkCellRendererInfo, as it is no
longer being used.
* gtk/gtkcellrenderer.c (gtk_cell_renderer_init),
(gtk_cell_renderer_class_init), (gtk_cell_renderer_get_property),
(set_cell_bg_color), (gtk_cell_renderer_render): remove old
GtkCellRendererInfo handling, migrate to instance private data.
* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_editing_done),
(gtk_cell_renderer_text_start_editing): moved focus_out_id
from GtkCellRendererInfo to text renderer private data.
* gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_init),
(gtk_cell_renderer_pixbuf_get_size), (gtk_cell_renderer_pixbuf_render):
migrate to instance private data.
* gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init),
(gtk_cell_renderer_toggle_render): migrate to instance private data.
Thu Dec 18 00:24:32 2003 Kristian Rietveld <>
* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init),
(gtk_cell_renderer_text_set_property), (get_layout): add a
single-paragraph-mode property, use private instance data.
(Fixes #114943, reported by Morten Welinder).
Thu Dec 18 00:07:01 2003 Kristian Rietveld <>
* gtk/gtktreemodel.h (gtk_tree_path_new_root),
(gtk_tree_model_get_iter_root): now deprecated (#106953, reported
by Matthias Clasen).
Wed Dec 17 23:50:56 2003 Kristian Rietveld <>
* gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
if we set a new stock_id and there was a previous stock_id, unref
the pixbuf (since it was used to renderer the previous stock_id
and stock_id might have been set to NULL now). (Fixes #122966).
2003-12-17 Marco Pesenti Gritti <>
* gtk/gtktreemodelsort.c: (gtk_tree_model_sort_get_iter):
Check that index is not bigger than level array length
also when depth is 1. Now get_iter_first correctly return
FALSE when the model is empty (#129411).
Wed Dec 17 23:31:19 2003 Kristian Rietveld <>
* gtk/gtktreeview.c (gtk_tree_view_search_equal_func): only
try to strcmp or strlen if we managed to normalize and casefold
the string correctly. Fixes crashes with non-UTF8 strings.
(#121617, Patch from Tim-Philipp Müller).
Wed Dec 17 23:20:23 2003 Matthias Clasen <>
* gtk/gtkexpander.c (gtk_expander_animation_timeout): Add missing
* gtk/gtkcalendar.c, gtk/gtkclist.c, gtk/gtkexpander.c,
gtk/gtklist.c, gtk/gtknotebook.c, gtk/gtkselection.c,
gtk/gtkspinbutton.c: Cast second argument to g_timeout_add() to
GSourceFunc instead of GtkFunction. (#129525, Olexiy Avramchenko)
Wed Dec 17 23:16:45 2003 Kristian Rietveld <>
* gtk/gtktreeview.c (gtk_tree_view_button_press): fix compile warning.
(#122727, patch from Kjartan Maraas).
Wed Dec 17 21:23:01 2003 Kristian Rietveld <>
Yay! Fixed height mode! Hooray! (Part 2 of #80868).
* gtk/gtktreeview.c (gtk_tree_view_class_init),
(gtk_tree_view_init), (gtk_tree_view_set_property),
(gtk_tree_view_get_property), (gtk_tree_view_set_model): add a
fixed_height_mode property,
(intialize_fixed_height_mode), (do_validate_rows),
(column_sizing_notify), (gtk_tree_view_set_fixed_height_mode),
(gtk_tree_view_style_set), (gtk_tree_view_row_changed),
(gtk_tree_view_row_inserted), (gtk_tree_view_remove_column),
(gtk_tree_view_insert_column): implement fixed height mode,
(gtk_tree_view_append_column), (gtk_tree_view_insert_column),
(gtk_tree_view_insert_column_with_data_func): update docs.
* gtk/gtktreeprivate.h: add two fields to GtkTreePrivate.
2003-12-07 Murray Cumming <>
* gtk/gtktreemodel.c:
(row_inserted_marshal, row_deleted_marshal, rows_reorderered_marshal)
Actually call the default signal handlers instead of calling the
marshallers themselves in an endless loop. These default signal handler
callbacks are not actually set so this is only noticed by gtkmm at
the moment. Bug 123923.
2003-12-16 Federico Mena Quintero <>
* gtk/gtkfilesystem.h (struct _GtkFileSystemIface): Added a
"volumes-changed" signal. Added the following methods:
* gtk/gtkfilesystem.c (gtk_file_system_base_init): Create the
"volumes-changed" signal.
(gtk_file_system_list_volumes): New function.
(gtk_file_system_volume_free): New function.
(gtk_file_system_volume_get_base_path): New function.
(gtk_file_system_volume_get_is_mounted): New function.
(gtk_file_system_volume_mount): New function.
(gtk_file_system_volume_get_display_name): New function.
(gtk_file_system_volume_render_icon): New function.
* gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_free): Implement.
(gtk_file_system_unix_volume_get_base_path): Implement.
(gtk_file_system_unix_volume_get_is_mounted): Implement.
(gtk_file_system_unix_volume_mount): Implement.
(gtk_file_system_unix_volume_get_display_name): Implement.
(gtk_file_system_unix_volume_render_icon): Implement.
* gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
Added a field for the "volumes-changed" signal connection.
(gtk_file_chooser_default_set_property): Connect to
"volumes-changed" on the file system.
(gtk_file_chooser_default_finalize): Disconnect from
* gtk/gtkfilechooserdefault.c (shortcuts_remove_rows): New helper
(shortcuts_get_index): New helper function.
(shortcuts_insert_path): Can now insert volumes as well as paths.
(shortcuts_append_paths): Don't take is_file_system_root.
(shortcuts_add_volumes): New function.
(shortcuts_append_file_system_roots): Removed.
(create_shortcuts_model): Use shortcuts_add_volumes().
(remove_bookmark_button_clicked_cb): Check that the index is
within range.
(bookmarks_check_add_sensitivity): Take volumes into account.
(shortcuts_get_selected_index): New helper function.
(remove_bookmark_button_clicked_cb): Use
(bookmarks_check_remove_sensitivity): Likewise.
(shortcuts_select_func): Likewise.
(shortcuts_row_activated_cb): Handle volumes as well as normal
(shortcuts_activate_volume): New function.
(struct _GtkFileChooserDefault): Removed the bookmarks_set and
bookmarks_iter fields.
(shortcuts_append_bookmarks): Use shortcuts_remove_rows().
(bookmarks_changed_cb): Use shortcuts_add_bookmarks().
(remove_bookmark_rows): Removed.
(shortcuts_add_bookmarks): New function; moved most of the code
over from shortcuts_append_bookmarks().
(shortcuts_append_bookmarks): Add the separator node here, and
then call shortcuts_add_bookmarks().
Tue Dec 16 15:01:10 2003 Manish Singh <>
* gtk/gtkfilechooserwidget.c: fix preprocessor conditional confusion.
(G_OS_UNIX/G_OS_WIN32 stuff)
Tue Dec 16 01:46:46 2003 Matthias Clasen <>
Do not interpret distant clicks as double-clicks (#116541,
Bernhard Walle):
* gdk/gdkdisplay.h (struct GdkDisplay): Add new fields
double_click_distance, button_x and button_y.
* gdk/gdkdisplay.c (gdk_display_init): Initialize the new fields.
* gdk/gdkdisplay.h:
* gdk/gdkevents.c (gdk_display_set_double_click_distance):
New function to set the double click distance on a display.
* gdk/gdkevents.c: Take double click distance into account
when generating single, double or triple clicks.
* gtk/gtksettings.c: Add new setting "gtk-double-click-distance".
* gdk/x11/gdkevents-x11.c: Add the XSetting
"Net/DoubleClickDistance" and map it to "gtk-double-click-distance".
2003-12-15 Federico Mena Quintero <>