Feedback on the loading indicator

[Voyager-Two]

You should also integrate the spinner from nprogress.

I'm testing out the master of IC with the progress bar and the progress bar becomes annoying and flashy when quickly navigating a site.

The spinner should be optional and separated from the progress bar.

P.S. you should separate the CSS from JS.

[dieulot]

What do you think the spinner brings that the bar doesn’t?

I’d rather have only one indicator, either the bar or the spinner, but I don’t see the need for having both.

I get your point that the bar brings too much attention to itself though. Bringing its height down from 3px to 2px (like NProgress) makes it supportable for me, testing locally on InstantClick’s website. Could you replace height:3px; by height:2px; in the JS file and tell me what you think about it?

I also deliberately chose a default color that’s a bit more punchy than NProgress’s blue, to symbolize InstantClick’s punchiness. In hindsight I realize it’s a bad design, I’ll go with NProgress’s color, or some similar blue that draws less attention.

As for separating the CSS from the JS, I think it’s more important to make InstantClick “plug and play” than giving the trouble to add CSS too.

Thanks for bringing feedback on this.

If anyone else sees this issue and would like to bring feedback on the loading indicator (currently a progress bar) in master, I’m all ears.

I’m renaming your issue to “Feedback on the loading indicator” (from “Spinner”) to reflect that.

[Voyager-Two]

Well look at Twitter for example... they replace their logo with a spinner when doing pjax.

I think it's much simpler and a lot less distracting.

I tried a lot of designs for the progress bar, even tried moving it to the bottom instead of the top. I think it's just too much. For a site like YouTube however, I think it's fine.

But most sites, I wouldn't recommend it.

[dieulot]

I think a progress bar is the best choice available. I don’t think that’s too much.

Twitter uses a spinner to great effect, but correctly incorporating a spinner on a website that’s already designed demands more work. The progress bar seems to be a much better default choice.

Also, in the future I’d like to show the real progress of the preloading (by checking the Content-Length header periodically, if available). This can’t be done with a spinner.

[Voyager-Two]

Good point, I guess I'll just have to add it my self.

Thanks anyway.

I really like IC, keep up the good work.

[ooxi]

Is there a way to plug into the loading behaviour and just display the progress yourself? Like three events navigation_start, navigation_progress, navigation_end?

[dieulot]

navigation_start is wait and navigation_end is change. “Navigation’s progress” should be handled by hand.

[ooxi]

Thanks, good to know!

[dieulot]

Closing this now, for any other feedback on the progress bar feel free to open another issue.