Skip to content

Add UNIMPLEMENTED_FEATURE macro #6152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomasspriggs
Copy link
Contributor

So that messages can be included to describe exactly what it is which is unimplemented.

Split from code review comment on #6131 for separate review.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed). None claimed.
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

So that messages can be included to describe exactly what it is which is
unimplemented.
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #6152 (590fa37) into develop (437420d) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6152      +/-   ##
===========================================
- Coverage    74.95%   74.88%   -0.07%     
===========================================
  Files         1447     1448       +1     
  Lines       158197   158202       +5     
===========================================
- Hits        118580   118477     -103     
- Misses       39617    39725     +108     
Impacted Files Coverage Δ
src/util/invariant.h 82.92% <ø> (ø)
src/solvers/flattening/bv_pointers.cpp 82.66% <100.00%> (-0.04%) ⬇️
unit/util/invariant.cpp 100.00% <100.00%> (ø)
src/ansi-c/literals/convert_float_literal.cpp 73.80% <0.00%> (-19.05%) ⬇️
src/ansi-c/c_typecheck_code.cpp 66.26% <0.00%> (-11.66%) ⬇️
src/ansi-c/c_storage_spec.cpp 86.84% <0.00%> (-10.53%) ⬇️
src/util/pointer_offset_size.cpp 86.94% <0.00%> (-5.23%) ⬇️
src/util/std_types.cpp 83.95% <0.00%> (-4.94%) ⬇️
src/util/std_code.h 91.50% <0.00%> (-3.23%) ⬇️
src/util/simplify_expr_floatbv.cpp 94.57% <0.00%> (-1.56%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f82fea4...590fa37. Read the comment docs.

#include <testing-utils/invariant.h>
#include <testing-utils/use_catch.h>

#include <invariant.h>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be util/invariant.h to make builds happy.

To confirm that the new macro is working as expected.
@thomasspriggs thomasspriggs force-pushed the tas/unimplemented_feature branch from 5d80d76 to 590fa37 Compare May 26, 2021 09:32
@thomasspriggs thomasspriggs merged commit aef9f3f into diffblue:develop May 26, 2021
@thomasspriggs thomasspriggs deleted the tas/unimplemented_feature branch May 26, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants