Skip to content

bump OS X version #6379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2021
Merged

bump OS X version #6379

merged 1 commit into from
Oct 3, 2021

Conversation

kroening
Copy link
Member

@kroening kroening commented Oct 2, 2021

This increases the required version of OS X from 10.9 to 10.15, which is the
oldest version of OS X that Apple still supplies with security fixes.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This increases the required version of OS X from 10.9 to 10.15, which is the
oldest version of OS X that Apple still supplies with security fixes.
@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #6379 (eebdba8) into develop (54a50e9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6379      +/-   ##
===========================================
- Coverage    75.91%   75.91%   -0.01%     
===========================================
  Files         1517     1517              
  Lines       164024   164022       -2     
===========================================
- Hits        124515   124513       -2     
  Misses       39509    39509              
Impacted Files Coverage Δ
src/util/cmdline.h 66.66% <ø> (ø)
src/util/cmdline.cpp 95.32% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18760ca...eebdba8. Read the comment docs.

@kroening kroening marked this pull request as ready for review October 3, 2021 08:04
Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to bump this.

@kroening kroening merged commit 1ab9590 into develop Oct 3, 2021
@kroening kroening deleted the osxversion branch October 3, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants