Skip to content

Conversation

@tautschnig
Copy link
Collaborator

  • Reject VLA declarators with * outside function definitions
  • Reject type qualifiers and storage class specifiers in array declarators outside function prototypes

According to the C standard (C99/C11):

  • Variable length array declarators with * are only valid in function parameter declarations within function definitions (not declarations)
  • Type qualifiers (like restrict, const, volatile) in array declarators are only valid in function parameter declarations
  • Storage class specifiers (like static) in array declarators are only valid in function parameter declarations within function prototypes or definitions

These constructs are not valid in:

  • File scope variable declarations
  • Block scope variable declarations
  • Any array declarator in non-parameter contexts

Fixes: #132

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

- Reject VLA declarators with * outside function definitions
- Reject type qualifiers and storage class specifiers in array
  declarators outside function prototypes

According to the C standard (C99/C11):

- Variable length array declarators with * are only valid in function
  parameter declarations within function definitions (not declarations)
- Type qualifiers (like restrict, const, volatile) in array declarators
  are only valid in function parameter declarations
- Storage class specifiers (like static) in array declarators are only
  valid in function parameter declarations within function prototypes or
  definitions

These constructs are not valid in:

- File scope variable declarations
- Block scope variable declarations
- Any array declarator in non-parameter contexts

Fixes: diffblue#132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ansi-c/Array_Declarator* regression tests: front end is too permissive

1 participant