Fix shifted directory #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it had been expecting a key `id` to be available, but sometimes it's referenced as the full length `directory_id`. this can be from backend api changes, caching etc. it's mostly just a legacy thing we are trying to get rid of so for now this will work for either case. code direction is actually for each directory to be an object in the SDK which will likely require changing this again
Member
Author
|
@PJEstrada I'll await your OK before merging |
Member
Author
|
before and after showing failing and now succeeding |
PJEstrada
approved these changes
Jul 21, 2021
Contributor
PJEstrada
left a comment
PJEstrada
left a comment
There was a problem hiding this comment.
Super this looks perfect. Thanks for catching the issue Anthony !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix detail here 1d94b4c