From 1d94b4c23dd70bb1a1734efd1e61b8c2f5f94c18 Mon Sep 17 00:00:00 2001 From: Anthony Sarkis <18080164+anthony-sarkis@users.noreply.github.com> Date: Wed, 21 Jul 2021 11:53:18 -0700 Subject: [PATCH 1/3] bugfix alignment lost it had been expecting a key `id` to be available, but sometimes it's referenced as the full length `directory_id`. this can be from backend api changes, caching etc. it's mostly just a legacy thing we are trying to get rid of so for now this will work for either case. code direction is actually for each directory to be an object in the SDK which will likely require changing this again --- sdk/diffgram/core/directory.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sdk/diffgram/core/directory.py b/sdk/diffgram/core/directory.py index 115f3b3..a4df272 100644 --- a/sdk/diffgram/core/directory.py +++ b/sdk/diffgram/core/directory.py @@ -58,7 +58,9 @@ def set_directory_by_name(self, name): nickname = directory.get("nickname") if nickname == name: - self.set_default_directory(directory.get("id")) + directory_id = directory.get("directory_id") + if directory_id is None: directory.get("id") + self.set_default_directory(directory_id) did_set = True break else: From 700e6fa39b6ae78edd9e7c1446bf05189983de87 Mon Sep 17 00:00:00 2001 From: Anthony Sarkis <18080164+anthony-sarkis@users.noreply.github.com> Date: Wed, 21 Jul 2021 11:53:35 -0700 Subject: [PATCH 2/3] Add a small test to assert the directory is indeed changing --- sdk/diffgram/hazmat/dir_setting_test.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 sdk/diffgram/hazmat/dir_setting_test.py diff --git a/sdk/diffgram/hazmat/dir_setting_test.py b/sdk/diffgram/hazmat/dir_setting_test.py new file mode 100644 index 0000000..adfab96 --- /dev/null +++ b/sdk/diffgram/hazmat/dir_setting_test.py @@ -0,0 +1,17 @@ + +from diffgram import Project +import random + +project = Project() + +name_list = [str(random.random()) for i in range(3)] +last_id = None + +for name in name_list: + + project.directory.new(name) + project.set_directory_by_name(name) + id_set = project.session.headers.get('directory_id') + print(id_set) + assert last_id != id_set + last_id = id_set From ac13de4b9c304e22c4a437ae4f54dd570caeb56c Mon Sep 17 00:00:00 2001 From: Anthony Sarkis <18080164+anthony-sarkis@users.noreply.github.com> Date: Wed, 21 Jul 2021 11:54:01 -0700 Subject: [PATCH 3/3] bump version for dir change bug fix --- sdk/diffgram/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/diffgram/__init__.py b/sdk/diffgram/__init__.py index a8a0e4f..55f5815 100644 --- a/sdk/diffgram/__init__.py +++ b/sdk/diffgram/__init__.py @@ -1,5 +1,5 @@ __name__ = "diffgram" -__version__ = "0.3.3" +__version__ = "0.3.4" from diffgram.core.core import Project from diffgram.file.file import File