From b25cb3d10e9bc0117e906ec76dbb728b7fadf015 Mon Sep 17 00:00:00 2001
From: Ned Twigg <ned.twigg@diffplug.com>
Date: Thu, 18 Sep 2025 13:10:20 -0700
Subject: [PATCH 1/4] strip down the `githubEditComment` to the basics

---
 .../enhancers/github/githubEditComment.tsx    | 44 +++++--------------
 1 file changed, 10 insertions(+), 34 deletions(-)

diff --git a/src/lib/enhancers/github/githubEditComment.tsx b/src/lib/enhancers/github/githubEditComment.tsx
index 4f6ea46..1f52bcf 100644
--- a/src/lib/enhancers/github/githubEditComment.tsx
+++ b/src/lib/enhancers/github/githubEditComment.tsx
@@ -1,6 +1,6 @@
 import OverType, { type OverTypeInstance } from 'overtype'
 import type React from 'react'
-import type { CommentEnhancer, CommentSpot } from '@/lib/enhancer'
+import type { CommentEnhancer, CommentSpot, StrippedLocation } from '@/lib/enhancer'
 import { logger } from '@/lib/logger'
 import { modifyDOM } from '../modifyDOM'
 import { commonGithubOptions } from './ghOptions'
@@ -8,10 +8,6 @@ import { prepareGitHubHighlighter } from './githubHighlighter'
 
 export interface GitHubEditCommentSpot extends CommentSpot {
   type: 'GH_EDIT_COMMENT'
-  title: string
-  domain: string
-  slug: string
-  number: number
 }
 
 export class GitHubEditCommentEnhancer implements CommentEnhancer<GitHubEditCommentSpot> {
@@ -19,32 +15,18 @@ export class GitHubEditCommentEnhancer implements CommentEnhancer<GitHubEditComm
     return ['GH_EDIT_COMMENT']
   }
 
-  tryToEnhance(_textarea: HTMLTextAreaElement): GitHubEditCommentSpot | null {
-    if (
-      document.querySelector('meta[name="hostname"]')?.getAttribute('content') !== 'github.com' ||
-      !_textarea.matches('.TimelineItem textarea')
-    ) {
+  tryToEnhance(
+    _textarea: HTMLTextAreaElement,
+    location: StrippedLocation,
+  ): GitHubEditCommentSpot | null {
+    if (location.host !== 'github.com') {
       return null
     }
-
     // Parse GitHub URL structure: /owner/repo/issues/123 or /owner/repo/pull/456
     logger.info(`${this.constructor.name} examing url`, window.location.pathname)
-
-    const match = window.location.pathname.match(/^\/([^/]+)\/([^/]+)(?:\/(pull|issues)\/(\d+))/)
-    logger.info(`${this.constructor.name} found match`, window.location.pathname)
-    if (!match) return null
-    const [, owner, repo, numberStr] = match
-    const slug = `${owner}/${repo}`
-    const number = parseInt(numberStr!, 10)
-    const unique_key = `github.com:${slug}:${number}`
-    const title = 'TODO_TITLE'
     return {
-      domain: 'github.com',
-      number,
-      slug,
-      title,
       type: 'GH_EDIT_COMMENT',
-      unique_key,
+      unique_key: '<not unique>',
     }
   }
 
@@ -59,17 +41,11 @@ export class GitHubEditCommentEnhancer implements CommentEnhancer<GitHubEditComm
     })[0]!
   }
 
-  tableUpperDecoration(spot: GitHubEditCommentSpot): React.ReactNode {
-    const { slug, number } = spot
-    return (
-      <>
-        <span className='font-mono text-muted-foreground text-sm'>{slug}</span>
-        <span className='ml-2 font-medium'>PR #{number}</span>
-      </>
-    )
+  tableUpperDecoration(_spot: GitHubEditCommentSpot): React.ReactNode {
+    return <span>N/A</span>
   }
 
   tableTitle(_spot: GitHubEditCommentSpot): string {
-    return 'TITLE_TODO'
+    return 'N/A'
   }
 }

From bce5f389a593412b09c30575b9eb7aacb8d597c1 Mon Sep 17 00:00:00 2001
From: Ned Twigg <ned.twigg@diffplug.com>
Date: Thu, 18 Sep 2025 13:22:18 -0700
Subject: [PATCH 2/4] fix conflict between issueAdd and Edit

---
 .../enhancers/github/githubEditComment.tsx    | 22 +++++++-
 .../github/githubIssueAddComment.tsx          |  6 ++
 tests/lib/enhancers/github.test.ts            | 55 +++----------------
 3 files changed, 33 insertions(+), 50 deletions(-)

diff --git a/src/lib/enhancers/github/githubEditComment.tsx b/src/lib/enhancers/github/githubEditComment.tsx
index 1f52bcf..455e80a 100644
--- a/src/lib/enhancers/github/githubEditComment.tsx
+++ b/src/lib/enhancers/github/githubEditComment.tsx
@@ -16,17 +16,33 @@ export class GitHubEditCommentEnhancer implements CommentEnhancer<GitHubEditComm
   }
 
   tryToEnhance(
-    _textarea: HTMLTextAreaElement,
+    textarea: HTMLTextAreaElement,
     location: StrippedLocation,
   ): GitHubEditCommentSpot | null {
     if (location.host !== 'github.com') {
       return null
     }
+
+    // Only enhance textareas that are within the issue/PR body editing container
+    const bodyContainer = textarea.closest('.react-issue-body')
+    if (!bodyContainer) {
+      return null
+    }
+
     // Parse GitHub URL structure: /owner/repo/issues/123 or /owner/repo/pull/456
-    logger.info(`${this.constructor.name} examing url`, window.location.pathname)
+    const match = location.pathname.match(/^\/([^/]+)\/([^/]+)\/(?:issues|pull)\/(\d+)/)
+    if (!match) {
+      return null
+    }
+
+    const [, owner, repo, numberStr] = match
+    const number = parseInt(numberStr!, 10)
+    const unique_key = `github.com:${owner}/${repo}:${number}:edit-body`
+
+    logger.debug(`${this.constructor.name} enhanced issue/PR body textarea`, unique_key)
     return {
       type: 'GH_EDIT_COMMENT',
-      unique_key: '<not unique>',
+      unique_key,
     }
   }
 
diff --git a/src/lib/enhancers/github/githubIssueAddComment.tsx b/src/lib/enhancers/github/githubIssueAddComment.tsx
index 70f7fed..2b1e1bb 100644
--- a/src/lib/enhancers/github/githubIssueAddComment.tsx
+++ b/src/lib/enhancers/github/githubIssueAddComment.tsx
@@ -31,6 +31,12 @@ export class GitHubIssueAddCommentEnhancer implements CommentEnhancer<GitHubIssu
       return null
     }
 
+    // Don't enhance textareas that are within the issue/PR body editing container
+    const bodyContainer = textarea.closest('.react-issue-body')
+    if (bodyContainer) {
+      return null
+    }
+
     // Parse GitHub URL structure: /owner/repo/issues/123 or /owner/repo/pull/456
     logger.debug(`${this.constructor.name} examing url`, location.pathname)
 
diff --git a/tests/lib/enhancers/github.test.ts b/tests/lib/enhancers/github.test.ts
index bc7af29..9483778 100644
--- a/tests/lib/enhancers/github.test.ts
+++ b/tests/lib/enhancers/github.test.ts
@@ -197,31 +197,13 @@ describe('github', () => {
         {
           "for": "id=:rc3: name=null className=prc-Textarea-TextArea-13q4j focus-visible overtype-input",
           "spot": {
-            "domain": "github.com",
-            "number": 56,
-            "slug": "diffplug/gitcasso",
-            "title": "what about the draft?",
-            "type": "GH_ISSUE_ADD_COMMENT",
-            "unique_key": "github.com:diffplug/gitcasso:56",
+            "type": "GH_EDIT_COMMENT",
+            "unique_key": "github.com:diffplug/gitcasso:56:edit-body",
           },
-          "title": "what about the draft?",
-          "upperDecoration": <React.Fragment>
-            <span
-              className="flex h-4 w-4 flex-shrink-0 items-center justify-center"
-            >
-              <IssueOpenedIcon
-                size={16}
-              />
-            </span>
-            #
-            56
-            <a
-              className="truncate hover:underline"
-              href="https://github.com/diffplug/gitcasso"
-            >
-              diffplug/gitcasso
-            </a>
-          </React.Fragment>,
+          "title": "N/A",
+          "upperDecoration": <span>
+            N/A
+          </span>,
         },
         {
           "for": "id=:ra7: name=null className=prc-Textarea-TextArea-13q4j overtype-input",
@@ -259,29 +241,8 @@ describe('github', () => {
     expect(enhancements(document, window)).toMatchInlineSnapshot(`
       [
         {
-          "for": "id=issue-3429313834-body name=pull_request[body] className=js-comment-field js-paste-markdown js-task-list-field js-quick-submit js-size-to-fit size-to-fit js-session-resumable CommentBox-input FormControl-textarea js-saved-reply-shortcut-comment-field focus-visible overtype-input",
-          "spot": {
-            "domain": "github.com",
-            "number": NaN,
-            "slug": "diffplug/gitcasso",
-            "title": "TODO_TITLE",
-            "type": "GH_EDIT_COMMENT",
-            "unique_key": "github.com:diffplug/gitcasso:NaN",
-          },
-          "title": "TITLE_TODO",
-          "upperDecoration": <React.Fragment>
-            <span
-              className="font-mono text-muted-foreground text-sm"
-            >
-              diffplug/gitcasso
-            </span>
-            <span
-              className="ml-2 font-medium"
-            >
-              PR #
-              NaN
-            </span>
-          </React.Fragment>,
+          "for": "id=issue-3429313834-body name=pull_request[body] className=js-comment-field js-paste-markdown js-task-list-field js-quick-submit js-size-to-fit size-to-fit js-session-resumable CommentBox-input FormControl-textarea js-saved-reply-shortcut-comment-field focus-visible",
+          "spot": "NO_SPOT",
         },
         {
           "for": "id=new_comment_field name=comment[body] className=js-comment-field js-paste-markdown js-task-list-field js-quick-submit FormControl-textarea CommentBox-input js-size-to-fit size-to-fit js-session-resumable js-saved-reply-shortcut-comment-field overtype-input",

From 89763c11ba666b305888e617e04b69d427e25f60 Mon Sep 17 00:00:00 2001
From: Ned Twigg <ned.twigg@diffplug.com>
Date: Thu, 18 Sep 2025 13:25:51 -0700
Subject: [PATCH 3/4] fixup edit so that it works for issues and for PRs.

---
 src/lib/enhancers/github/githubEditComment.tsx |  8 +++++---
 tests/lib/enhancers/github.test.ts             | 11 +++++++++--
 2 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/src/lib/enhancers/github/githubEditComment.tsx b/src/lib/enhancers/github/githubEditComment.tsx
index 455e80a..477d412 100644
--- a/src/lib/enhancers/github/githubEditComment.tsx
+++ b/src/lib/enhancers/github/githubEditComment.tsx
@@ -23,9 +23,11 @@ export class GitHubEditCommentEnhancer implements CommentEnhancer<GitHubEditComm
       return null
     }
 
-    // Only enhance textareas that are within the issue/PR body editing container
-    const bodyContainer = textarea.closest('.react-issue-body')
-    if (!bodyContainer) {
+    // Only enhance textareas that are for editing issue/PR body
+    const isIssueBodyEdit = textarea.closest('.react-issue-body')
+    const isPRBodyEdit = textarea.id?.match(/^issue-\d+-body$/) || textarea.name === 'pull_request[body]'
+
+    if (!isIssueBodyEdit && !isPRBodyEdit) {
       return null
     }
 
diff --git a/tests/lib/enhancers/github.test.ts b/tests/lib/enhancers/github.test.ts
index 9483778..ddb434e 100644
--- a/tests/lib/enhancers/github.test.ts
+++ b/tests/lib/enhancers/github.test.ts
@@ -241,8 +241,15 @@ describe('github', () => {
     expect(enhancements(document, window)).toMatchInlineSnapshot(`
       [
         {
-          "for": "id=issue-3429313834-body name=pull_request[body] className=js-comment-field js-paste-markdown js-task-list-field js-quick-submit js-size-to-fit size-to-fit js-session-resumable CommentBox-input FormControl-textarea js-saved-reply-shortcut-comment-field focus-visible",
-          "spot": "NO_SPOT",
+          "for": "id=issue-3429313834-body name=pull_request[body] className=js-comment-field js-paste-markdown js-task-list-field js-quick-submit js-size-to-fit size-to-fit js-session-resumable CommentBox-input FormControl-textarea js-saved-reply-shortcut-comment-field focus-visible overtype-input",
+          "spot": {
+            "type": "GH_EDIT_COMMENT",
+            "unique_key": "github.com:diffplug/gitcasso:58:edit-body",
+          },
+          "title": "N/A",
+          "upperDecoration": <span>
+            N/A
+          </span>,
         },
         {
           "for": "id=new_comment_field name=comment[body] className=js-comment-field js-paste-markdown js-task-list-field js-quick-submit FormControl-textarea CommentBox-input js-size-to-fit size-to-fit js-session-resumable js-saved-reply-shortcut-comment-field overtype-input",

From 512d53d17693ef199223b7811a32a80647a5a69c Mon Sep 17 00:00:00 2001
From: Ned Twigg <ned.twigg@diffplug.com>
Date: Thu, 18 Sep 2025 13:26:20 -0700
Subject: [PATCH 4/4] biome

---
 src/lib/enhancers/github/githubEditComment.tsx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/lib/enhancers/github/githubEditComment.tsx b/src/lib/enhancers/github/githubEditComment.tsx
index 477d412..6a78d37 100644
--- a/src/lib/enhancers/github/githubEditComment.tsx
+++ b/src/lib/enhancers/github/githubEditComment.tsx
@@ -25,7 +25,8 @@ export class GitHubEditCommentEnhancer implements CommentEnhancer<GitHubEditComm
 
     // Only enhance textareas that are for editing issue/PR body
     const isIssueBodyEdit = textarea.closest('.react-issue-body')
-    const isPRBodyEdit = textarea.id?.match(/^issue-\d+-body$/) || textarea.name === 'pull_request[body]'
+    const isPRBodyEdit =
+      textarea.id?.match(/^issue-\d+-body$/) || textarea.name === 'pull_request[body]'
 
     if (!isIssueBodyEdit && !isPRBodyEdit) {
       return null