From b123f179dd247039a59f106465b6957ec1cf4c68 Mon Sep 17 00:00:00 2001 From: Kevin Brooks Date: Mon, 14 Jun 2021 14:20:52 -0400 Subject: [PATCH] synchronize GroovyLogManager.manager operations #877 --- .../extra/eclipse/groovy/GrEclipseFormatterStepImpl.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/_ext/eclipse-groovy/src/main/java/com/diffplug/spotless/extra/eclipse/groovy/GrEclipseFormatterStepImpl.java b/_ext/eclipse-groovy/src/main/java/com/diffplug/spotless/extra/eclipse/groovy/GrEclipseFormatterStepImpl.java index 2d1208c0e5..1d2b71c69f 100644 --- a/_ext/eclipse-groovy/src/main/java/com/diffplug/spotless/extra/eclipse/groovy/GrEclipseFormatterStepImpl.java +++ b/_ext/eclipse-groovy/src/main/java/com/diffplug/spotless/extra/eclipse/groovy/GrEclipseFormatterStepImpl.java @@ -106,7 +106,9 @@ public GroovyErrorListener() { errors = Collections.synchronizedList(new ArrayList()); ILog groovyLogger = GroovyCoreActivator.getDefault().getLog(); groovyLogger.addLogListener(this); - GroovyLogManager.manager.addLogger(this); + synchronized(GroovyLogManager.manager) { + GroovyLogManager.manager.addLogger(this); + } } @Override @@ -117,7 +119,9 @@ public void logging(final IStatus status, final String plugin) { public boolean errorsDetected() { ILog groovyLogger = GroovyCoreActivator.getDefault().getLog(); groovyLogger.removeLogListener(this); - GroovyLogManager.manager.removeLogger(this); + synchronized(GroovyLogManager.manager) { + GroovyLogManager.manager.removeLogger(this); + } return 0 != errors.size(); }