From 8b2afb90b502d3134f6c75ff7ec252a05e2d753f Mon Sep 17 00:00:00 2001 From: tison Date: Sat, 6 May 2023 23:31:01 +0800 Subject: [PATCH 1/3] PalantirJavaFormat in plugin-maven should take style parameter It's on the document, but we don't actually have such a parameter. --- .../diffplug/spotless/maven/java/PalantirJavaFormat.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/plugin-maven/src/main/java/com/diffplug/spotless/maven/java/PalantirJavaFormat.java b/plugin-maven/src/main/java/com/diffplug/spotless/maven/java/PalantirJavaFormat.java index df58764c1d..c8962aa07a 100644 --- a/plugin-maven/src/main/java/com/diffplug/spotless/maven/java/PalantirJavaFormat.java +++ b/plugin-maven/src/main/java/com/diffplug/spotless/maven/java/PalantirJavaFormat.java @@ -27,9 +27,13 @@ public class PalantirJavaFormat implements FormatterStepFactory { @Parameter private String version; + @Parameter + private String style; + @Override public FormatterStep newFormatterStep(FormatterStepConfig config) { String version = this.version != null ? this.version : PalantirJavaFormatStep.defaultVersion(); - return PalantirJavaFormatStep.create(version, config.getProvisioner()); + String style = this.style != null ? this.style : PalantirJavaFormatStep.defaultStyle(); + return PalantirJavaFormatStep.create(version, style, config.getProvisioner()); } } From 0f6b1c1de6d6d6a0db6d2a959b363b4e50a927f8 Mon Sep 17 00:00:00 2001 From: tison Date: Sat, 6 May 2023 23:33:07 +0800 Subject: [PATCH 2/3] Update PalantirJavaFormat.java --- .../com/diffplug/spotless/maven/java/PalantirJavaFormat.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugin-maven/src/main/java/com/diffplug/spotless/maven/java/PalantirJavaFormat.java b/plugin-maven/src/main/java/com/diffplug/spotless/maven/java/PalantirJavaFormat.java index c8962aa07a..192588d85d 100644 --- a/plugin-maven/src/main/java/com/diffplug/spotless/maven/java/PalantirJavaFormat.java +++ b/plugin-maven/src/main/java/com/diffplug/spotless/maven/java/PalantirJavaFormat.java @@ -1,5 +1,5 @@ /* - * Copyright 2016-2022 DiffPlug + * Copyright 2016-2023 DiffPlug * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. From 22ad0b6414cdbd1da5705bd796e7560968f2cc77 Mon Sep 17 00:00:00 2001 From: Ned Twigg Date: Wed, 10 May 2023 00:26:03 -0700 Subject: [PATCH 3/3] Update changelog. --- plugin-maven/CHANGES.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugin-maven/CHANGES.md b/plugin-maven/CHANGES.md index df994a2b44..c00aeda138 100644 --- a/plugin-maven/CHANGES.md +++ b/plugin-maven/CHANGES.md @@ -3,6 +3,8 @@ We adhere to the [keepachangelog](https://keepachangelog.com/en/1.0.0/) format (starting after version `1.27.0`). ## [Unreleased] +### Fixed +* `palantir` step now accepts a `style` parameter, which is documentation had already claimed to do. ([#1694](https://github.com/diffplug/spotless/pull/1694)) ## [2.36.0] - 2023-04-06 ### Added