-
Notifications
You must be signed in to change notification settings - Fork 21
skpkg: skpkg update without manual edits #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## migration #149 +/- ##
==========================================
Coverage 98.97% 98.97%
==========================================
Files 6 6
Lines 1267 1267
==========================================
Hits 1254 1254
Misses 13 13
🚀 New features to boost your workflow:
|
sbillinge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comments.
Please confirm that no manual edits were made, or if one or two were made, e.g., adding noqa, please mark them as such with a comment to help me with the reivew.
Nice job.
cookiecutter.json
Outdated
| "maintainer_name": "Simon Billinge", | ||
| "maintainer_email": "sb2896@columbia.edu", | ||
| "maintainer_github_username": "sbillinge", | ||
| "contributors": "Sangjoon Lee, Simon Billinge, Billinge Group members", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bob is not a contributor
I think those |
|
super! Thanks @stevenhua0320 . Let's move on |
@sbillinge Ready for review. Note that I maintained the
max-line-length=115in the original package so that it would not trigger too many unncessary docstring changes.