Skip to content

Conversation

@stevenhua0320
Copy link
Contributor

@stevenhua0320 stevenhua0320 commented Nov 19, 2025

@sbillinge Ready for review. Note that I maintained the max-line-length=115 in the original package so that it would not trigger too many unncessary docstring changes.

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.97%. Comparing base (e88eb06) to head (1ab04ae).
⚠️ Report is 4 commits behind head on migration.

Additional details and impacted files
@@            Coverage Diff             @@
##           migration     #149   +/-   ##
==========================================
  Coverage      98.97%   98.97%           
==========================================
  Files              6        6           
  Lines           1267     1267           
==========================================
  Hits            1254     1254           
  Misses            13       13           
Files with missing lines Coverage Δ
tests/test_version.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments.

Please confirm that no manual edits were made, or if one or two were made, e.g., adding noqa, please mark them as such with a comment to help me with the reivew.

Nice job.

"maintainer_name": "Simon Billinge",
"maintainer_email": "sb2896@columbia.edu",
"maintainer_github_username": "sbillinge",
"contributors": "Sangjoon Lee, Simon Billinge, Billinge Group members",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bob is not a contributor

@stevenhua0320
Copy link
Contributor Author

please see comments.

Please confirm that no manual edits were made, or if one or two were made, e.g., adding noqa, please mark them as such with a comment to help me with the reivew.

Nice job.

I think those noqa is made automatically by package update as I made no edits on those files.

@sbillinge sbillinge merged commit 36c2e74 into diffpy:migration Nov 20, 2025
6 checks passed
@sbillinge
Copy link
Contributor

super! Thanks @stevenhua0320 . Let's move on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants