From f23184b1e9249147ecf3039b7fc8b5ac21b5549c Mon Sep 17 00:00:00 2001 From: Tieqiong Zhang Date: Thu, 16 Jan 2025 03:33:41 -0500 Subject: [PATCH] fix: buggy test click button url --- news/fixwin.rst | 23 +++++++++++++++++++++++ tests/testutils.py | 11 ++++------- 2 files changed, 27 insertions(+), 7 deletions(-) create mode 100644 news/fixwin.rst diff --git a/news/fixwin.rst b/news/fixwin.rst new file mode 100644 index 00000000..a89da426 --- /dev/null +++ b/news/fixwin.rst @@ -0,0 +1,23 @@ +**Added:** + +* no news: fix the buggy test + +**Changed:** + +* + +**Deprecated:** + +* + +**Removed:** + +* + +**Fixed:** + +* + +**Security:** + +* diff --git a/tests/testutils.py b/tests/testutils.py index 4b810805..06cedbd6 100644 --- a/tests/testutils.py +++ b/tests/testutils.py @@ -35,20 +35,17 @@ def overridewebbrowser(fnc_open): "Temporarily replace `webbrowser.open` with given function." import webbrowser - controller = webbrowser.get() - save_open = controller.open + save_open = webbrowser.open def open_override(url, new=0, autoraise=True): fnc_open(url) return True - controller.open = open_override + webbrowser.open = open_override try: - yield save_open + yield finally: - del controller.open - assert controller.open == save_open - pass + webbrowser.open = save_open @contextmanager