Skip to content

Formatting for pep8 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Formatting for pep8 #85

merged 3 commits into from
Jun 11, 2024

Conversation

Sparks29032
Copy link
Collaborator

@Sparks29032 Sparks29032 commented Jun 9, 2024

The check-yaml action is angry as we use jinja formatting in our yaml.

Can probably add an ignore to the conda-recipe directory as the files within are quite outdated and currently housed on conda-forge rather than our diffpy channel. We can also remove it.

@sbillinge
Copy link
Contributor

can we use extend-ignore and drop the W503 since this is ignored by default. I think `W504 is also ignored by default. The advantage of this syntax is that if any error codes are dropped in the future in the default behavior we will automatically inherit them because we don't overwrite the default ignores.

@Sparks29032
Copy link
Collaborator Author

Sparks29032 commented Jun 11, 2024

I think 504 we do not want to ignore. I tried dropping the 503 since I thought it would ignore but default, but it did not.

Edit: nvm, I understand

@sbillinge
Copy link
Contributor

sbillinge commented Jun 11, 2024 via email

@Sparks29032
Copy link
Collaborator Author

You were right about extend-ignore. Using ignore overwrote the defaults. We still do not want to ignore 504 though as that is the formatting post-503.

I also removed the conda-recipe directory as the files in there are outdated and we no longer release with the diffpy channel.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.35%. Comparing base (746d5e6) to head (3d94e42).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   64.38%   65.35%   +0.97%     
==========================================
  Files          18       18              
  Lines         890      915      +25     
==========================================
+ Hits          573      598      +25     
  Misses        317      317              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbillinge sbillinge merged commit 7ae5330 into diffpy:main Jun 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants