Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sort By -> default" is ignoring some keywords #4

Closed
Peceha opened this issue Jul 12, 2020 · 8 comments
Closed

"Sort By -> default" is ignoring some keywords #4

Peceha opened this issue Jul 12, 2020 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Peceha
Copy link

Peceha commented Jul 12, 2020

Hi
Since "Sort By -> default" is grouping by "show" field (it seems so) I just noticed it ignores many words (written into this field) and puts most of videos under "videos" group.

Thanks

@Peceha
Copy link
Author

Peceha commented Jul 13, 2020

Ahhh,
I think I know what's going on.
If there is only one video with eg. "show=blabla" it won't be placed in separate group.
But as soon as I add "show=blabla" to another video then both of them will create a group.
So maybe it is not an issue after all ...

Thanks

@ZacWalk
Copy link
Contributor

ZacWalk commented Jul 14, 2020

That is correct. Default sorting only splits out groups of albums in a show or album. However it it makes me wonder if 'sort by show' would be a useful enhancement.

@Peceha
Copy link
Author

Peceha commented Jul 14, 2020

Hi,
thanks for the answer, well .. if it is not a huge amount of work then why not :)
But just in case I tried to show on pictures what I meant in my second post.

And thanks for that program !
It is something I've been looking for for years !!

1
2
3

@ZacWalk ZacWalk self-assigned this Jul 17, 2020
@ZacWalk ZacWalk added the enhancement New feature or request label Jul 17, 2020
@ZacWalk ZacWalk added this to the 122.9 milestone Jul 17, 2020
@ZacWalk
Copy link
Contributor

ZacWalk commented Jul 17, 2020

Interesting to think about this. To me, the default search is better to only group items by show and album when there are multiple items in the group. My suggestion would be to add sort by 'show/album' that is similar but allows show groups to have 1 or more items. Not much work but I am not planning to release 122.9 until September so might take a while. (I am travelling at the moment so a limited with what work I can do)

@Peceha thanks for the clarifying diagrams and positive feedback (y)

@Peceha
Copy link
Author

Peceha commented Jul 17, 2020

That solution sounds perfect.
Thank You.

@ZacWalk
Copy link
Contributor

ZacWalk commented Sep 4, 2020

Added in 122.9

@Peceha
Copy link
Author

Peceha commented Oct 10, 2020

It's been already one month since the update but finally I got my hands on it ;) - working at sea, not much time for fun, Hehe.
Thanks for implementing the sugestions and for keeping the project alive!

@ZacWalk
Copy link
Contributor

ZacWalk commented Dec 30, 2020

I think this is done. Closing.

@ZacWalk ZacWalk closed this as completed Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants