Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Create Divider component #1040

Closed
mimarz opened this issue Nov 2, 2023 · 1 comment · Fixed by #1057
Closed

React: Create Divider component #1040

mimarz opened this issue Nov 2, 2023 · 1 comment · Fixed by #1057
Assignees
Labels
react @digdir/designsystemet-react

Comments

@mimarz
Copy link
Collaborator

mimarz commented Nov 2, 2023

Its normal to use hr element for dividing content. We have quite a few instances where a divider should be used instead of top/bottom border.

Make a simple Divider component with color tokens and top/bottom margin.

color?: 'default' | 'subtle' | 'strong'

Use cases for a divider is for dividing content used in Card, DropdownMenu , Modal, Popover etc.

Use new divider color tokens: #1056


Relevant: #1043

@mimarz mimarz added the react @digdir/designsystemet-react label Nov 3, 2023
@mrosvik
Copy link
Member

mrosvik commented Nov 6, 2023

New divider color tokens was created in meeting 6.nov: #1056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
react @digdir/designsystemet-react
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants