diff --git a/backend/controllers/projects.go b/backend/controllers/projects.go index a2ad42ca..e4cf17eb 100644 --- a/backend/controllers/projects.go +++ b/backend/controllers/projects.go @@ -294,17 +294,16 @@ func SetJobStatusForProject(c *gin.Context) { client, _, err := utils.GetGithubClient(&utils.DiggerGithubRealClientProvider{}, job.Batch.GithubInstallationId, job.Batch.RepoFullName) if err != nil { log.Printf("Error Creating github client: %v", err) - c.JSON(http.StatusInternalServerError, gin.H{"error": "Error Creating github client"}) - return - } - _, workflowRunUrl, err := utils.GetWorkflowIdAndUrlFromDiggerJobId(client, job.Batch.RepoOwner, job.Batch.RepoName, job.DiggerJobID) - if err != nil { - log.Printf("Error getting workflow ID from job: %v", err) } else { - job.WorkflowRunUrl = &workflowRunUrl - err = models.DB.UpdateDiggerJob(job) + _, workflowRunUrl, err := utils.GetWorkflowIdAndUrlFromDiggerJobId(client, job.Batch.RepoOwner, job.Batch.RepoName, job.DiggerJobID) if err != nil { - log.Printf("Error updating digger job: %v", err) + log.Printf("Error getting workflow ID from job: %v", err) + } else { + job.WorkflowRunUrl = &workflowRunUrl + err = models.DB.UpdateDiggerJob(job) + if err != nil { + log.Printf("Error updating digger job: %v", err) + } } } case "succeeded": diff --git a/cli/pkg/digger/digger.go b/cli/pkg/digger/digger.go index bf976a24..6924aebf 100644 --- a/cli/pkg/digger/digger.go +++ b/cli/pkg/digger/digger.go @@ -164,7 +164,7 @@ func UpdateStatusComment(jobs []scheduler.SerializedJob, prNumber int, prService } message = message + fmt.Sprintf("\n", job.ProjectName) - message = message + fmt.Sprintf("%v **%v** %v%v\n", job.Status.ToEmoji(), jobSpec.ProjectName, *job.WorkflowRunUrl, job.Status.ToString(), job.ResourcesSummaryString()) + message = message + fmt.Sprintf("%v **%v** %v%v\n", job.Status.ToEmoji(), jobSpec.ProjectName, *job.WorkflowRunUrl, job.Status.ToString(), job.ResourcesSummaryString()) message = message + fmt.Sprintf("\n", job.ProjectName) }