Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix basestring error. #119

Closed
wants to merge 1 commit into from
Closed

Fix basestring error. #119

wants to merge 1 commit into from

Conversation

SalahAdDin
Copy link
Contributor

Fix base string error.

@SalahAdDin
Fix basestring error.
68465d6 
Fix base string error.
@blag
Copy link
Collaborator

blag commented Oct 12, 2016

So this looks like it helps Python 2/3 compatibility, but where is this an issue? The Travis tests all seem to be passing without this...

@blag
Copy link
Collaborator

blag commented Oct 13, 2016

Also, using six would be preferable.

@SalahAdDin
Copy link
Contributor Author

Fell free to change it :D

@blag
Copy link
Collaborator

blag commented Oct 14, 2016

I don't understand how this PR helps. Is unicode, str, bytes, or basestring imported from db_fields.py? All Travis tests are passing, so this doesn't seem to fix anything, it's just adding string definitions for little gain. As such, I'm closing this until it can be demonstrated that this fixes an issue. Thanks for your help though! 😄

@blag blag closed this Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SalahAdDin @blag