fix: only mark sync state enabled when entire group is enabled #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imagine the following scenario: - *auth* namespace sync is enabled. - *config* namespace sync is disabled. - *blobIndex* namespace sync is enabled. Previously, this would report the initial namespace sync state as *enabled*. Now, this will report *disabled*, because every namespace needs to be on.
EvanHahn
force-pushed
the
dont-mark-remote-peers-enabled-until-all-enabled
branch
from
7dcdd03
to
c81dd01
Compare
gmaclennan
approved these changes
Aug 29, 2024
gmaclennan
deleted the
dont-mark-remote-peers-enabled-until-all-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagine the following scenario:
Previously, this would report the initial namespace sync state as enabled. Now, this will report disabled, because every namespace needs to be on.