Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5 deprecation warnings #129

Closed
gyng opened this issue Sep 6, 2016 · 2 comments
Closed

Rails 5 deprecation warnings #129

gyng opened this issue Sep 6, 2016 · 2 comments

Comments

@gyng
Copy link
Contributor

gyng commented Sep 6, 2016

Rails 5.0.0.1 throws the warning when used with libsaml:

DEPRECATION WARNING: before_filter is deprecated and will be removed in Rails 5.1. Use before_action instead.

The warning is thrown inside controller_helper.rb. before_action is not available in Rails 3, which, according to the gemspec, is supported by libsaml.

Will libsaml up the Rails requirement to Rails 4? I updated activemodel and activesupport to >=4 and tests are still passing. While just annoying right now, it will break with Rails 5.1.

@benoist
Copy link
Contributor

benoist commented Sep 7, 2016

I think we can create a separate branch for < Rails 4.2 for however uses it. But I will upgrade the gemspec to require at least Rails 4.2 to stay inline with the Rails maintenance policy.
I will make a major release version for this change.

@benoist
Copy link
Contributor

benoist commented Dec 13, 2016

Separate branch is created an deprecation warnings have been removed. We will do some tests in our own applications to check for any issues before releasing

@benoist benoist closed this as completed Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants