diff --git a/NOTICE b/NOTICE index 4347c0d..b9a29b1 100644 --- a/NOTICE +++ b/NOTICE @@ -12,14 +12,9 @@ specific language governing permissions and limitations under the License. This project includes: - Checker Qual under The MIT License digipost-html-validator under Apache License, Version 2.0 - error-prone annotations under Apache 2.0 - FindBugs-jsr305 under The Apache Software License, Version 2.0 - Guava InternalFutureFailureAccess and InternalFutures under The Apache Software License, Version 2.0 - Guava ListenableFuture only under The Apache Software License, Version 2.0 - Guava: Google Core Libraries for Java under Apache License, Version 2.0 - J2ObjC Annotations under Apache License, Version 2.0 + Java 10 Shim under Apache License, Version 2.0 + Java 8 Shim under Apache License, Version 2.0 OWASP Java HTML Sanitizer under Apache License, Version 2.0 SLF4J API Module under MIT License diff --git a/pom.xml b/pom.xml index 1049bf1..0cb0556 100644 --- a/pom.xml +++ b/pom.xml @@ -38,12 +38,6 @@ pom import - - - com.google.guava - guava - 32.1.2-jre - @@ -61,17 +55,17 @@ com.googlecode.owasp-java-html-sanitizer owasp-java-html-sanitizer - 20211018.2 + 20240325.1 org.slf4j slf4j-api - 1.7.32 + 1.7.36 commons-io commons-io - 2.11.0 + 2.16.1 test diff --git a/src/test/java/no/digipost/sanitizing/HtmlValidatorTestV1.java b/src/test/java/no/digipost/sanitizing/HtmlValidatorV1Test.java similarity index 96% rename from src/test/java/no/digipost/sanitizing/HtmlValidatorTestV1.java rename to src/test/java/no/digipost/sanitizing/HtmlValidatorV1Test.java index 6e6b27c..6d7430a 100644 --- a/src/test/java/no/digipost/sanitizing/HtmlValidatorTestV1.java +++ b/src/test/java/no/digipost/sanitizing/HtmlValidatorV1Test.java @@ -19,16 +19,14 @@ import org.junit.jupiter.api.Test; import java.time.Clock; -import java.time.Instant; import java.time.ZoneOffset; -import static no.digipost.sanitizing.internal.PolicyFactoryProvider.V2_IN_EFFECT; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertSame; import static org.junit.jupiter.api.Assertions.assertTrue; -class HtmlValidatorTestV1 { +class HtmlValidatorV1Test { private final HtmlValidator V1_validator = new HtmlValidator(Clock.fixed(PolicyFactoryProvider.V2_IN_EFFECT.minusSeconds(1), ZoneOffset.UTC)); diff --git a/src/test/java/no/digipost/sanitizing/HtmlValidatorTestV2.java b/src/test/java/no/digipost/sanitizing/HtmlValidatorV2Test.java similarity index 99% rename from src/test/java/no/digipost/sanitizing/HtmlValidatorTestV2.java rename to src/test/java/no/digipost/sanitizing/HtmlValidatorV2Test.java index 2500d95..8097592 100644 --- a/src/test/java/no/digipost/sanitizing/HtmlValidatorTestV2.java +++ b/src/test/java/no/digipost/sanitizing/HtmlValidatorV2Test.java @@ -26,7 +26,7 @@ import static org.junit.jupiter.api.Assertions.assertSame; import static org.junit.jupiter.api.Assertions.assertTrue; -class HtmlValidatorTestV2 { +class HtmlValidatorV2Test { private final HtmlValidator V2_validator = new HtmlValidator(Clock.fixed(PolicyFactoryProvider.V2_IN_EFFECT, ZoneOffset.UTC)); diff --git a/src/test/java/no/digipost/sanitizing/internal/RichHtmlValidatorTest.java b/src/test/java/no/digipost/sanitizing/internal/RichHtmlValidatorTest.java index 480dee3..dad779d 100755 --- a/src/test/java/no/digipost/sanitizing/internal/RichHtmlValidatorTest.java +++ b/src/test/java/no/digipost/sanitizing/internal/RichHtmlValidatorTest.java @@ -17,6 +17,7 @@ import no.digipost.sanitizing.DigipostValidatingHtmlSanitizer; import no.digipost.sanitizing.exception.ValidationException; +import static org.junit.jupiter.api.Assertions.assertTrue; import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; @@ -190,13 +191,19 @@ public void skal_tillate_maillenker_uten_target_blank() { @Test public void skal_bruke_target_blank_på_lenker_ved_andre_targets() { String validatedHtml = validator.sanitize("Clicky clicky", ApiHtmlValidatorPolicy.V2_VALIDATE_HTML_AND_CSS_POLICY); - assertEquals("Clicky clicky", validatedHtml); + assertTrue(validatedHtml.contains("target=\"_blank\"")); + assertTrue(validatedHtml.contains("noopener")); + assertTrue(validatedHtml.contains("noreferrer")); + assertTrue(validatedHtml.contains("nofollow")); } @Test public void skal_legge_på_target_blank_ved_manglende_target() { String validatedHtml = validator.sanitize("Clicky clicky", ApiHtmlValidatorPolicy.V2_VALIDATE_HTML_AND_CSS_POLICY); - assertEquals("Clicky clicky", validatedHtml); + assertTrue(validatedHtml.contains("target=\"_blank\"")); + assertTrue(validatedHtml.contains("noopener")); + assertTrue(validatedHtml.contains("noreferrer")); + assertTrue(validatedHtml.contains("nofollow")); } // https://nvd.nist.gov/vuln/detail/CVE-2021-42575