Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add codegen support for `createAndExercise` choice on daml template #1092

Closed
petro-semeniuk-da opened this issue May 13, 2019 · 4 comments

Comments

Projects
None yet
5 participants
@petro-semeniuk-da
Copy link

commented May 13, 2019

Almost all our ledger interactions are via choices however genesis is done non-atomically and having atomic way via createAndExercise would be great.

@gerolf-da gerolf-da self-assigned this May 13, 2019

gerolf-da added a commit that referenced this issue May 13, 2019

Java Codegen: generate methods for CreateAndExerciseCommand
The Java Codegen now generates methods for creating a
CreateAndExerciseCommand for a particular choice given a template.

Contributes to #1092.

gerolf-da added a commit that referenced this issue May 13, 2019

Java Codegen: generate methods for CreateAndExerciseCommand (#1107)
The Java Codegen now generates methods for creating a
CreateAndExerciseCommand for a particular choice given a template.

Contributes to #1092.
@bitonic

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

@S11001001 or @leo-da : could you take care of this for scala?

@leo-da

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

@S11001001: Can we close this issue? Do we need anything else to support CreateAndExercise in scala codegen?

@petro-semeniuk-da

This comment has been minimized.

Copy link
Author

commented May 22, 2019

Hey Leo, we are about to upgrade to 0.12.8 and pickup this goodness.

Are you able to wait for few more days?

@bitonic

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

@petro-semeniuk-da , the issue is fixed in master, so I'll close. please let us know if 0.12.18 works for you, and create / reopen an issue if necessary.

@bitonic bitonic closed this May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.