Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix divulgence in sandbox loader #1166

Closed
rautenrieth-da opened this issue May 15, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@rautenrieth-da
Copy link
Contributor

commented May 15, 2019

The sandbox loader does not properly store divulgence information for contracts. When updating the ACS, differently formatted contract IDs are compared in divulgeAlreadyCommittedContract.

As a result, contracts produced in a scenario do not have any divulgence information and valid choice exercises that rely on this may fail.

@rautenrieth-da rautenrieth-da self-assigned this May 15, 2019

rautenrieth-da added a commit that referenced this issue May 15, 2019

Fix updating divulgence info in scenarios
The ACS was comparing differently formatted contract IDs.

Fixes #1166

rautenrieth-da added a commit that referenced this issue May 15, 2019

Fix updating divulgence info in scenarios
The ACS was comparing differently formatted contract IDs.

Fixes #1166

@bitonic bitonic closed this in b4506ca May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.