Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages loaded to run scenarios are discarded after compilation #1238

Closed
stefanobaghino-da opened this issue May 20, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@stefanobaghino-da
Copy link
Member

commented May 20, 2019

In order for a scenario to be ran, the engine loads and compiles the relevant packages to its internal representation. This is then discarded, meaning that the packages need to go through the same compilation phase again when commands are issued.

Keeping the internal representation after the scenario evaluation could improve sandbox startup latency, in particular when testing.

bitonic added a commit that referenced this issue May 20, 2019

bitonic added a commit that referenced this issue May 20, 2019

bitonic added a commit that referenced this issue May 21, 2019

bitonic added a commit that referenced this issue May 21, 2019

bitonic added a commit that referenced this issue May 21, 2019

bitonic added a commit that referenced this issue May 21, 2019

bitonic added a commit that referenced this issue May 21, 2019

mergify bot added a commit that referenced this issue May 21, 2019

@bitonic

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

#1248 fixed this.

@bitonic bitonic closed this May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.