Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `key` to `CreatedEvent` in API #1268

Closed
bame-da opened this issue May 21, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@bame-da
Copy link
Contributor

commented May 21, 2019

Now that we have stable IDs for contract instances (aka contract keys), I would like to be able to use them in the rest of the application as well. However, the projection key isn't available outside DAML. Rather than rewriting it in the application language, I'd like to receive the key as part of the CreateEvent.

It may even be worth having it on Event/TreeEvent rather than CreatedEvent so that I can completely forget about ContractIds in some applications.

@bame-da

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

@stefanobaghino-da as discussed.

@stefanobaghino-da stefanobaghino-da self-assigned this May 24, 2019

@stefanobaghino-da stefanobaghino-da changed the title Add `key` to `CreateEvent` in API Add `key` to `CreatedEvent` in API May 27, 2019

stefanobaghino-da added a commit that referenced this issue Jun 11, 2019

stefanobaghino-da added a commit that referenced this issue Jun 11, 2019

stefanobaghino-da added a commit that referenced this issue Jun 11, 2019

stefanobaghino-da added a commit that referenced this issue Jun 11, 2019

stefanobaghino-da added a commit that referenced this issue Jun 12, 2019

stefanobaghino-da added a commit that referenced this issue Jun 12, 2019

stefanobaghino-da added a commit that referenced this issue Jun 12, 2019

stefanobaghino-da added a commit that referenced this issue Jun 12, 2019

@mergify mergify bot closed this in #1586 Jun 14, 2019

mergify bot added a commit that referenced this issue Jun 14, 2019

Add contract keys to created events in the Ledger API (#1586)
* Add contract keys to created events in the Ledger API

Fixes #1268

* Update ledger/ledger-api-integration-tests/src/test/itsuite/scala/com/digitalasset/platform/tests/integration/ledger/api/TransactionServiceIT.scala

Co-Authored-By: Stephen Compall <scompall@nocandysw.com>

* Update language-support/java/bindings-rxjava/src/test/scala/com/daml/ledger/rxjava/grpc/helpers/TransactionGenerator.scala

Co-Authored-By: Stephen Compall <scompall@nocandysw.com>

* Update ledger/ledger-api-integration-tests/src/test/itsuite/scala/com/digitalasset/platform/tests/integration/ledger/api/TransactionServiceIT.scala

Co-Authored-By: Stephen Compall <scompall@nocandysw.com>

* Add run suffix to transaction service integration tests

Addresses #1586 (comment)
Addresses #1586 (comment)

* Re-introduce unused bindings

Addresses #1586 (comment)
Addresses #1586 (comment)

* Update ledger/ledger-api-common/src/main/scala/com/digitalasset/platform/participant/util/LfEngineToApi.scala

Co-Authored-By: Stephen Compall <scompall@nocandysw.com>

* Use newly introduce assertOrRuntimeEx method

Applies the suggestion introduced by 7cc5c3e

* Contract keys to be typed after generated types

Also adds support in daml-lf/interface for contract keys

Addresses #1586 (review)

* Address #1586 (comment)

* Fix compilation error from previous commit

* Fix compilation errors in navigator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.