Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extractor contract template subscription should be configurable so users can filter out templates they are not interested in #1352

Closed
leo-da opened this issue May 23, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@leo-da
Copy link
Contributor

commented May 23, 2019

SPD-1220:

As a reporting database user I want to configure my reporting database's contract template subscription configurations so that I may customize contract templates stored in my database.

--The reporting database shall support contract template subscription configurations on a per-reporting database basis, allowing each distributed ledger party to customize their reporting database data retention policy.

The user shall be able to define contract templates to listen for and store in their database.

DA Estimation Assumptions
Should not be at field level

@leo-da leo-da changed the title As a reporting database user I want to configure my reporting database's contract template subscription configurations so that I may customize contract templates stored in my database. Extractor contract template subscription should be configurable so users can filter out templates they are not interested in May 23, 2019

@leo-da leo-da added this to the Maintenance milestone May 23, 2019

@leo-da leo-da self-assigned this May 23, 2019

leo-da added a commit that referenced this issue May 28, 2019

Add support for optional `--templates` configuration, #1352
template configs can be passed in the format:
`--templates <module1>:<entity1>,<module2>:<entity2>`

if no templates passed, use `Filters.defaultInstance`,
which means subscribe for all templates

leo-da added a commit that referenced this issue May 29, 2019

Add support for optional `--templates` configuration, #1352
template configs can be passed in the format:
`--templates <module1>:<entity1>,<module2>:<entity2>`

if no templates passed, use `Filters.defaultInstance`,
which means subscribe for all templates

@leo-da leo-da referenced this issue May 29, 2019

Merged

Extractor to support template filtering #1361

6 of 6 tasks complete

leo-da added a commit that referenced this issue May 30, 2019

Add support for optional `--templates` configuration, #1352
template configs can be passed in the format:
`--templates <module1>:<entity1>,<module2>:<entity2>`

if no templates passed, use `Filters.defaultInstance`,
which means subscribe for all templates

mergify bot added a commit that referenced this issue May 31, 2019

Extractor to support template filtering (#1361)
* Add support for optional `--templates` configuration, #1352

template configs can be passed in the format:
`--templates <module1>:<entity1>,<module2>:<entity2>`

if no templates passed, use `Filters.defaultInstance`,
which means subscribe for all templates

* TemplateConfigs is a Set now

converting set to a sorted list, when validating previous startup params
so we have a deterministic order of template configs.

* Adding test case for template filtering and logging

Test fails: Template filtration is not supported on GetTransactionTrees
RPC. To get filtered data, use the GetTransactions RPC
Some refactoring will follow.

* Proper template ID filtering, more tests

have to convert Identifier to tuple

* Updating release notes.

* Replacing filter-map chain with collect

@leo-da leo-da closed this in #1481 Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.