Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario view is empty after closing and reopening it without changes #1606

Closed
cocreature opened this issue Jun 12, 2019 · 2 comments

Comments

Projects
None yet
1 participant
@cocreature
Copy link
Contributor

commented Jun 12, 2019

Steps to reproduce:

  1. Create a new project with daml new foobar.
  2. Open daml studio
  3. Wait for the Scenario results link to show up and click on it.
  4. The scenario results are shown after a bit of waiting, now close it again.
  5. Click again on the Scenario results link. This time the pane will be empty and stay empty.

The reason for this issue is probably that we do not emit the VRChangedEvent again if only the set of open VRs changed.

@cocreature

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

The reason for why this happens appears to be that we do not get the close event for the VR. We do get another open event but at that point the list of VRs hasn’t changed so the rule is not rerun.

@cocreature

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

We do seem to get close events in general, just not for the scenario pane. Not quite sure why.

cocreature added a commit that referenced this issue Jun 18, 2019

Send didClose notifications when the scenario view is closed
This fixes #1606 which was caused by the fact that VSCode does not
send a close notification if the webview is closed.

The logic here is still a giant mess and has a bunch of stuff leftover
from previous VSCode APIs but I’ll clean it up in a separate PR.

cocreature added a commit that referenced this issue Jun 18, 2019

Send didClose notifications when the scenario view is closed
This fixes #1606 which was caused by the fact that VSCode does not
send a close notification if the webview is closed.

The logic here is still a giant mess and has a bunch of stuff leftover
from previous VSCode APIs but I’ll clean it up in a separate PR.

cocreature added a commit that referenced this issue Jun 19, 2019

Send didClose notifications when the scenario view is closed
This fixes #1606 which was caused by the fact that VSCode does not
send a close notification if the webview is closed.

The logic here is still a giant mess and has a bunch of stuff leftover
from previous VSCode APIs but I’ll clean it up in a separate PR.

cocreature added a commit that referenced this issue Jun 19, 2019

Send didClose notifications when the scenario view is closed
This fixes #1606 which was caused by the fact that VSCode does not
send a close notification if the webview is closed.

The logic here is still a giant mess and has a bunch of stuff leftover
from previous VSCode APIs but I’ll clean it up in a separate PR.

cocreature added a commit that referenced this issue Jun 19, 2019

Send didClose notifications when the scenario view is closed (#1742)
This fixes #1606 which was caused by the fact that VSCode does not
send a close notification if the webview is closed.

The logic here is still a giant mess and has a bunch of stuff leftover
from previous VSCode APIs but I’ll clean it up in a separate PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.