Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the C# namespace in the ledger api proto files so Digital Asset is correctly capitalised #1901

Closed
AndrewDCDrummond opened this issue Jun 26, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@AndrewDCDrummond
Copy link

commented Jun 26, 2019

Currently the protoc generated C# files for the ledger API generate a namespace that is imported like this :

using Com.Digitalasset.Ledger.Api.V1;

however it would look more desirable like this :

using Com.DigitalAsset.Ledger.Api.V1;

to accomplish this aesthetic improvement add the following :

option csharp_namespace = "Com.DigitalAsset.Ledger.Api.V1.Admin";

to all proto file sin the api\v1\admin folder,

option csharp_namespace = "Com.DigitalAsset.Ledger.Api.V1.Testing";

to all files in the api\v1\testing folder, and

option csharp_namespace = "Com.DigitalAsset.Ledger.Api.V1";

to all files in the api/v1 folder.

And propagate the same ot any later versions of the API that will be forthcoming.

Or reject the issue as it is a 'nicety' :-)

@AndrewDCDrummond

This comment has been minimized.

Copy link
Author

commented Jun 27, 2019

looks like this is closed by #1911 :-)

@remyhaemmerle-da

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

@AndrewDCDrummond

looks like this is closed by #1911 :-)

It will be closed once #1911 is merged :-)

@mergify mergify bot closed this in c412d4e Jun 27, 2019

@remyhaemmerle-da

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

Thanks to @AndrewDCDrummond for reporting the issue and describing the way to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.