Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daml-lf-archive does not contain compiled code #2058

Closed
mziolekda opened this issue Jul 9, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@mziolekda
Copy link
Contributor

commented Jul 9, 2019

The daml-lf-archive lirary no longer contains compiled code, it only hosts .proto and .java files. It makes this library virtually unusable. The regression happened between versions 100.13.10 and 100.13.11

gerolf-da added a commit that referenced this issue Jul 9, 2019

Improve logic for building daml-lf-archive-java
daml-lf-archive-java is put together from the proto sources with the
compiled java classes. However, the logic that picks the java classes
was dependent on the output of $(locations :daml_lf_proto_lib_java),
because it always would pick the first item.

The new logic filters by name rather than position.

Fixes #2058.

gerolf-da added a commit that referenced this issue Jul 9, 2019

Improve logic for building daml-lf-archive-java
daml-lf-archive-java is put together from the proto sources with the
compiled java classes. However, the logic that picks the java classes
was dependent on the output of $(locations :daml_lf_proto_lib_java),
because it always would pick the first item.

The new logic filters by name rather than position.

Fixes #2058.

@mergify mergify bot closed this in #2059 Jul 9, 2019

mergify bot added a commit that referenced this issue Jul 9, 2019

Improve logic for building daml-lf-archive-java (#2059)
daml-lf-archive-java is put together from the proto sources with the
compiled java classes. However, the logic that picks the java classes
was dependent on the output of $(locations :daml_lf_proto_lib_java),
because it always would pick the first item.

The new logic filters by name rather than position.

Fixes #2058.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.