Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming JSON API: Wrap events in object #4384

Closed
hurryabit opened this issue Feb 4, 2020 · 0 comments · Fixed by #4453
Closed

Streaming JSON API: Wrap events in object #4384

hurryabit opened this issue Feb 4, 2020 · 0 comments · Fixed by #4453

Comments

@hurryabit
Copy link
Contributor

@hurryabit hurryabit commented Feb 4, 2020

Currently, the streaming JSON API delivers a block of events as

[ E1, E2, ... ]

whereas other messages like heartbeats or warnings are delivered in the form

{ "heartbeat" : "ping" }
{ "warnings": { ... } }

For the sake of consistency, I would prefer if the events are delivered in the form

{ "events": [ E1, E2, ... ] }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.