Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have transaction filtration to agree with disclosure #794

Closed
bitonic opened this issue Apr 30, 2019 · 2 comments

Comments

Projects
None yet
1 participant
@bitonic
Copy link
Contributor

commented Apr 30, 2019

The witnesses in

private def explicitWitnessesForNode(node: GenNode[_, _, _]): Set[Party] = node match {
should agree with the disclosure rules detailed in https://github.com/digital-asset/daml/blob/faf1cde1a1ecd2d76e60977d5ed53c6a487e8785/ledger-api/grpc-definitions/com/digitalasset/ledger/api/v1/event.proto , but right now they do not.

We should fix this, 232e7cb is an attempt but I'm still writing tests.

@bitonic bitonic self-assigned this Apr 30, 2019

@bitonic

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

This was noticed by @gerolf-da

@bitonic

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

@bitonic bitonic added this to the Maintenance milestone Apr 30, 2019

mergify bot added a commit that referenced this issue May 2, 2019

respect contract visibility when looking up contract keys (#753)
* remove outdated flags from comments

* update tests in preparation for visibility rules

* check visibility of contract keys, fixes #751

* add release notes

* include visibility check in scenario runner

* stephen's suggestions

* fix type error in api server example

* scalafmt

* bring TransactionFiltration.scala up to speed with disclosure

see
<https://github.com/digital-asset/daml/blob/faf1cde1a1ecd2d76e60977d5ed53c6a487e8785/ledger-api/grpc-definitions/com/digitalasset/ledger/api/v1/event.proto>
for an in-depth description. fixes #794.

* add tests for contract key visibility

* move a lot of ledger testing utils out of command checks

* move a lot of ledger testing utils out of command checks

* remove useless checks regarding divulgence

* add tests regarding event witnesses

* update release notes

* re-introduce safety when disclosing

@bitonic bitonic closed this Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.