Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1204: Release bindings and codegens to Maven Central. #1205

Merged
merged 13 commits into from Jun 17, 2019

Conversation

@nicholassmith-da
Copy link
Contributor

commented May 17, 2019

Upload the Java and Scala Bindings with the respective code
generator binaries to Sonatype Open Source Repository
Host for synchronization with Maven Central.

Contributes to #170

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

Show resolved Hide resolved release/src/Upload.hs Outdated
Show resolved Hide resolved release/src/Util.hs Outdated
Show resolved Hide resolved ci/release.sh Outdated
@cocreature
Copy link
Contributor

left a comment

Looks like a great start but I’d like to take another look once some of the testing code is removed.

Show resolved Hide resolved release/src/Main.hs Outdated
Show resolved Hide resolved release/src/Main.hs Outdated
Show resolved Hide resolved release/src/Main.hs Outdated
Show resolved Hide resolved release/src/Upload.hs Outdated
Show resolved Hide resolved release/src/Upload.hs Outdated
Show resolved Hide resolved release/src/Upload.hs Outdated
Show resolved Hide resolved release/src/Main.hs Outdated
Show resolved Hide resolved release/src/Util.hs Outdated
Show resolved Hide resolved release/src/Util.hs Outdated
Show resolved Hide resolved release/src/Util.hs Outdated

@nicholassmith-da nicholassmith-da force-pushed the buildsystem-public-maven-central branch 6 times, most recently from d3e19fc to ba20a6d May 29, 2019

@nicholassmith-da nicholassmith-da force-pushed the buildsystem-public-maven-central branch 4 times, most recently from 0b317b7 to 7e899a4 Jun 6, 2019

@nicholassmith-da nicholassmith-da marked this pull request as ready for review Jun 11, 2019

@gerolf-da
Copy link
Contributor

left a comment

Excellent. Please extend the scala_source_jar rule to also accept srcjar labels.

Show resolved Hide resolved docs/source/app-dev/bindings-java/index.rst Outdated
Show resolved Hide resolved ledger-api/grpc-definitions/BUILD.bazel
@bethaitman
Copy link
Contributor

left a comment

Docs suggestions.

Show resolved Hide resolved docs/source/app-dev/bindings-java/index.rst Outdated
Show resolved Hide resolved docs/source/app-dev/bindings-java/index.rst Outdated
Show resolved Hide resolved docs/source/support/release-notes.rst Outdated
Show resolved Hide resolved docs/source/support/release-notes.rst Outdated

@nicholassmith-da nicholassmith-da force-pushed the buildsystem-public-maven-central branch from a77aabc to 6bae485 Jun 14, 2019

Show resolved Hide resolved release/src/Types.hs Outdated
Show resolved Hide resolved release/src/Types.hs Outdated
Show resolved Hide resolved release/src/Main.hs Outdated
Show resolved Hide resolved release/src/Util.hs Outdated

@nicholassmith-da nicholassmith-da force-pushed the buildsystem-public-maven-central branch 2 times, most recently from cbb3f00 to 73c9870 Jun 17, 2019

@cocreature
Copy link
Contributor

left a comment

Nice work!
I’m basically happy with it but there are a few things left over from testing that might break our release process so requesting changes and I’ll take a final look once those are fixed.

Show resolved Hide resolved ci/release.sh Outdated
Show resolved Hide resolved ci/release.sh Outdated
Show resolved Hide resolved docs/source/app-dev/bindings-java/index.rst Outdated
Show resolved Hide resolved docs/source/app-dev/bindings-java/index.rst Outdated
Show resolved Hide resolved docs/source/support/release-notes.rst Outdated
Show resolved Hide resolved release/artifacts.yaml
Show resolved Hide resolved release/src/Main.hs Outdated
Show resolved Hide resolved release/src/Main.hs Outdated
Show resolved Hide resolved release/src/Options.hs
Show resolved Hide resolved release/src/Util.hs Outdated

@nicholassmith-da nicholassmith-da requested a review from cocreature Jun 17, 2019

nicholassmith-da and others added some commits May 13, 2019

Fixes #1204: Release bindings and codegens to Maven Central.
Upload the Java and Scala Bindings with the respective code
generator binaries to Sonatype Open Source Repository
Host for synchronization with Maven Central.
Update docs/source/app-dev/bindings-java/index.rst
Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>
Update docs/source/app-dev/bindings-java/index.rst
Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>
Update docs/source/support/release-notes.rst
Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>
Update docs/source/support/release-notes.rst
Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>

@nicholassmith-da nicholassmith-da force-pushed the buildsystem-public-maven-central branch from 7a8baf1 to 4e921d1 Jun 17, 2019

@cocreature
Copy link
Contributor

left a comment

Ship it!

Superseded by @cocreature review

@nicholassmith-da nicholassmith-da merged commit 0c0e423 into master Jun 17, 2019

7 checks passed

Summary 2 potential rules
Details
digital-asset.daml Build #20190617.59 succeeded
Details
digital-asset.daml (Linux) Linux succeeded
Details
digital-asset.daml (Windows) Windows succeeded
Details
digital-asset.daml (macOS) macOS succeeded
Details
digital-asset.daml (perf) perf succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@nicholassmith-da nicholassmith-da deleted the buildsystem-public-maven-central branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.