Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving logging, using scala-logging #1518

Merged
merged 2 commits into from Jun 4, 2019

Conversation

Projects
None yet
2 participants
@leo-da
Copy link
Contributor

commented Jun 4, 2019

check-enabled SLF4J calls were missing for a lot of trace calls.
switching to scala-logging, it relies on macros, so string concatenation won't happen if logging is disabled.

The main reason:
https://github.com/digital-asset/daml/pull/1518/files#diff-c6d4ab02df08cf4797b274deed4001d2L168
https://github.com/digital-asset/daml/pull/1518/files#diff-c6d4ab02df08cf4797b274deed4001d2L181

Closes: #1502

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@leo-da leo-da requested a review from S11001001 Jun 4, 2019

@leo-da leo-da self-assigned this Jun 4, 2019

@leo-da leo-da added the automerge label Jun 4, 2019

@leo-da leo-da force-pushed the 1502-leo-logging-improvements branch from 4d77a02 to feda417 Jun 4, 2019

@leo-da leo-da requested a review from bethaitman as a code owner Jun 4, 2019

@leo-da leo-da changed the title Improving logging, adding scala-logging Improving logging, using scala-logging Jun 4, 2019

leo-da added some commits Jun 4, 2019

Improving logging, adding scala-logging, #1502
check-enabled calls were missing for a lot of trace calls.
scala-logging relies on macros, so string concatenation won't happen.

@cocreature cocreature force-pushed the 1502-leo-logging-improvements branch from 65cfe1b to a6c9043 Jun 4, 2019

@mergify mergify bot merged commit 8cfcdd6 into master Jun 4, 2019

8 checks passed

Rule: strict rebase (merge) The pull request has been merged automatically
Details
Summary 1 rule matches and 1 potential rule
Details
digital-asset.daml Build #20190604.136 succeeded
Details
digital-asset.daml (Linux) Linux succeeded
Details
digital-asset.daml (Windows) Windows succeeded
Details
digital-asset.daml (macOS) macOS succeeded
Details
digital-asset.daml (perf) perf succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@mergify mergify bot deleted the 1502-leo-logging-improvements branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.