Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extractor, navigator: --ledger-api-inbound-message-size-max option replaces 50MiB hard-coded [package size] limit #1520

Merged

Conversation

@jberthold-da
Copy link
Member

commented Jun 5, 2019

50MiB is no longer hard-coded on extractor, navigator input for sandbox or any other server, permitting large packages; e.g. pass --ledger-api-inbound-message-size-max 62914560 to extractor or navigator to get a 60MiB limit.

Fixes #1463, obsoletes #1501.

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

S11001001 and others added some commits Jun 3, 2019

extractor: --ledger-api-inbound-message-size-max option replaces 50Mi…
…B hard-coded [package size] limit

- Fixes #1463
@bitonic

bitonic approved these changes Jun 5, 2019

@rautenrieth-da

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

Navigator change looks good!

@S11001001 S11001001 changed the title 1463 extractor navigator inbound message size options navigator: --ledger-api-inbound-message-size-max option replaces 50MiB hard-coded [package size] limit Jun 5, 2019

@jberthold-da jberthold-da requested a review from bethaitman as a code owner Jun 5, 2019

@S11001001 S11001001 changed the title navigator: --ledger-api-inbound-message-size-max option replaces 50MiB hard-coded [package size] limit extractor, navigator: --ledger-api-inbound-message-size-max option replaces 50MiB hard-coded [package size] limit Jun 5, 2019

@S11001001
Copy link
Contributor

left a comment

Will split off the large package fail/pass test to another PR, possibly after #1496 so we don't get noise from that change.

@S11001001 S11001001 merged commit 5ffe4a7 into master Jun 5, 2019

7 checks passed

Summary 2 potential rules
Details
digital-asset.daml Build #20190605.42 succeeded
Details
digital-asset.daml (Linux) Linux succeeded
Details
digital-asset.daml (Windows) Windows succeeded
Details
digital-asset.daml (macOS) macOS succeeded
Details
digital-asset.daml (perf) perf succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@S11001001 S11001001 deleted the 1463-extractor-navigator-inbound-message-size-options branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.