Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement package management API in the sandbox #1610

Merged
merged 24 commits into from Jun 19, 2019

Conversation

Projects
None yet
5 participants
@rautenrieth-da
Copy link
Contributor

commented Jun 12, 2019

This PR implements the package management API in the sandbox.

The packages are not stored yet in the database.

Fixes #1311.

@rautenrieth-da rautenrieth-da force-pushed the 1311-package-upload-rebased branch from d2e90c4 to 0b10c8f Jun 12, 2019

@rautenrieth-da rautenrieth-da force-pushed the 1311-package-upload-rebased branch 2 times, most recently from 8152b7d to 6aa8c2d Jun 14, 2019

@rautenrieth-da rautenrieth-da marked this pull request as ready for review Jun 14, 2019

@gerolf-da
Copy link
Contributor

left a comment

Awesome, thanks @rautenrieth-da 🎉
Also big for putting the changes after the review in separate small commits. Makes the re-reviewing much faster 👍

@rautenrieth-da rautenrieth-da force-pushed the 1311-package-upload-rebased branch from 6aa8c2d to 8bb66ce Jun 18, 2019

@rautenrieth-da

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

@S11001001 I have addressed your review comments, could you please have another look?

@rautenrieth-da rautenrieth-da force-pushed the 1311-package-upload-rebased branch from 8bb66ce to 1d1f428 Jun 18, 2019

* message. See the comments on [[ReadService.stateUpdates]] and [[Update]] for
* further details.
*
* @param archives : DAML-LF packages to be uploaded to the ledger.

This comment has been minimized.

Copy link
@gerolf-da

gerolf-da Jun 18, 2019

Contributor

Should be payload

@rautenrieth-da rautenrieth-da force-pushed the 1311-package-upload-rebased branch 3 times, most recently from bb1af2b to 626e0dd Jun 19, 2019

@rautenrieth-da rautenrieth-da force-pushed the 1311-package-upload-rebased branch from 626e0dd to f3763b9 Jun 19, 2019

@rautenrieth-da rautenrieth-da force-pushed the 1311-package-upload-rebased branch from f3763b9 to 5e866b0 Jun 19, 2019

@mergify mergify bot merged commit c14b909 into master Jun 19, 2019

7 checks passed

Summary 1 rule matches and 1 potential rule
Details
digital-asset.daml Build #20190619.31 succeeded
Details
digital-asset.daml (Linux) Linux succeeded
Details
digital-asset.daml (Windows) Windows succeeded
Details
digital-asset.daml (macOS) macOS succeeded
Details
digital-asset.daml (perf) perf succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@mergify mergify bot deleted the 1311-package-upload-rebased branch Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.