Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename "contracts" to "events" in JSON API exercise response #4436

Merged
merged 2 commits into from Feb 6, 2020
Merged

rename "contracts" to "events" in JSON API exercise response #4436

merged 2 commits into from Feb 6, 2020

Conversation

S11001001
Copy link
Contributor

Fixes #4385.

CHANGELOG_BEGIN
- [JSON API - Experimental] Exercise response field "contracts" renamed to "events".
  See `issue #4385 <https://github.com/digital-asset/daml/issues/4385>`_.
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@S11001001
rename "contracts" to "events" in JSON API exercise response
33f8af6 
CHANGELOG_BEGIN
- [JSON API - Experimental] Exercise response field "contracts" renamed to "events".
  See `issue #4385 <https://github.com/digital-asset/daml/issues/4385>`_.
CHANGELOG_END
@S11001001 S11001001 added the component/json-api HTTP JSON API label Feb 6, 2020
@S11001001 S11001001 added this to the HTTP JSON API Maintenance milestone Feb 6, 2020
@S11001001 S11001001 requested review from hurryabit, leo-da and a user February 6, 2020 19:17
@S11001001 S11001001 requested a review from a user February 6, 2020 19:17
@S11001001 S11001001 self-assigned this Feb 6, 2020
shayne-fletcher
shayne-fletcher approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@shayne-fletcher shayne-fletcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank-you.

@S11001001 S11001001 removed the request for review from a user February 6, 2020 19:25
@S11001001
more events in doc
a9afe39 
- pointed out by @leo-da; thanks
@mergify mergify bot merged commit 2a2479a into master Feb 6, 2020
@mergify mergify bot deleted the 4385-contracts-events branch February 6, 2020 20:13
hurryabit
hurryabit reviewed Feb 8, 2020
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks a lot.

@stefanobaghino-da stefanobaghino-da added the team/ledger-clients Related to the Ledger Clients team's components. label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit left review comments

@shayne-fletcher shayne-fletcher shayne-fletcher approved these changes

@leo-da leo-da leo-da approved these changes

@bame-da bame-da Awaiting requested review from bame-da

@nemanja-da nemanja-da Awaiting requested review from nemanja-da

Assignees

@S11001001 S11001001

Labels
component/json-api HTTP JSON API team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Milestone
HTTP JSON API Maintenance
Development

Successfully merging this pull request may close these issues.

JSON API: Rename events field of exercise response from "contracts" to "events"
5 participants
@S11001001 @shayne-fletcher @hurryabit @leo-da @stefanobaghino-da