Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DA.Internal.Desugar #6

merged 5 commits into from Apr 5, 2019


None yet
3 participants
Copy link

shayne-fletcher-da commented Apr 4, 2019

In this PR, unqualified occNames of Template, Choice, concat, toParties, Eq, Show and nonconsuming are replaced with qualified occNames of module DA.Internal.Desugar.

shayne-fletcher-da added some commits Apr 4, 2019

Use qualified names from DA.Internal.Desugar
Replace unqualified occNames with qualified names for `Template`, `Choice`, `Show`, `Eq`, `concat` and `toParties`.

neil-da approved these changes Apr 5, 2019

Copy link

neil-da left a comment

Looks good, although I would recommend following with my change.

Show resolved Hide resolved compiler/parser/RdrHsSyn.hs Outdated
Copy link

martin-drhu-da left a comment

Looks good. I agree with Neil's proposal.


This comment has been minimized.

Copy link

neil-da commented Apr 5, 2019

Much nicer!

@shayne-fletcher-da shayne-fletcher-da merged commit fc69df4 into da-master Apr 5, 2019

@shayne-fletcher-da shayne-fletcher-da deleted the use-da-internal-desguar branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.