add a screensaver #621
add a screensaver #621
Conversation
benma
force-pushed
the
screensaver
branch
2 times, most recently
from
cc05f22
to
4c360a3
Compare
not exactly precise after the last few tests I had at least before this PR. if you use U2F you unlock the device and get the see bitboxapp screen after using regardless, so it's not really a good indicator of it being locked. |
Right, to be accurate: it is shown until a noise connection is requested by the host, which does not happen via U2F. This is inconsistent, good catch! |
|
honestly I am not even sure whether that's that useful info to the user, rather than the acutal lock state. |
This is pretty much solved with the reduced brightness during the screensaver, which makes it clear that one left the screensaver. |
it helps but if anyone wants or cares, I do have (a prototype of) a bouncing shiftcrypto logo similar to the screensavers of DVD Players back in the day |
benma
force-pushed
the
screensaver
branch
2 times, most recently
from
ad43cfd
to
6644765
Compare
not anymore :-) |
Currently set to ~1min until activation, see screen_saver.c - ACTIVE_AFTER.
The screensaver is reset with any touch or any screen_stack
change. The latter means there is something new for the user to see.
API calls per se do not reset the screensaver - only if they display
something via screen_stack.
The screensaver currently also appears if the user is in the middle of
a workflow or API call, if they do not interact with the device. It is
unclear if this is desirable, but in general it would work well
together with a general API timeout or automatic device lock.
Animation: logo scrolls from left ouf of screen to right out of
screen, and wraps around one pixel lower. For a short while before the
logo is visible, the screen is black, so that the change to the
screensaver is not too quick.
Finally, some more thinking is required around the three main screens
and when and how to present them:
1. "See the BitBoxApp" - currently shown until unlocked.
2. Default waiting screen when nothing is going on. Shows the
BitBox02 logo.
3. Screensaver after inactivity. Currently it is an animated
BitBox02 logo.
Currently it is confusing to leave the animated screensaver just to go
back to the same image logo.
yes ;) addressed all comments, PTAL |
|
what's PTAL? |
|
@My1 PTAL = please take another look. LGTM = looks good to me. Just quicker to type. |
|
to be honest, caging the screensaver in like I did took me a bit lol. basically no matter where the thing is it will fly towards the screen, and when inside (even on just one axis) the bounce logic will activate for that axis or if in screen obviously constrained to that. |
|
|
Currently set to ~1min until activation, see screen_saver.c - ACTIVE_AFTER.
The screensaver is reset with any touch or any screen_stack
change. The latter means there is something new for the user to see.
API calls per se do not reset the screensaver - only if they display
something via screen_stack.
The screensaver currently also appears if the user is in the middle of
a workflow or API call, if they do not interact with the device. It is
unclear if this is desirable, but in general it would work well
together with a general API timeout or automatic device lock.
Finally, some more thinking is required around the three main screens
and when and how to present them:
BitBox02 logo.
BitBox02 logo.
Currently it is confusing to leave the animated screensaver just to go
back to the same image logo.