New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe ingedient settings not properly loaded into UI #308

Closed
jmc-comitas opened this Issue Dec 14, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@jmc-comitas
Copy link

jmc-comitas commented Dec 14, 2018

Describe the bug
After saving a recipe ingedient. eg. Load Preset, or Highlight Region, the "Monitor" or "Preset" settings are not loaded and appear to be unset. Upon inspection of the config.json file, they do appear to be saved, and hotkeys using them do work.

To Reproduce
Steps to reproduce the behavior:

  1. Create a recipe
  2. Add a "Load preset" ingredient
  3. Select a monitor and preset.
  4. Save the recipe.
  5. Return to the main settings menu with the back button.
  6. Re-enter the recipes dialog, select the recipe just created.
  7. Select the "Load preset" ingedient
  8. The settings appear to be unset, although they are set and still work (verified in config.json). Also happens with the "Highlight regions" ingredient

Expected behavior
The existing settings should be properly loaded into the UI.

Screenshots
image

System information:

  • Windows 10 Build 1803
  • MaxTo version 2.0.0-beta4 (also beta3, did not try/use before beta 3)

Additional context
There are no related errors or information in the MaxTo log regarding this issue.

@jmc-comitas

This comment has been minimized.

Copy link
Author

jmc-comitas commented Jan 14, 2019

This is still happening to me, as well as my colleagues that use v2, as of beta7.

@vegardlarsen vegardlarsen added this to the 2.0.0 milestone Jan 15, 2019

@vegardlarsen vegardlarsen self-assigned this Jan 15, 2019

@vegardlarsen vegardlarsen added the bug label Jan 15, 2019

@vegardlarsen

This comment has been minimized.

Copy link
Member

vegardlarsen commented Jan 15, 2019

Thank you for the nudge. I will be looking into this issue, and hopefully have a fix before version 2.0.0 goes final.

@vegardlarsen vegardlarsen modified the milestones: 2.0.0, 2.0.0-beta.8 Jan 18, 2019

@vegardlarsen

This comment has been minimized.

Copy link
Member

vegardlarsen commented Jan 18, 2019

This issue has been fixed for 2.0.0-beta.8, which I will release in a little while (it is building now).

@jmc-comitas

This comment has been minimized.

Copy link
Author

jmc-comitas commented Jan 18, 2019

Thanks. Can confirm it is now fixed in beta8.

@vegardlarsen

This comment has been minimized.

Copy link
Member

vegardlarsen commented Jan 18, 2019

Thanks for the confirmation! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment